ghubstan
e63a6c5771
Remove comment
2020-09-22 18:45:50 -03:00
ghubstan
c4dd041d97
Don't use static boilerplate helpers if not necessary
2020-09-22 18:20:23 -03:00
ghubstan
1d88d27330
Remove final modifiers
2020-09-22 18:11:55 -03:00
ghubstan
6a5040228e
Add simple create payment acct test
...
And make test dispute agent registration work from static fixture
setup methods.
2020-09-22 18:05:09 -03:00
ghubstan
1f307c8263
Fix indentation
2020-09-22 16:31:31 -03:00
ghubstan
8896372a0f
Move test dispute agent type constants to core
...
The string constants deleted from the test case are re-defined as enums,
but the test harness still passes around strings (enum.name()) because
the handling of invalid dispute agent type string args needs to be
tested. (Reminder: CLI does not accept any enum arguments.)
2020-09-22 15:31:38 -03:00
Oscar Guindzberg
abcd065325
DAO setup doc fix
...
Stress a full dao seed node is required to run lite nodes.
2020-09-22 15:24:23 -03:00
Oscar Guindzberg
6ba0d6197e
Remove unnecessary comment
2020-09-22 15:06:43 -03:00
Oscar Guindzberg
f529e463d3
Remove unnecessary code
2020-09-22 15:06:43 -03:00
Oscar Guindzberg
ab4333eaaa
Rename kcg to kcgBuilder
2020-09-22 15:06:43 -03:00
Oscar Guindzberg
4558bf4c0c
Remove unused imports
2020-09-22 15:06:42 -03:00
Oscar Guindzberg
1becf89371
Remove unused WalletConfig.walletFactory
2020-09-22 15:06:42 -03:00
Oscar Guindzberg
59124e3e33
Replace deprecated bitcoinj methods
...
Replace output.getAddressFromP2PKHScript() and
output.getAddressFromP2SH() with
output.getScriptPubKey().getToAddress()
2020-09-22 14:55:47 -03:00
ghubstan
34cfe9532f
Remove comment
2020-09-22 14:51:31 -03:00
ghubstan
9132722bbf
Replace hardcoded version with Version.java value
...
Bats version check tests now use a bash script for parsing
the value from the Bisq class file, and these test cases
no longer need to be manually updated.
2020-09-22 14:45:21 -03:00
Oscar Guindzberg
c1c9ff3de8
Fix logging message
2020-09-22 14:07:31 -03:00
jmacxx
3e22b6e98d
Do not persist offer security deposit in user settings
...
Fixes #4426
Always calculate the suggested security deposit based on asset price
volatility rather than using a persisted value as the minimum.
2020-09-22 11:39:02 -05:00
Christoph Atteneder
e3b3c625b3
Merge pull request #4548 from ghubstan/use-legacyaddress-frombase58
...
Remove unused, broken accessor
2020-09-22 16:32:50 +02:00
Christoph Atteneder
71373741da
Merge pull request #4547 from wiz/reduce-logging-for-statsnode
...
Set btcdcli4j loglevel to WARN for statsnode entrypoint, fixes #4537
2020-09-22 16:24:20 +02:00
Christoph Atteneder
44bf29b67e
Merge pull request #4546 from oscarguindzberg/code-cleanup
...
Minor code cleanup changes
2020-09-22 16:23:31 +02:00
Christoph Atteneder
64d4b9b136
Merge pull request #4544 from oscarguindzberg/removeListeners
...
Remove unnecessary listeners in TransactionsView
2020-09-22 16:22:37 +02:00
Christoph Atteneder
69d533d9ea
Merge pull request #4520 from cd2357/show-qubes-info-popup
...
Show info popup if Bisq started under Qubes OS
2020-09-22 16:21:03 +02:00
ghubstan
86c62c1333
Revert WalletService change (accessor breaks build)
...
The accessor added in commit e2bd89f
2020-09-22 11:16:53 -03:00
sqrrm
3d07c064e4
Merge pull request #4534 from ghubstan/daemon-status-scratch
...
Give core api a simple way to verify init status
2020-09-22 11:41:12 +02:00
sqrrm
c814e3b8ed
Merge pull request #4540 from ghubstan/remove-strings
...
Reduce apitest harness' dependency on string matching
2020-09-22 11:39:32 +02:00
sqrrm
dee92670c5
Merge pull request #4539 from ghubstan/refactor-bisqdaemonmain
...
Refactor API & add registerdisputeagent method to CLI
2020-09-22 11:37:18 +02:00
chimp1984
527f1537a9
Add listener on BuyerSendCounterCurrencyTransferStartedMessage to resend msg case it has not arrived
...
Add signed witness to PayoutTxPublishedMessage
Remove usage of RefreshTradeStateRequest but leave it for backward compatibility
Move removeMailboxMessageAfterProcessing calls in finally branch
Rename methods
2020-09-22 00:32:28 -05:00
chimp1984
33c816acf6
Move SellerPublishesDepositTx after SellerSendsDepositTxAndDelayedPayoutTxMessage
...
This should help to avoid that the buyer does not get the delayed payout tx.
If a timeout at deposit tx broadcast would prevent that it get out, the peer has at least both transactions.
The timeout could be Bisq internal but the tx gets in reality published. With the previous code we would get interrupted at
SellerPublishesDepositTx and then the SellerSendsDepositTxAndDelayedPayoutTxMessage would never get executed.
2020-09-21 23:41:24 -05:00
chimp1984
971cd57984
Refactoring: cleanups, rename cleanupTradableOnFault
2020-09-21 23:34:07 -05:00
chimp1984
538db2f36f
Move contractHash creation to MakerCreateAndSignContract
2020-09-21 23:26:51 -05:00
chimp1984
0f36ae8928
Refactoring: cleanups
2020-09-21 23:17:50 -05:00
chimp1984
853dac7544
Remove empty task runner
2020-09-21 23:04:45 -05:00
chimp1984
17baf18844
Refactoring: cleanups
2020-09-21 23:01:33 -05:00
chimp1984
e960e12084
Refactoring: cleanups
2020-09-21 22:58:13 -05:00
chimp1984
fdde4b552c
Refactoring: cleanups
2020-09-21 22:29:13 -05:00
chimp1984
9966f9a9a8
Move contractHash creation to TakerVerifyAndSignContract
2020-09-21 22:25:48 -05:00
chimp1984
2aa5feebc1
Move stopTimeout to second message handler
2020-09-21 22:23:01 -05:00
chimp1984
a725227ff3
Refactor: set string at success handlers correctly
2020-09-21 22:20:08 -05:00
chimp1984
53526e3c20
Remove repeated TakerVerifyMakerAccount and TakerVerifyMakerFeePayment from taker protocol
2020-09-21 22:08:24 -05:00
chimp1984
a8a3318f67
Refactoring: cleanups
2020-09-21 22:07:51 -05:00
chimp1984
5705d8e67a
Refactoring: rename inputsForDepositTxResponse , add more checkNotNull checks
2020-09-21 22:01:30 -05:00
chimp1984
e02355704b
Unsubscribe before state is set to avoid duplicate calls
...
Cleanups
2020-09-21 21:53:45 -05:00
chimp1984
03c2fbfb1d
Refactoring: cleanups
2020-09-21 20:45:52 -05:00
chimp1984
dc8ddbd4ae
Refactoring: cleanups
2020-09-21 20:31:22 -05:00
chimp1984
3a7af57a43
Refactoring: cleanups, add more checkNotNull tests
2020-09-21 20:18:47 -05:00
chimp1984
3269e8c6f0
Remove check that account age signature can be null. Such old versions are not supported anymore.
...
Cleanups.
2020-09-21 20:11:06 -05:00
chimp1984
a3864efe9a
Refactor: Remove final
2020-09-21 20:10:16 -05:00
chimp1984
525360c3ce
Use ApplyFilter at start at take offer process.
...
Make paymentAccountPayload nullable
Set TempTradingPeerNodeAddress with value from trade.getTradingPeerNodeAddress()
2020-09-21 20:02:50 -05:00
chimp1984
c88135713e
Revert removal of Nullable. arbitratorNodeAddress is null (confused it with acceptedArbitratorNodeAddresses)
2020-09-21 20:01:24 -05:00
chimp1984
19afb449d5
Refactor: rename inputsForDepositTxRequest to request
...
Remove final
Cleanups
2020-09-21 19:49:36 -05:00
