chimp1984
5d41574931
Refactor: Rename TradeDataValidation.validatePayoutTx to TradeDataValidation.validateDelayedPayoutTx
2020-09-29 23:46:38 -05:00
chimp1984
cfed832acd
Cleanups
2020-09-29 13:49:22 -05:00
chimp1984
3242d86321
Apply code inspection suggestions
2020-09-29 13:08:55 -05:00
chimp1984
11eb24bb53
Simplify statements
2020-09-29 13:04:12 -05:00
chimp1984
87272ad3a5
Use final
2020-09-29 13:02:44 -05:00
chimp1984
4c7f6147e9
Remove not needed stream()
2020-09-29 13:02:32 -05:00
chimp1984
94bc2359ed
Delete unused class
2020-09-29 13:00:33 -05:00
chimp1984
3926a36c3a
Use params for trace logs.
2020-09-29 12:55:23 -05:00
chimp1984
a3c69d5be6
Remove isDebugEnabled if not needed.
...
Cleanup logs.
isDebugEnabled() is not recommended if params are used. It caused more performance costs and adds boilerplate code.
See:
http://logging.apache.org/log4j/1.2/manual.html
"This will not incur the cost of parameter construction if debugging is disabled. On the other hand, if the logger is debug-enabled, it will incur twice the cost of evaluating whether the logger is enabled or not: once in debugEnabled and once in debug. This is an insignificant overhead because evaluating a logger takes about 1% of the time it takes to actually log."
2020-09-29 12:47:19 -05:00
chimp1984
5a2a1d72f6
Remove toProtoNetworkEnvelope call.
...
'protobuf.NetworkEnvelope proto' was only used for debug logs and is expensive serialisation at each message send.
2020-09-29 12:18:08 -05:00
Christoph Atteneder
468a16f2c9
Merge pull request #4567 from oscarguindzberg/remove-unused
...
Remove unused WalletService.freshKey()
2020-09-29 09:57:51 +02:00
Oscar Guindzberg
1e65af51ea
Remove unused WalletService.freshKey()
2020-09-28 18:37:53 -03:00
sqrrm
20135a1662
Merge pull request #4561 from oscarguindzberg/codeCleanup
...
Remove unnecessary WalletService.removeSignatures()
2020-09-27 14:44:43 +02:00
sqrrm
37ce52ba8c
Merge pull request #4555 from jmacxx/fix_security_deposit_display
...
Display the calculated security deposit at order entry
2020-09-27 14:42:48 +02:00
sqrrm
a408dd5a89
Merge pull request #4552 from oscarguindzberg/WalletConfigCleanup
...
Wallet config cleanup
2020-09-27 14:40:51 +02:00
sqrrm
3174778018
Merge pull request #4560 from jmacxx/fix_xmr_amount_check
...
XMR autoconf should get amount from trade not offer
2020-09-27 14:40:23 +02:00
sqrrm
1ea94a539a
Merge pull request #4550 from oscarguindzberg/upgrade-bitcoinj
...
Use bitcoinj 0.15.8 (commit 5312aa3)
2020-09-26 17:25:12 +02:00
Oscar Guindzberg
93d321b995
Use bitcoinj 0.15.8 (commit 5312aa3)
2020-09-26 11:36:48 -03:00
sqrrm
2c252e9577
Merge pull request #4543 from chimp1984/dispute-agent-branch
...
Add signature to dispute result and various other improvements
2020-09-25 23:34:37 +02:00
chimp1984
423cc7134e
Add changes from merge conflict (class was renamed)
2020-09-25 15:01:20 -05:00
chimp1984
25c4b4d0fc
Merge branch 'master_upstream' into dispute-agent-branch
...
# Conflicts:
# core/src/main/java/bisq/core/trade/DelayedPayoutTxValidation.java
2020-09-25 14:53:20 -05:00
chimp1984
8ac468d84f
Commit to trigger travis as it got stuck...
2020-09-25 14:23:06 -05:00
chimp1984
f37446b991
Change log level
2020-09-25 09:39:45 -05:00
sqrrm
00ccec80e3
Merge pull request #4553 from oscarguindzberg/fixdoc
...
DAO setup doc fix
2020-09-25 11:30:24 +02:00
sqrrm
a2a284ef94
Merge pull request #4551 from oscarguindzberg/replaceBitcoinjDeprecated
...
Replace deprecated bitcoinj methods
2020-09-25 11:29:56 +02:00
Oscar Guindzberg
315b9ff5d7
Remove unnecessary WalletService.removeSignatures()
2020-09-25 02:28:29 -03:00
jmacxx
b842a0789c
XMR autoconf should get amount from trade not offer
...
Get the amount from the trade rather than the offer.
Log the expected amount when not matching the explorer result.
It would have made debugging this issue much more straightforward.
Fixes #4557
2020-09-24 10:57:33 -05:00
sqrrm
9ca3c8bded
Merge pull request #4549 from oscarguindzberg/fixlog
...
Fix logging message
2020-09-23 16:57:27 +02:00
Oscar Guindzberg
abcd065325
DAO setup doc fix
...
Stress a full dao seed node is required to run lite nodes.
2020-09-22 15:24:23 -03:00
Oscar Guindzberg
6ba0d6197e
Remove unnecessary comment
2020-09-22 15:06:43 -03:00
Oscar Guindzberg
f529e463d3
Remove unnecessary code
2020-09-22 15:06:43 -03:00
Oscar Guindzberg
ab4333eaaa
Rename kcg to kcgBuilder
2020-09-22 15:06:43 -03:00
Oscar Guindzberg
4558bf4c0c
Remove unused imports
2020-09-22 15:06:42 -03:00
Oscar Guindzberg
1becf89371
Remove unused WalletConfig.walletFactory
2020-09-22 15:06:42 -03:00
Oscar Guindzberg
59124e3e33
Replace deprecated bitcoinj methods
...
Replace output.getAddressFromP2PKHScript() and
output.getAddressFromP2SH() with
output.getScriptPubKey().getToAddress()
2020-09-22 14:55:47 -03:00
Oscar Guindzberg
c1c9ff3de8
Fix logging message
2020-09-22 14:07:31 -03:00
jmacxx
3e22b6e98d
Do not persist offer security deposit in user settings
...
Fixes #4426
Always calculate the suggested security deposit based on asset price
volatility rather than using a persisted value as the minimum.
2020-09-22 11:39:02 -05:00
Christoph Atteneder
e3b3c625b3
Merge pull request #4548 from ghubstan/use-legacyaddress-frombase58
...
Remove unused, broken accessor
2020-09-22 16:32:50 +02:00
Christoph Atteneder
71373741da
Merge pull request #4547 from wiz/reduce-logging-for-statsnode
...
Set btcdcli4j loglevel to WARN for statsnode entrypoint, fixes #4537
2020-09-22 16:24:20 +02:00
Christoph Atteneder
44bf29b67e
Merge pull request #4546 from oscarguindzberg/code-cleanup
...
Minor code cleanup changes
2020-09-22 16:23:31 +02:00
Christoph Atteneder
64d4b9b136
Merge pull request #4544 from oscarguindzberg/removeListeners
...
Remove unnecessary listeners in TransactionsView
2020-09-22 16:22:37 +02:00
Christoph Atteneder
69d533d9ea
Merge pull request #4520 from cd2357/show-qubes-info-popup
...
Show info popup if Bisq started under Qubes OS
2020-09-22 16:21:03 +02:00
ghubstan
86c62c1333
Revert WalletService change (accessor breaks build)
...
The accessor added in commit e2bd89f
broke the build, and was not
used as originally intended -- by CoreWalletsService -- because the
the api's wallet methods need addresses from the wallet, not just
a valid address.
2020-09-22 11:16:53 -03:00
sqrrm
3d07c064e4
Merge pull request #4534 from ghubstan/daemon-status-scratch
...
Give core api a simple way to verify init status
2020-09-22 11:41:12 +02:00
sqrrm
c814e3b8ed
Merge pull request #4540 from ghubstan/remove-strings
...
Reduce apitest harness' dependency on string matching
2020-09-22 11:39:32 +02:00
sqrrm
dee92670c5
Merge pull request #4539 from ghubstan/refactor-bisqdaemonmain
...
Refactor API & add registerdisputeagent method to CLI
2020-09-22 11:37:18 +02:00
wiz
ca00433492
Set btcdcli4j loglevel to WARN for statsnode entrypoint, fixes #4537
2020-09-22 06:30:14 +09:00
Oscar Guindzberg
64dc4fbf84
Remove unused code from WalletConfig
2020-09-21 18:22:41 -03:00
Oscar Guindzberg
6cf7a9977a
Code cleanup
2020-09-21 17:32:47 -03:00
Oscar Guindzberg
c890d3c02a
Remove unused code
2020-09-21 17:19:01 -03:00