Commit graph

2186 commits

Author SHA1 Message Date
chimp1984
5a0634f94d
Move methods to AveragePriceUtil 2020-12-07 13:24:17 -05:00
chimp1984
469f9494ba
Remove empty class 2020-12-07 13:22:01 -05:00
chimp1984
f745f0f0d6
Move methods from AxisInlierUtils to InlierUtil
We will need some of those methods later inside another core util class.
2020-12-07 13:21:44 -05:00
sqrrm
74485f0844
Merge pull request #4884 from ghubstan/01-refactor-getdust
Refactor: move getDust(Transaction transaction)
2020-12-07 14:12:59 +01:00
Christoph Atteneder
9e3968e5f4
Merge pull request #4892 from deusmax/market-offer-filter-bugfix
Offer Book chart outlier filter improved.
2020-12-04 16:54:25 +01:00
Deus Max
d60030e2f2
Offer Book chart outlier filter improved.
Outlier data filter used for the Market Offer Book chart, now accounts
for the switching display position of Buy, Sell data depending on
currency type (Crypto or Fiat).
2020-12-03 21:06:34 +02:00
ghubstan
74261b1749
Refactor: move getDust(Transaction transaction)
The api is going to need this method, so it was moved from desktop to core.

- Moved the method from WithdrawalView to WalletService.

- Removed an unused initilizer in WithdrawalView.
2020-12-03 12:16:04 -03:00
Deus Max
c7290ee091
Replace use of Collections to FXCollections in desktop.
Replace use of java library java.util.Collections with
javafx.collections.FXCollections instead.
Bisq issue#4388.
2020-12-02 21:38:50 +02:00
Christoph Atteneder
09677151a6
Merge pull request #4863 from jmacxx/account_usability
Account management usability improvements
2020-12-01 14:04:49 +01:00
jmacxx
0af139c666
Fix NPE in test routine caused by PaymentAccount with no name 2020-11-30 09:45:24 -06:00
Christoph Atteneder
e8a8e3b3a1
Merge pull request #4785 from deusmax/dao_bsq_supply
Touch-ups to the DAO BSQ Supply page
2020-11-30 09:22:20 +01:00
jmacxx
52a4dff0ae
Account management usability improvements
Widen payment account dropdown in create & edit offer screens
Sort payment account dropdown by name in create & edit offer screens
Sort account listview by name in manage fiat accounts screen
Sort account listview by name in manage altcoin accounts screen
Bug fix: do not adjust BTC amount in edit offer screen

There was a bug where editing an existing offer could have its payment
account changed to one with more restrictive limits and the offer
would still be allowed (although not take-able).
It should not be allowed to be saved in this case.  This change takes
proper heed of the "allowAmountUpdate" flag which is false for offer
edits.  e.g. edit an F2F buy for 0.25, change to Zelle unsigned, the
offer will prevent saving.
2020-11-27 14:40:37 -06:00
Deus Max
9d8939c0ca
Touch ups on the DAO BSQ supply page.
* Formatting changes to chart lines and axes.
 * Removed middle chart as it displays no
   new info.
 * Function getMonthTickLabelFormatter rounds the
   tick label display to the nearest month.
   Only used for chart1.
 * New variable chart1XBounds to keep track of
   chart1 X-axis limits, as autoRanging set false.
2020-11-26 18:58:14 +02:00
chimp1984
81a41a25bb
Improve chainHeightSyncing display 2020-11-26 11:20:51 -05:00
Christoph Atteneder
99d5652aef
Merge pull request #4841 from jmacxx/fix_issue_4833
Prompt for confirmation before initiating SPV resync
2020-11-26 16:13:00 +01:00
Christoph Atteneder
4e4711a6f5
Merge pull request #4845 from jmacxx/fix_issue_4641
Show price deviation in portfolio open offers and history view
2020-11-26 15:33:50 +01:00
Christoph Atteneder
11b0a466ce
Merge branch 'master' of github.com:bisq-network/bisq into release/v1.5.0
# Conflicts:
#	core/src/main/java/bisq/core/provider/fee/FeeService.java
#	core/src/main/resources/i18n/displayStrings.properties
#	seednode/src/main/java/bisq/seednode/SeedNodeMain.java
2020-11-25 14:05:37 +01:00
Christoph Atteneder
dbb0160a35
Revert to SNAPSHOT version 2020-11-25 13:46:24 +01:00
jmacxx
2e52b5472f
Show price deviation in portfolio open offers and closed trades
Fixes #4641
2020-11-24 23:03:53 -06:00
jmacxx
395af3c4c8
Prompt for confirmation before initiating SPV resync
Allows user to back off if invoked by accident.
2020-11-23 11:37:31 -06:00
chimp1984
9360e89ae8
Check if user has downgraded to an older version. If so require shutdown
and do not read or write persisted data.

We had recently a case where a user downgraded from 1.4.2 to 1.3.9 and
this caused failed trades and the wallet funds have been missing due to
some complexities of the wallet wegwit upgrade. The fund could be recovered
but it took quite some effort.
As downgrade is never tested and can lead to all kind of weird bugs we
should prevent that users accidentally can do it.
If there is valid reason to downgrade they can remove the version file.
2020-11-20 15:27:50 -05:00
chimp1984
df9ef80edf
Avoid nullpointer 2020-11-20 15:10:39 -05:00
Christoph Atteneder
77aab8a97c
Add error log to get more information on the actual problem 2020-11-19 16:51:45 +01:00
Christoph Atteneder
29b2c33222
Merge pull request #4814 from jmacxx/improve_account_aging_column
Improve UI/UX for account aging column in 'Offers' section of GUI
2020-11-18 10:41:10 +01:00
chimp1984
fa0c28adf6
Add requestPersistence calls
We relied on the shutdwon routine to be called reliably but it seems that is not the case as some bug reports show.
So we call requestPersistence at every write access of the trade object
2020-11-17 22:35:51 -05:00
chimp1984
bf2c94160f
Add delay between remove and add new filter
We saw that some seed nodes have 2 filters after filter update.
This should not be the case as the remove is broadcast before the
add but seems there is some issue in the P2P storage which does
not cover that correctly.
By adding a 5 sec delay between the remove and add we mitigate
that issue, though should be fixes in the P2P layer but that
will be a more complex and larger effort.
2020-11-17 20:14:44 -05:00
jmacxx
f7fac0f3c4
code review change: curlies & whitespace for if statement 2020-11-16 16:15:57 -06:00
jmacxx
dd26077caa
Improve UI/UX for account aging column in 'Offers' section of GUI
Showing 'x' days until limits lifted (signed, pending)
Showing clock icon (signed, pending)
Showing outlined check icon (aging accounts)
Showing account age (unsigned or aging)
Changed column name from 'Signed since' to 'Account info'

Fixed bug when switching between altcoins and fiat order books
the account info column was being added back to the table in
the wrong position.
2020-11-16 10:44:01 -06:00
Christoph Atteneder
3e5bf90bdd
Update release process to match new trade statistics delivery
Also did some minor release process cleanup that was overdue
2020-11-13 12:29:29 +01:00
chimp1984
a238c205ab
Add Amazon eGift Card payment method 2020-11-13 00:26:23 -05:00
Deus Max
b9f49f75d3
Improve view of market offers chart
* Both axes use autoRange, which results in better
    rounded values for the tick mark labels numbers.
  * Filter-out data outside the factor limits.
  * New constant chartDataFactor for factor limits.
  * Formatted tick label currency numbers:
    - Fiat: display with grouping separators
    - Cryptos: remove trailing zeros in fractional parts
  * Add CSS class axisy for y-axis formatting.
2020-11-12 14:35:20 +01:00
Christoph Atteneder
50c7d6c126
Merge pull request #4774 from deusmax/market_offers_chart
Market Offers chart modifications
2020-11-12 14:34:39 +01:00
Christoph Atteneder
34c802d505
Merge pull request #4780 from jmacxx/fix_issue_4719
Add encrypted wallet password prompt when sending funds from BSQ wallet
2020-11-12 09:06:27 +01:00
sqrrm
24102556e0
Merge pull request #4769 from ripcurlx/update-release-process
Update release process to match new trade statistics delivery
2020-11-11 12:39:41 +01:00
Christoph Atteneder
c707e63f35
Merge pull request #4781 from chimp1984/use-30-day-average-for-marektcap
Use 30 days average USD/BSQ price for market cap
2020-11-11 11:10:54 +01:00
Christoph Atteneder
7701ad35d3
Update release process to match new trade statistics delivery
Also did some minor release process cleanup that was overdue
2020-11-11 10:55:00 +01:00
Christoph Atteneder
0c47cf0e20
Merge pull request #4764 from jmacxx/fix_issue_4727
Don't allow trade start if BitcoinJ is not fully synced
2020-11-11 10:44:07 +01:00
jmacxx
48a515be01
Add encrypted wallet password prompt when sending funds from BSQ wallet
Correct wording of transaction confirmation popup to use 'mining fee'
instead of 'transaction fee' to make it consistent with wording of
the BTC confirmation popup.
2020-11-10 20:14:44 -06:00
chimp1984
9135397ded
Use 30 days average USD/BSQ price for market cap 2020-11-10 20:51:13 -05:00
Deus Max
c9936c5595
Improve view of market offers chart
* Both axes use autoRange, which results in better
    rounded values for the tick mark labels numbers.
  * Filter-out data outside the factor limits.
  * New constant chartDataFactor for factor limits.
  * Formatted tick label currency numbers:
    - Fiat: display with grouping separators
    - Cryptos: remove trailing zeros in fractional parts
  * Add CSS class axisy for y-axis formatting.
2020-11-10 22:27:04 +02:00
jmacxx
0ddd333ce6
Don't allow trade start if BitcoinJ is not fully synced
Adds a check that chain height is within 3 blocks of the reported
height from bitcoin peers -> if not the user cannot take an offer
or have an existing offer taken.  It shows a message informing the
user that Bisq is not currently synced, advising them to do an
SPV resync if necessary.

Additionally under Settings/Network a field has been added
to show the chain height of Bisq vs the Peer group.

Added after discussion with chimp1984:
- Correct initialization of chainHeight property
- Rename "Latest BTC block height" display field for clarity
- Enforce chain sync rule for Take Offer scenario
- Enforce chain synch rule for Check offer availability scenario
- change method name to be clearer
2020-11-10 14:15:39 -06:00
chimp1984
b5f88c4932
Check if output is a legacy address.
Remove `sendToAddress != null` check.
2020-11-10 11:11:42 -05:00
chimp1984
7c65000ff2
Cleanups, add null check 2020-11-10 10:16:48 -05:00
Christoph Atteneder
f6a2f3d6e1
Merge pull request #4761 from deusmax/trading_charts_axisY
Apply format to trading charts axis Y values
2020-11-10 08:45:33 +01:00
Oscar Guindzberg
c4131c7398
Rename "tx size" to "tx vsize" 2020-11-05 19:28:45 -03:00
Deus Max
3743b87ac0
Remove trailing zeroes from crypto y-axis tick labels.
The y-axis tick mark labels for crypto (non-fiat)
currencies have a large number of trailing zeroes.
This commit removes the last 3 zeroes from the display.
2020-11-05 22:06:26 +02:00
Oscar Guindzberg
29f23fe50c
Use segwit tx sizes 2020-11-05 11:51:43 -03:00
Oscar Guindzberg
b2023e2366
Use tx.getVsize()
Replace tx.bitcoinSerialize().length
2020-11-05 11:51:43 -03:00
Oscar Guindzberg
06e5091f79
TradeWalletService use P2WSH 2020-11-05 11:47:40 -03:00
Christoph Atteneder
66fcde11bf
Bump version number for v1.5.0 2020-11-05 11:34:40 +01:00