chimp1984
91cc14725c
Add annotation
2020-09-01 20:03:32 -05:00
chimp1984
7c0d24c567
Refactoring: Rename package
...
bisq.core.trade.autoconf to bisq.core.trade.txproof
2020-09-01 19:56:48 -05:00
chimp1984
039860935d
Merge master
...
- fix tests
2020-09-01 19:53:23 -05:00
chimp1984
80d85e68ec
Make constructor private
2020-09-01 19:15:19 -05:00
chimp1984
46394024e9
Dont restart seed if localhost is used
2020-09-01 19:15:06 -05:00
chimp1984
28c8150b6b
Refactoring
...
This is another larger refactoring, sorry ;-)
But the structure was just not correct before. We had handled multiple
trades with multiple results and that is error prone. Now each class
has much more clear responsibilities. Also the result enums are not
changes so that they are better separated between result based and
service bases states.
All different states are still hard to test. We should set up some mock
service to simulate confirmations counting up and error scenarios.
2020-09-01 19:10:43 -05:00
sqrrm
6e77ef08f0
Fix legit codacy complaints
2020-09-02 00:44:19 +02:00
chimp1984
10dcc70538
Change log level if banned seed or price relay is seen from filter.
...
Change log text.
Those banned nodes are quite old and no need to restart the app. In case
we need to really ban a node (the one we banned are just revoked) we can
use the global notification to alert users to restart.
2020-09-01 17:14:01 -05:00
sqrrm
f0acec0cb1
Add option to use different color header in dev mode
...
This is to help differentiate dev instances and live ones.
This can help devs avoiding silly mistakes.
2020-09-01 23:03:22 +02:00
chimp1984
512f1a5972
Refactor AutoConfirmSettings handling in preferences
...
- Do not use immutability for AutoConfirmSettings as it makes setting
values cumbersome.
- Add btc validator for trade limit
- Make AutoConfirmSettings an optional and add find method by currency
code to be better prepared when used for other coins.
- Add static getDefaultForXmr to AutoConfirmSettings
- Move listener creation to init method
2020-09-01 16:00:02 -05:00
Christoph Atteneder
7da3663e1d
Merge pull request #4457 from chimp1984/add-USDT-variants
...
Add Tether (ERC20, Omni and Liquid)
2020-09-01 20:04:57 +02:00
sqrrm
5b1d9cb759
Merge pull request #4453 from chimp1984/add-username-to-revolut
...
Add support for user name for Revolut accounts
2020-09-01 19:52:40 +02:00
sqrrm
7830dbf4e4
Merge pull request #4460 from chimp1984/refactor-filter
...
Refactor filter
2020-09-01 19:48:38 +02:00
chimp1984
580b05968f
Increase timeouts from 10 sec to 30 sec.
...
Over tor connections are slower.
Use TimeUnit.SECONDS.toMillis() for better readability and
making it more clear whats the unit used in the method.
2020-09-01 11:43:56 -05:00
chimp1984
3b4e183633
Use tradeId for prefix for id of request.
...
Remove testKey test (tested uid of model)
Refactor:
- Rename uid to id (we do not have a strict guarantee for uniqueness)
- Move id from model to request (its the id of the request)
2020-09-01 11:18:09 -05:00
chimp1984
77841e230f
Change log level
...
In cased new fields are added to PB this case is expected as well in
development if protbuf definitions have changed over time and persisted
data do not match the new definition. We don't want this log to be
that verbose.
2020-09-01 10:58:00 -05:00
chimp1984
3ec216dcd6
Replace Exception with CryptoNoteException (codacy complaint)
2020-09-01 10:47:28 -05:00
chimp1984
6cc074a15c
Add default clause (codacy complaint)
2020-09-01 10:44:50 -05:00
chimp1984
3ef8abd972
Remove unused constructor
2020-09-01 10:25:54 -05:00
ghubstan
804adf08a3
Remove commented code from BisqAppMain
...
Also fixed line length of a comment, and removed two extra white lines.
2020-09-01 11:03:18 -03:00
ghubstan
7ed5028b8e
Add @VisibleForTesting annotation
...
The access modifier on CompositeOptionSet was changed to public
in commit c402386
2020-09-01 10:58:37 -03:00
ghubstan
1efb8c8bee
Make CoreApi a singleton
2020-09-01 10:49:37 -03:00
sqrrm
43ad831916
Merge pull request #4451 from chimp1984/add-check-for-option-trade
...
Add check for option trade
2020-09-01 11:12:59 +02:00
Florian Reimair
f4a60d80fc
Remove Slack notification in travis build
2020-09-01 09:42:33 +02:00
chimp1984
123183e5e1
Remove CryptoNoteException again as it caused failed tests
...
Damn codacy forces one to not use Exception ;-(
2020-09-01 01:24:14 -05:00
chimp1984
d36306a73c
More refactoring....
2020-09-01 00:56:54 -05:00
chimp1984
4323b417b1
Adjust to codacy complaints
...
codacy does not like raw Exceptions ;-(
- Remove unused method
2020-08-31 19:36:19 -05:00
chimp1984
7b3dc54815
dont use restart routing for seed nodes if in devmode
2020-08-31 19:29:56 -05:00
chimp1984
86999e52d1
- Remove isPublicKeyInList check at remove as its irrelevant (dev could
...
add his key anyway to src code)
- Fix wrong logs
- Remove duplicated line
2020-08-31 17:13:09 -05:00
chimp1984
12ef5aafe0
Update comment
2020-08-31 16:25:07 -05:00
chimp1984
8bf75b5f45
- Filter out prices with code "NON_EXISTING_SYMBOL"
...
- Add comments
2020-08-31 15:19:31 -05:00
chimp1984
b409c8add5
Merge branch 'master_upstream' into add-tether-pinguin
2020-08-31 14:17:59 -05:00
chimp1984
334cb43c3b
Rename verifySignature to isSignatureValid
2020-08-31 13:53:17 -05:00
chimp1984
c755fc2592
Add isPrivilegedDevPubKeyBanned method
...
It is used atm only for filter itself which might have limited effect.
Applying it to alert and priv notification requires adding pubKey fields
there which is outside of the scope of that PR but should be added soon
as well.
2020-08-31 13:51:41 -05:00
chimp1984
5209018f4d
Add pub key
2020-08-31 13:24:02 -05:00
chimp1984
78142bda7d
Fix tests
2020-08-31 13:23:51 -05:00
chimp1984
4a2f7dc92c
Rename bannedSignerPubKeys to bannedAccountWitnessSignerPubKeys
...
We use several signing keys, so better to make it more explicit.
protobuf entry is not changed to not risk issues (i guess it would
work renaming it)
2020-08-31 13:01:44 -05:00
chimp1984
9a142be86e
Add bannedPrivilegedDevPubKeys field
2020-08-31 12:51:01 -05:00
chimp1984
1b5e449114
Remove dev test code
2020-08-31 12:34:16 -05:00
chimp1984
cc20a3b6c7
- Add support for multiple pubKeys
...
- Add more validation
- Add SignerPubKeyAsHex to filter
- Refactor add/remove filter code
2020-08-31 12:33:45 -05:00
sqrrm
4d32da7289
Merge pull request #4420 from stejbac/fix-blank-offer-book-price-cells
...
Fix intermittent blank price cells in offer book view
2020-08-31 19:02:19 +02:00
sqrrm
c551adb441
Merge pull request #4436 from chimp1984/bundle-msg-at-broadcast
...
Bundle messages at broadcast
2020-08-31 18:01:14 +02:00
chimp1984
e2de5221bf
Fix + prefix in string keys
2020-08-31 10:51:21 -05:00
chimp1984
f7951d5943
Combine if/else branches. Improve comments and variables
2020-08-31 10:38:46 -05:00
chimp1984
bc802c861d
Change log level to avoid too verbose logs
2020-08-31 10:37:58 -05:00
chimp1984
5555c43ea9
Merge branch 'master_upstream' into refactor-filter
2020-08-31 10:15:42 -05:00
chimp1984
591011e516
Add comment
2020-08-31 09:51:53 -05:00
chimp1984
59ebefc7d9
Revert to use empty string as default for accountId instead of null.
...
Prefer to keep old functionality here...
2020-08-31 09:47:35 -05:00
sqrrm
136da0c481
Merge pull request #4443 from ghubstan/upgrade-jfoenix
...
Upgrade JFoenix to v9.0.10
2020-08-31 16:41:47 +02:00
sqrrm
8c6b525553
Merge pull request #4433 from ghubstan/5-add-remote-debug-option
...
Allow remote debugging of background Bisq apps
2020-08-31 16:39:33 +02:00
