Commit Graph

12909 Commits

Author SHA1 Message Date
chimp1984
f817018410
Add null checks, remove verbose logs from IllegalArgumentException branch 2020-10-30 20:01:01 -05:00
chimp1984
7fe5b80d39
Add more logs 2020-10-30 19:20:20 -05:00
ghubstan
3cd3bf0e3e
Fix grammar / typo
This change resolves issue found in PR review.  See
https://github.com/bisq-network/bisq/pull/4703#discussion_r515076872
2020-10-30 11:52:37 -03:00
ghubstan
f764e9feb0
Simplify TradeUtil#getPaymentMethodNameWithCountryCode
These changes were requested in review of PR
https://github.com/bisq-network/bisq/pull/4699
2020-10-30 11:15:39 -03:00
ghubstan
0656c57d39
Add null checks in PendingTradesViewModel
These changes were requested in review of PR
https://github.com/bisq-network/bisq/pull/4699
2020-10-30 11:07:18 -03:00
sqrrm
c4e2021e37
Merge pull request #4709 from ghubstan/9-closetrade-protos
Stub out api methods 'keepfunds', 'withdrawfunds'
2020-10-30 14:05:16 +01:00
sqrrm
6079a96c68
Merge pull request #4705 from ghubstan/8-gettrade-json-option
Optionally print the json contract for a given trade id
2020-10-30 14:03:17 +01:00
sqrrm
e059342c89
Merge pull request #4704 from ghubstan/7-cli-gettrade
Add 'gettrade' to api method CLI
2020-10-30 14:00:58 +01:00
sqrrm
8c23017d62
Merge pull request #4703 from ghubstan/6-format-trade
Refactor CLI output formatting code & add trade formatter
2020-10-30 13:59:43 +01:00
sqrrm
3c56268149
Merge pull request #4701 from ghubstan/5-refactor-trade-utils
Add getRole(tradeId) to core api
2020-10-30 13:43:15 +01:00
sqrrm
b6badeee0d
Merge pull request #4700 from ghubstan/4-refactor-trade-utils
Refactor PendingTradesDataModel methods -> TradeUtil
2020-10-30 13:28:42 +01:00
sqrrm
ed14442992
Merge pull request #4699 from ghubstan/3-refactor-trade-utils
Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil
2020-10-30 11:11:15 +01:00
Deus Max
162c119285
Added date format for each chart interval period.
Provide specific formats for each trade chart interval period, for added
precision and flexibility in formatting the X-axis. Covers suggestion in
Bisq PR#4715 for more compact date formats.
2020-10-30 01:17:06 +02:00
sqrrm
258d44ebb7
Merge pull request #4697 from ghubstan/2-refactor-trade-utils
Replace TradeUtils with singleton TradeUtil
2020-10-29 22:36:54 +01:00
sqrrm
3356c8f632
Merge pull request #4696 from ghubstan/1-add-grpc-trade-proto-fields
Add fields to grpc TradeInfo proto & wrapper
2020-10-29 22:31:26 +01:00
sqrrm
407fa3f28c
Merge pull request #4692 from ghubstan/blocking-fee-request
Block on tx-fee-request in core TakeOfferModel init
2020-10-29 22:18:51 +01:00
chimp1984
db3ac48758
Reformat to force codacy update 2020-10-29 13:04:51 -05:00
jmacxx
f73aaae3c7
Updates to 'Edit Offer' to allow for change of market and payment method
Display the trading account group on edit offer screen which allows
the market and payment method to be chosen.

When applying the edits to the new offer payload, merge in appropriate
fields that describe the market & payment method:
- base and counter currency codes
- payment method and account
- country code, accepted country codes
- bankid and accepted bankIds

Fixes #4720
2020-10-29 11:06:47 -05:00
chimp1984
5639a5e474
Add TRANSFERWISE to TradeStatistics3.PaymentMethodMapper 2020-10-28 23:30:56 -05:00
chimp1984
1f45d492ef
Remove todos 2020-10-28 21:52:38 -05:00
chimp1984
ebce18c338
Add transferwise account 2020-10-28 21:35:47 -05:00
ghubstan
c2f8db3c7d
Reduce apitest case execution time
Consolidated all method tests into fewer test cases by running them
from new 'scenario' test cases.  This cuts the current scaffold
setup & teardown times by almost 1/2.  No method tests were deleted
or duplicated.

(1)  Disabled all method (unit) test cases at the class level.
(2)  Added new scenario test cases to run all disabled test cases (1).

The method test cases can still be run by commenting out the @Disabled
annotation.
2020-10-28 18:17:59 -03:00
ghubstan
e8e55d2286
Remove redundant ScenarioTest superclass 2020-10-28 18:01:49 -03:00
ghubstan
f61f148db1
Refactor api test fixture setup
- Remove dead code from AbstractLinuxProcess.

- Make default dummy accts static in MethodTest.

- Simplify gRPC stub creation, btc block generation, dispute agent
  registration, and dummy acct initialization in test case startup.

- Make ExpectedProtocolStatus visible to scenario test pkg.
2020-10-28 17:59:15 -03:00
ghubstan
2a05203519
Remove dead code 2020-10-28 17:46:30 -03:00
ghubstan
d6524bf46d
Improve apitest cmd line console logging
- Show full stack traces in console
- Do use previously cached test outputs
- Do not show skipped test name in console (too noisy)
- Show test run summary, including number of skipped tests
- Show note about skipped test info in the html report
- Show link to html report on test SUCCESS
2020-10-28 17:39:50 -03:00
ghubstan
8e51e1e495
Upgrade jupiterVersion = '5.7.0'
This upgrades jupiter for all subprojects using this library, but
it does not affect released code.
2020-10-28 17:21:04 -03:00
Deus Max
c0af9f9637
Cleaner formatting for trading charts date axes
Clean up date axes style for easy reading. Made date labels shorter,
with clear visual correspondance to relevant axes tick mark.
Tick marks with labels are now larger than those without.

Signed-off-by: Deus Max <deusmax@gmx.com>
2020-10-28 14:23:05 +02:00
Christoph Atteneder
50ab4283b2
Merge pull request #4718 from jmacxx/fix_issue_4708
Cleanup user interface elements in Send Funds screen
2020-10-28 10:02:16 +01:00
jmacxx
a5c62a545d
Cleanup user interface elements in Send Funds screen
Selects "Amount includes mining fee" by default.  Fixes #4708
Unrestrict the length of "Withdraw to address" & "Withdrawal memo" fields.  Fixes #4656
2020-10-27 18:06:30 -05:00
sqrrm
9a871373c2
Merge pull request #4681 from oscarguindzberg/removeAddressClassFromBsqClasses
Use LegacyAddress instead of Address for BSQ
2020-10-27 23:59:44 +01:00
sqrrm
917ab4ee32
Merge pull request #4689 from chimp1984/revert-dao-data-json-export-changes
Revert changes for json export of dao data
2020-10-27 23:58:35 +01:00
ghubstan
91a2e2ce1f
Add canceloffer test 2020-10-27 19:06:59 -03:00
sqrrm
91bc88c86c
Merge pull request #4695 from chimp1984/cleanup-monitor-module
Cleanup monitor module
2020-10-27 19:55:59 +01:00
ghubstan
b38507c6e6
Implement api method 'canceloffer' 2020-10-27 15:31:57 -03:00
sqrrm
6cb0130a41
Merge pull request #4694 from cd2357/update-tor-repos
Update netlayer references to bisq repos
2020-10-27 19:27:20 +01:00
ghubstan
0f1d4f8ac3
Fix typo 2020-10-27 15:03:36 -03:00
ghubstan
027a7d5cd3
Stub out canceloffer api method
The implementation will be added to CoreOffersService in the next PR.
2020-10-27 14:54:50 -03:00
Oscar Guindzberg
8370bc98d5
Use LegacyAddress instead of Address for BSQ 2020-10-27 13:56:20 -03:00
ghubstan
2746b27674
Fix apitest dummy payment acct init bug
This commit fixes non-trade tests broken by the last refactoring.
2020-10-27 13:47:23 -03:00
ghubstan
1e25be5bdc
Test trade closing api methods 'keepfunds' withdrawfunds'
Some refactoring of the api test case hierarchy is included in this commit.
2020-10-27 13:04:53 -03:00
ghubstan
b8ae566b69
Add method for printing current jupiter test name 2020-10-27 13:03:48 -03:00
ghubstan
f1db254073
Make formatSatoshis visible for testing 2020-10-27 13:01:33 -03:00
ghubstan
a3631a022f
Implement api methods 'keepfunds', 'withdrawfunds'
The CoreTradesService was refactored to work for newly added api methods:

- keepfunds -- close trade, keep funds in bisq wallet

- withdrawfunds -- close trade, withdraw funds to external btc wallet

A getKey accessor was added to CoreWalletsService (needed by withdrawfunds impl).
2020-10-26 20:44:39 -03:00
ghubstan
a8decafc2f
Stub out api methods 'keepfunds', 'withdrawfunds'
This PR adds trade closing method stubs to keep funds in the
Bisq wallet or send them to an external BTC wallet.

- Add grpc protos
- Add new methods to GrpcTradesService, CoreApi
- Stub out implementations in CoreTradesService
- Add methods to CLI
2020-10-26 17:43:08 -03:00
chimp1984
8bfe9b82c8
Remove outliers when calculating BSQ rate
Add percentage for upper and lower threshold for outlier detection.
2020-10-25 18:34:22 -05:00
ghubstan
a2b292318c
Add boolean 'showcontract' argument to api's 'gettrade'
Optionally print the json contract for a given trade id.
2020-10-25 17:44:18 -03:00
chimp1984
114b79fc2b
Fix updates of list
Add missing show to error popup
2020-10-25 15:27:47 -05:00
ghubstan
2b23704b5a
Add 'gettrade' to api method CLI 2020-10-25 17:15:02 -03:00
ghubstan
31435bba51
Move semicolon up from blank line 2020-10-25 17:02:40 -03:00