Commit Graph

3070 Commits

Author SHA1 Message Date
Christoph Atteneder
4bec31583e
Update translations 2019-04-08 11:05:58 +02:00
Christoph Atteneder
f4c65c4d6e
Merge pull request #2665 from ManfredKarrer/use-crypt-hash-at-role
Use cryptographic hash from protobuffer serialized data instead of hashCode
2019-04-08 10:44:30 +02:00
Christoph Atteneder
2846b1881b
Merge pull request #2667 from ManfredKarrer/protect-against-late-blind-vote-publishing
Protect against late blind vote publishing
2019-04-08 10:43:48 +02:00
Christoph Atteneder
2f3dd40623
Merge pull request #2670 from ManfredKarrer/add-new-filter-option
Add filter for min required version for DAO
2019-04-08 10:42:09 +02:00
Manfred Karrer
ef3081e89c
Fix incorrect equality check 2019-04-07 20:49:53 -05:00
Manfred Karrer
d916101564
Fix missing argument in test 2019-04-07 20:31:53 -05:00
Manfred Karrer
38a6d58254
Add filter for min required version for DAO 2019-04-07 18:58:17 -05:00
Manfred Karrer
5d2dcb3539
Refactoring: Rename isInCorrectPhase to notInVoteRevealPhase 2019-04-07 14:21:05 -05:00
Manfred Karrer
6e9edc7b53
Merge pull request #2657 from ManfredKarrer/reduce-timeout
Reduce tx broadcast timeout
2019-04-07 09:12:46 -05:00
Manfred Karrer
eadc72c453
Check if not in voteReveal phase when receiving blindVotes
We do not accept blindVotePayloads when we are in the voteReveal phase
to protect against late publishing attacks.
2019-04-06 21:20:16 -05:00
Manfred Karrer
abebd76627
Remove republishing of blind votes at vote reveal
As we do not accept blind votes from the network during hte vote reveal
phase the republishing does not make sense.
2019-04-06 19:52:52 -05:00
Manfred Karrer
6b416ca278
Add TODO for removing the date from BlindVotePayload at mainnet launch
We don't want to break consensus and persisted data at current
dao_regtest by removing the date now. It is not used anywhere so it is
irrelevant but would break things as the hash would be different and
persisted data would not be readable anymore. So we delay that change
to the mainnet launch.
2019-04-06 19:46:58 -05:00
Manfred Karrer
419da79232
Republish only outside of voteReveal phase 2019-04-06 19:36:41 -05:00
Manfred Karrer
1df485a4fa
Remove DateTolerantPayload interface
The date check would not add real protection as the attacker could just
use a new date and we do not cross check the date with the tx date.
We could do that but it would add complexity and we have another
strategy which does not require that.
2019-04-06 19:29:31 -05:00
Manfred Karrer
2b15bd20af
Use cryptographic hash from protobuffer serialized data instead of hashcode
Fixes https://github.com/bisq-network/bisq/issues/2662
2019-04-06 19:16:19 -05:00
Manfred Karrer
5cfa2c77ac
Refactor: Rename method and parameter 2019-04-05 20:16:12 -05:00
Manfred Karrer
939c01f0fb
Reduce tx broadcast timeout
Currently there is a bug in BitcoinJ causing the timeout at all BSQ
transactions.
It is because BitcoinJ does not handle confidence object correctly in
case as tx got altered after the
Wallet.complete() method is called which is the case for all BSQ txs.
We will work on a fix for that but that
will take more time. In the meantime we reduce the timeout to 5
seconds to avoid that the trade protocol runs
into a timeout when using BSQ for trade fee.
2019-04-05 15:07:45 -05:00
Christoph Atteneder
400fbbd080
Merge pull request #2655 from ripcurlx/improve-tx-display-for-btc-withdrawal-from-bsq-wallet
Improve tx display for BTC withdrawal from BSQ wallet
2019-04-05 17:52:34 +02:00
Steve Jain
eda85bf2e9
Reword text in proposal fee pop-up 2019-04-05 11:10:00 -04:00
Christoph Atteneder
79376f3faf
Prevent user from creating transactions that will burn money (mining fees > amount to transfer) 2019-04-05 16:28:55 +02:00
Christoph Atteneder
3275dfed10
Improve transaction display for BTC withrawals from BSQ wallet 2019-04-05 16:28:08 +02:00
Manfred Karrer
32264070b7
Merge pull request #2643 from devinbileck/update-insufficient-funds-warning-for-proposal
Update insufficient BTC warning for issuance proposals
2019-04-04 18:28:37 -05:00
Manfred Karrer
9a6a03f1e5
Merge pull request #2646 from oscarguindzberg/regtest-fix
Bugfix for bitcoinRegtestHost=none mode
2019-04-04 18:27:30 -05:00
Oscar Guindzberg
4cb5b9d37e Fix typo 2019-04-04 19:00:12 -03:00
Oscar Guindzberg
cc73c5e37b Bugfix for bitcoinRegtestHost=none mode 2019-04-04 18:58:09 -03:00
Devin Bileck
837e79248f
Update insufficient BTC warning for issuance proposals
When attempting to submit a compensation request or reimbursement
request with insufficient BTC, the warning message only indicated that
BTC is required for mining fees. It did not indicate that BTC is also
required for the BSQ issuance.

So another display string was added and displayed when submitting an
issuance proposal with insufficient BTC funds available.
2019-04-04 12:59:30 -07:00
Manfred Karrer
e0e1472fac
Merge pull request #2635 from ripcurlx/fix-wrong-crypto-name-in-removed-cryptos
Change wrong name for Siacoin in removed crypto list
2019-04-04 10:14:26 -05:00
Christoph Atteneder
b30f166e92
Add information of Satoshis needed for coloring 2019-04-04 13:19:30 +02:00
Christoph Atteneder
383043e932
Change wrong crypto name for Siacoin in removed crypto list 2019-04-04 11:15:36 +02:00
Devin Bileck
2c001ad099
Fix incorrect required BSQ amount in warning text
When submitting a proposal with insufficient BSQ balance, the warning
message showed an incorrect required BSQ amount. The amount needed to be
divided by 100 (1 BSQ = 100 satoshis).
2019-04-03 15:17:04 -07:00
Manfred Karrer
3b16d508f4
Change log level 2019-04-03 12:22:59 -05:00
Manfred Karrer
8d22d7b926
Improve error message
See https://github.com/bisq-network/bisq/issues/2620
https://github.com/bisq-network/bisq/pull/2614#discussion_r271290565
2019-04-02 19:25:34 -05:00
Christoph Atteneder
4bbbb63c68
Merge pull request #2616 from ManfredKarrer/fix-percentage-rounding-bug
Fix wrong precision value
2019-04-02 16:51:36 +02:00
Manfred Karrer
339198bb45
Fix wrong precision value
Fixes https://github.com/bisq-network/bisq/issues/2615
2019-04-02 09:42:39 -05:00
Christoph Atteneder
8b2396e7e2
Use pt translation instead of incomplete pt_BR one 2019-04-02 10:12:45 +02:00
Christoph Atteneder
9d4c60b1e0
Update translations 2019-04-02 09:51:20 +02:00
Manfred Karrer
54f1a9ff5f
Only require change output for issuance proposals 2019-04-01 21:39:37 -05:00
Manfred Karrer
69a2a04546
Add check for mandatory BSQ output for compensation tx
Fixes https://github.com/bisq-network/bisq/issues/2613

If the user has the exact fee in his wallet no BSQ change output would
be created but that violates our requirement for compensation or
reimbursement txs.
Beside that the error message for dust outputs was not clear.
2019-04-01 21:33:11 -05:00
Manfred Karrer
6387cfa5bf
Refactoring: rename local variable 2019-04-01 21:23:00 -05:00
Manfred Karrer
eaeef7ab2d
Improve error message
See: https://github.com/bisq-network/bisq/issues/2613
2019-04-01 20:08:03 -05:00
Manfred Karrer
a3caa56709
Remove https for betanet and testnet explorers
- as the redirect does not work correctly with https
2019-04-01 17:53:49 -05:00
Manfred Karrer
70a3b30d49
Remove https for betanet and testnet explorers
- as the redirect does not work correctly with https
2019-04-01 16:48:38 -05:00
Manfred Karrer
d97de92dcd
Remove 2 dao testnet seeds
- I plan to shut them down soon after launch. I will leave 2 still
running for a few days after that...
2019-04-01 13:50:44 -05:00
Manfred Karrer
b0a2626743
Rename Bitcoin DAO Testnet to Bitcoin DAO Regtest 2019-04-01 13:44:57 -05:00
Christoph Atteneder
2942425d4c
Make create offer label cases easier to translate 2019-04-01 11:51:47 +02:00
Manfred Karrer
e9e4b49014
Add number of irregular txs to UI 2019-03-31 17:41:59 -05:00
Manfred Karrer
4d56ce9a10
Apply ExtraDataMapValidator for all extraDataMap fields 2019-03-31 17:35:14 -05:00
Manfred Karrer
dad4b04093
Update comment 2019-03-31 17:31:53 -05:00
Manfred Karrer
30a710f179
Cleanup 2019-03-31 16:30:35 -05:00
Manfred Karrer
e74ce128b3
Improve comments, cleanup 2019-03-31 16:28:34 -05:00