mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-03-02 18:34:57 +01:00
Code Issues Projects Releases Packages Wiki Activity
18171 commits 3 branches 150 tags 4.1 GiB
Commit graph

7340 commits

Author SHA1 Message Date
jmacxx
24ae5f6220
Make sure the actual wallet transaction is returned. 
There was an issue with the transaction having a non-initialized
updateTime and/or blockTime because the wallet transaction was
not returned.
 2022-11-21 09:39:21 -06:00
HenrikJannsen
671ab1f373
Cleanup 
Improve toString methods

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:55:04 -05:00
HenrikJannsen
0f14ea29c9
Improve handling of case when Bitcoin Core sync is not completed. 
We repeat with a quadratically increasing delay 5 times, then we give up.
In the previous code we repeated forever which could be risky in case that
code branch is called unexpectedly.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:51:15 -05:00
HenrikJannsen
811ae52f27
Fix bug with using getPreviousBlockHash instead of getHash 
It had no consequences as it was only used for info logging

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:46:38 -05:00
HenrikJannsen
1e72e265f7
Cleanup comments 
Improve toString methods
Rename var for more clear meaning

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:44:58 -05:00
HenrikJannsen
de654c15b3
Improve handling of ConnectionState.expectedInitialDataResponses 
Rename to expectedInitialDataResponses as we compare with numInitialDataResponses.
Add comment to make it more clear how its used.
Let the LiteNode increment only if getBlocks get called (e.g. blocks are missing).

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-17 19:41:32 -05:00
Bisq GitHub Admin
60522218a7
Merge pull request #6412 from bisq-network/release/v1.9.6 
Merge release branch
 2022-11-15 21:03:40 +01:00
sqrrm
3dd9b0e575
Merge pull request #6403 from HenrikJannsen/disable-deactivation-of-dao 
Require the DAO is enabled for traders
 2022-11-04 11:44:26 +01:00
HenrikJannsen
81be778df3
Remove deposit tx output size check. 
It is allowed that there are change outputs, for instance if taker
does not take full trade amount, there is a change output for maker.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 14:14:32 -05:00
HenrikJannsen
e653262751
Fix param in test 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 12:26:59 -05:00
HenrikJannsen
cba35b6342
Remove deposit tx output size check. 
It is allowed that there are change outputs, for instance if taker
does not take full trade amount, there is a change output for maker.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 12:21:47 -05:00
HenrikJannsen
8d8cdc14b4
Cleanup 2022-11-03 12:12:02 -05:00
HenrikJannsen
b5df4afd40
Remove DevEnv.isDaoActivated method as not used anymore 
Remove daoActivatedToggleButton from PreferencesView and NewsView

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 11:16:10 -05:00
HenrikJannsen
e8a9132d30
Remove if blocks with !DevEnv.isDaoActivated() and combined && as isDaoActivated is always true the whole statement is always false 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 11:00:23 -05:00
HenrikJannsen
80e7dc7203
Remove tertiary operator DevEnv.isDaoActivated() ? as isDaoActivated is always true 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 11:00:22 -05:00
HenrikJannsen
72d97b8d97
Remove if (DevEnv.isDaoActivated()) checks as isDaoActivated is always true 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 10:51:01 -05:00
HenrikJannsen
008cfaac57
Remove daoActivated options 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-03 10:46:26 -05:00
HenrikJannsen
14312f08af
Add validateDisputeData, validateTradeAndDispute and validateSenderNodeAddress methods 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:59:12 -05:00
HenrikJannsen
04e501d450
We had not updated the contract hash after setting the signature. 
We verify later the contract hash in disputes and that would fail otherwise.
 2022-11-02 23:56:25 -05:00
HenrikJannsen
c49b811da3
Add verification of chain of transactions at DisputeSummaryWindow 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:24:05 -05:00
HenrikJannsen
60cd8b1e16
Add requestBlockchainTransactions and verifyTradeTxChain methods to RefundManager 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:15:41 -05:00
HenrikJannsen
0553a0f9d4
Add cachedDepositTx field to Dispute 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:15:11 -05:00
HenrikJannsen
0388c7c88a
Add block explorer tx as hex request using completeable future api 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 23:03:55 -05:00
HenrikJannsen
7f5675f054
Remove if case for old clients 
Remove null check for dispute

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:51:39 -05:00
HenrikJannsen
97648c51f3
Rename to make use case more clear 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:49:57 -05:00
HenrikJannsen
0bf44f061d
Remove addressAsString null check. That was when the donationAddress got added to support not updated nodes. Now there are none of such nodes. 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:48:55 -05:00
HenrikJannsen
710dba9f36
Remove validateDonationAddress method without dispute param 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:47:39 -05:00
HenrikJannsen
5daaa60779
Refactor validateDonationAddress 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:44:58 -05:00
HenrikJannsen
3007652f4a
Remove dispute field from TradeDataValidation.ValidationException 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:41:46 -05:00
HenrikJannsen
cfb3780e6b
Move null check for address to validateDonationAddress method 
Remove dispute as unused param
Remove redundant methods

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:39:56 -05:00
HenrikJannsen
e8c6b0ae14
Remove daoFacade as unused parameter 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:32:28 -05:00
HenrikJannsen
cfc67dcc9c
Move validateDonationAddress to DisputeValidation 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:29:59 -05:00
HenrikJannsen
d86071db4a
Remove validateDonationAddress call inside validateDelayedPayoutTx. 
Add call to validateDonationAddress at client calling validateDelayedPayoutTx

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:28:41 -05:00
HenrikJannsen
2484fa4371
Part of a multistep refactoring to separate dispute related validation out of TradeDataValidation 
Refactor donationAddress validation out to new method
Rename addressAsString to delayedPayoutTxOutputAddressAsString
Recreate delayedPayoutTxOutputAddress at new validateDonationAddress method from relevant data

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:25:11 -05:00
HenrikJannsen
e49e634956
Move testIfAnyDisputeTriedReplay and related methods to DisputeValidation 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:14:55 -05:00
HenrikJannsen
37457ed132
Move validateDonationAddress to DisputeValidation 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:12:55 -05:00
HenrikJannsen
12686deff6
Move validateNodeAddress to DisputeValidation 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 22:11:23 -05:00
HenrikJannsen
aa22bd366a
Add DisputeValidation class for validation methods and exceptions of the dispute domain. 
Move AddressException, NodeAddressException and DisputeReplayException to DisputeValidation.
Use DisputeValidation.ValidationException as type for DisputeManager.validationExceptions.
Remove Nullable annotation for dispute field in those exceptions.
Remove null checks when those DisputeValidation.ValidationException are used.
 2022-11-02 22:09:30 -05:00
HenrikJannsen
43fb0cc635
Reformat code and reorg imports 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
 2022-11-02 21:22:35 -05:00
jmacxx
797bfe5cd5
Store the build's commit hash in Jarfile manifest. 2022-10-29 22:12:31 -05:00
Christoph Atteneder
80246e5d66
Update data stores for v1.9.6 2022-10-20 12:19:30 +02:00
Christoph Atteneder
6831f72a03
Update translations for v1.9.6 2022-10-13 09:53:23 +02:00
jmacxx
b35e316cdc
Warn at shutdown if Dispute message is pending. 2022-10-11 17:54:07 -05:00
jmacxx
b5dc6a4e45
Misc burn chart series CSS color settings and tooltip description. 2022-10-05 07:11:40 -05:00
jmacxx
8b92b2cdf5
UI Changes for BSQ Supply screen. 
Adds ability to track Misc Burnt amounts (incl. voting, asset listing etc)
Corrects the descriptions for Total BSQ and Change in supply.
 2022-10-05 07:11:36 -05:00
Christoph Atteneder
75e030f541
Merge pull request #6362 from jmacxx/dispute_min_payout 
Set the minimum payout at mediation to be 2.5% of trade amount
 2022-10-04 09:12:38 +02:00
Stephan Oeste
46139cf6b0
Remove c4talys7 seednodes and readd wiz seednodes 2022-09-28 15:16:25 +02:00
Android-X13
ee2db16451
Fix issue with offers getting disabled for no apparent reason 2022-09-20 20:55:19 +03:00
jmacxx
11e4469b0e
Set the minimum payout at mediation to be 2.5% of trade amount. 
If 2.5% is less than 0.0005 BTC, then fall back to 0.0005 BTC.
 2022-09-18 21:51:24 -05:00
ghubstan
a33a6e936b
Fix BSQ buyer's displayed trade fee for gettrade(s) methods 
API clients looking at their BSQ swap trades -- BSQ buyers
specifically -- were seeing a 0.00 BSQ trade fee, due to an
incorrect assumption BSQ sellers paid the entire BSQ trade
fee for both sides.  BSQ Swap execution via API has been
working just like the GUI (same code-base), but the reported
trade fee for the BSQ buy side was wrong.
This change shows the correct BSQ trade fee.

Partially addresses issue https://github.com/bisq-network/bisq/issues/6355
 2022-09-11 16:06:59 -03:00