jmacxx
6f8bb00704
Apply code review suggestions.
2022-12-08 08:16:11 -06:00
HenrikJannsen
f4775f89b0
Add SeedNodeReportingService
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-07 13:23:28 -05:00
HenrikJannsen
3a4ed1fc01
Add seedNodeReportingServerUrl option
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-07 11:51:49 -05:00
HenrikJannsen
2c84f07ada
Add value objects and protobuf definitions
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-07 11:51:08 -05:00
HenrikJannsen
3caf2c2b64
Change visibility (will be used from monitor project).
...
Remove log, change log level.
Add getters
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-07 11:50:24 -05:00
HenrikJannsen
a925017e4b
Rename readCommitHash to findCommitHash, make it static and return optional.
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-12-07 11:03:08 -05:00
jmacxx
09a7a09ec3
Fix FileTransferSession tests.
2022-12-06 20:33:48 -06:00
jmacxx
bddbe6b7ae
Feature to zip logfiles to home directory.
2022-12-05 09:14:12 -06:00
Christoph Atteneder
5dc006ec9b
Merge pull request #6435 from jmacxx/add_shutdown_guard
...
Prompt to confirm before shutting down.
2022-12-05 10:45:02 +01:00
jmacxx
75f224c67c
Check filterWarningHandler is set before use.
2022-12-04 21:10:06 -06:00
jmacxx
0e3314ce14
Prompt to confirm before shutting down. Has dont show again option.
2022-12-02 15:35:27 -06:00
Christoph Atteneder
4069e60f8c
Update app signatures
2022-12-01 12:21:46 +01:00
Christoph Atteneder
16166c42a7
Merge pull request #6429 from HenrikJannsen/handle-rpc-errors-gracefully
...
Handle HttpExceptions at block handler
2022-12-01 09:50:54 +01:00
jmacxx
7ec86c3dc3
User defined trade limit.
...
Some commits were missed from the first implementation in #6431 .
The user limit is applied to offer entry via AccountAgeWitnessService.
Offers are filtered according to limits in OfferFilterService.
If limit changed, the cache in OfferFilterServices must be cleared.
2022-11-29 22:41:34 -06:00
jmacxx
1df3046371
Validate BSQ fee payment using DAO tx info.
...
Previously the BSQ fee payment was determined by parsing a raw tx
without relying on the DAO. Unfortunately this turned out to be
problematic, so with this change the BSQ fee paid is obtained from
the DAO tx, as originally preferred by chimp1984.
Unconfirmed transactions will not be able to have their BSQ fees
checked so early requests for validation will skip the fee check.
This is not a problem since maker fee validation is done by the
taker and in the majority of cases will be already confirmed; taker
fee validation is done after the first confirm at trade step 2.
2022-11-29 18:16:21 -06:00
jmacxx
c796531658
Increase trading limits as an opt-in setting (GH proposal 398)
...
More restrictive limits will still apply based on payment method.
It is intended to avoid that a new users who do not fully understand
the process of a Bisq trade to cause an arbitration case with high
amounts and therefore higher risks and costs for the DAO.
2022-11-29 09:32:38 -06:00
Alejandro GarcÃa
8d2f0a5d12
Merge pull request #6383 from Android-X13/option_for_qr_codes
...
Include option for non-URI addresses in QR codes
2022-11-29 14:42:05 +02:00
Alejandro GarcÃa
e054083c1f
Merge pull request #6376 from jmacxx/fix_issue_6367
...
Fix loss of mailbox messages during SPV resync
2022-11-29 14:41:27 +02:00
HenrikJannsen
0b07c104a7
Use recovery for all RPC HttpExceptions exceptions in generic error handler.
...
It seems that a reorgs or if a new block arrives quickly after another, that bitcoind is not ready
for a request and throws an RPC error, also the blockhandler throws that if the new block came too fast.
We try to request again with increasing delays up to 1 min. If after 10 attempts its still failing we
do a reorg and start parting again.
2022-11-27 17:42:53 -05:00
HenrikJannsen
a0900a0f1b
Handle HttpExceptions at block handler
2022-11-27 17:41:21 -05:00
sqrrm
b10881ff7f
Merge pull request #6418 from HenrikJannsen/improve-dao-node-domain
...
Improve dao node domain
2022-11-26 16:19:52 +01:00
jmacxx
8a94642e1a
Do not erase mailbox messages during SPV resync.
2022-11-25 21:13:09 -06:00
Alejandro GarcÃa
92e4c62287
Merge pull request #6422 from jmacxx/fix_trade_timer_issue
...
Fix: incorrect wallet tx handling
2022-11-26 03:02:05 +02:00
Alejandro GarcÃa
80a927afb9
Merge pull request #6404 from HenrikJannsen/improve-dispute-validation
...
Improve dispute validation
2022-11-25 17:37:44 +02:00
Alejandro GarcÃa
a6293a64cb
Merge pull request #6396 from jmacxx/show_commit_hash
...
Store the build's commit hash in Jarfile manifest
2022-11-25 17:36:34 +02:00
Android-X13
d77b76034d
Include option for non-URI addresses in QR codes
2022-11-22 23:11:45 +02:00
jmacxx
24ae5f6220
Make sure the actual wallet transaction is returned.
...
There was an issue with the transaction having a non-initialized
updateTime and/or blockTime because the wallet transaction was
not returned.
2022-11-21 09:39:21 -06:00
HenrikJannsen
671ab1f373
Cleanup
...
Improve toString methods
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-17 19:55:04 -05:00
HenrikJannsen
0f14ea29c9
Improve handling of case when Bitcoin Core sync is not completed.
...
We repeat with a quadratically increasing delay 5 times, then we give up.
In the previous code we repeated forever which could be risky in case that
code branch is called unexpectedly.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-17 19:51:15 -05:00
HenrikJannsen
811ae52f27
Fix bug with using getPreviousBlockHash instead of getHash
...
It had no consequences as it was only used for info logging
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-17 19:46:38 -05:00
HenrikJannsen
1e72e265f7
Cleanup comments
...
Improve toString methods
Rename var for more clear meaning
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-17 19:44:58 -05:00
HenrikJannsen
de654c15b3
Improve handling of ConnectionState.expectedInitialDataResponses
...
Rename to expectedInitialDataResponses as we compare with numInitialDataResponses.
Add comment to make it more clear how its used.
Let the LiteNode increment only if getBlocks get called (e.g. blocks are missing).
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-17 19:41:32 -05:00
Bisq GitHub Admin
60522218a7
Merge pull request #6412 from bisq-network/release/v1.9.6
...
Merge release branch
2022-11-15 21:03:40 +01:00
sqrrm
3dd9b0e575
Merge pull request #6403 from HenrikJannsen/disable-deactivation-of-dao
...
Require the DAO is enabled for traders
2022-11-04 11:44:26 +01:00
HenrikJannsen
81be778df3
Remove deposit tx output size check.
...
It is allowed that there are change outputs, for instance if taker
does not take full trade amount, there is a change output for maker.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 14:14:32 -05:00
HenrikJannsen
e653262751
Fix param in test
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 12:26:59 -05:00
HenrikJannsen
cba35b6342
Remove deposit tx output size check.
...
It is allowed that there are change outputs, for instance if taker
does not take full trade amount, there is a change output for maker.
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 12:21:47 -05:00
HenrikJannsen
8d8cdc14b4
Cleanup
2022-11-03 12:12:02 -05:00
HenrikJannsen
b5df4afd40
Remove DevEnv.isDaoActivated method as not used anymore
...
Remove daoActivatedToggleButton from PreferencesView and NewsView
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 11:16:10 -05:00
HenrikJannsen
e8a9132d30
Remove if blocks with !DevEnv.isDaoActivated() and combined && as isDaoActivated is always true the whole statement is always false
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 11:00:23 -05:00
HenrikJannsen
80e7dc7203
Remove tertiary operator DevEnv.isDaoActivated() ? as isDaoActivated is always true
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 11:00:22 -05:00
HenrikJannsen
72d97b8d97
Remove if (DevEnv.isDaoActivated()) checks as isDaoActivated is always true
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 10:51:01 -05:00
HenrikJannsen
008cfaac57
Remove daoActivated options
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-03 10:46:26 -05:00
HenrikJannsen
14312f08af
Add validateDisputeData, validateTradeAndDispute and validateSenderNodeAddress methods
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 23:59:12 -05:00
HenrikJannsen
04e501d450
We had not updated the contract hash after setting the signature.
...
We verify later the contract hash in disputes and that would fail otherwise.
2022-11-02 23:56:25 -05:00
HenrikJannsen
c49b811da3
Add verification of chain of transactions at DisputeSummaryWindow
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 23:24:05 -05:00
HenrikJannsen
60cd8b1e16
Add requestBlockchainTransactions and verifyTradeTxChain methods to RefundManager
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 23:15:41 -05:00
HenrikJannsen
0553a0f9d4
Add cachedDepositTx field to Dispute
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 23:15:11 -05:00
HenrikJannsen
0388c7c88a
Add block explorer tx as hex request using completeable future api
...
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 23:03:55 -05:00
HenrikJannsen
7f5675f054
Remove if case for old clients
...
Remove null check for dispute
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2022-11-02 22:51:39 -05:00
