mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-02-28 17:15:14 +01:00
Code Issues Projects Releases Packages Wiki Activity
12830 commits 3 branches 150 tags 4.1 GiB
Commit graph

4819 commits

Author SHA1 Message Date
Christoph Atteneder
3d7273883c
Merge pull request #4733 from jmacxx/edit_explorer_details 
Allow user-defined block explorers
 2020-11-02 19:23:48 +01:00
sqrrm
f03be6ad3d
Merge pull request #4628 from chimp1984/improve-read-file-handling 
Use a thread in PersistenceManager for reading persisted files instead of using threads in client code
 2020-11-02 17:36:21 +01:00
sqrrm
84ac65b163
Merge pull request #4731 from ghubstan/19-sqrrm-pr-changes 
Resolve issues found in reviewed PRs 4699, 4703, 4711 [, ...]
 2020-11-02 15:32:07 +01:00
jmacxx
8a9d05eba0
Allow user-defined block explorers 
In Settings/General Preferences the Bitcoin Explorer and Bisq Explorer may
now be user defined in addition to the hard coded block explorer choices.

This implementation takes advantage of the existing Protobuf implementation
that stores a BlockExplorer Name/UrlTx/UrlAddress for BTC and for BSQ.

A new popup dialog is implemented which allows editing of the explorer
details (name, txUrl, and addressUrl).  Any of the system-defined
explorer details may be selected into the edit fields thus allowing
them to be used as templates, customized or an entirely new explorer to
be used.

If the user switches choice from a customized back to a pre-defined
explorer then the customized settings are gone; this is because the
Protobuf storage only allows saving one selection.

Fixes #4371
Closes #4634
 2020-11-02 07:53:06 -06:00
sqrrm
85237cb870
Merge pull request #4714 from ghubstan/13-canceloffer-impl 
Implement 'canceloffer' api method
 2020-11-02 12:59:56 +01:00
sqrrm
9e1466417f
Merge pull request #4713 from ghubstan/12-stub-canceloffer 
Stub out 'canceloffer offer-id' api method
 2020-11-02 12:59:03 +01:00
Christoph Atteneder
9ab65459df
Merge pull request #4736 from jmacxx/add_autoconf_service_filter 
Admin filter for auto-confirmation service addresses
 2020-11-02 10:47:22 +01:00
jmacxx
15b8e72059
Admin filter for auto-confirmation service addresses 
A service address can be filtered out using the admin key.  This would
be useful if a federated server failed, it could be filtered out so
that the auto-confirmation operates with the remaining services.  If
all federated service addresses were filtered out the user would have to
either confirm manually or use their own explorer service.
 2020-11-01 08:20:33 -06:00
sqrrm
89620a02da
Merge pull request #4706 from chimp1984/remove-outliers-at-bsq-rate 
Remove outliers when calculating BSQ rate
 2020-10-31 23:07:40 +01:00
ghubstan
fcdfc687e4
Verify closedTradableManager.getTradableById return value is a Trade instance 
This change requested at https://github.com/bisq-network/bisq/pull/4711#discussion_r515520278
 2020-10-31 15:44:14 -03:00
sqrrm
f3c62d35c2
Merge pull request #4711 from ghubstan/10-closetrade-impls 
Implement api methods 'keepfunds', 'withdrawfunds'
 2020-10-31 18:41:05 +01:00
ghubstan
c27d5a6da8
Use Bisq's timer in API's 'unlockwallet timeout(s)' 
This change was requested in
961703ecea

This replaces and closes PR https://github.com/bisq-network/bisq/pull/4558
 2020-10-31 13:32:14 -03:00
sqrrm
605f4b3015
Merge pull request #4726 from chimp1984/add-transferwise-payment-method 
Add transferwise account
 2020-10-31 13:20:41 +01:00
sqrrm
1e1d1ffb70
Merge pull request #4732 from chimp1984/add-more-logs-at-trade-data-validation-exception 
Avoid null pointers at TradeDataValidation
 2020-10-31 12:35:26 +01:00
chimp1984
f817018410
Add null checks, remove verbose logs from IllegalArgumentException branch 2020-10-30 20:01:01 -05:00
chimp1984
7fe5b80d39
Add more logs 2020-10-30 19:20:20 -05:00
ghubstan
f764e9feb0
Simplify TradeUtil#getPaymentMethodNameWithCountryCode 
These changes were requested in review of PR
https://github.com/bisq-network/bisq/pull/4699
 2020-10-30 11:15:39 -03:00
sqrrm
c4e2021e37
Merge pull request #4709 from ghubstan/9-closetrade-protos 
Stub out api methods 'keepfunds', 'withdrawfunds'
 2020-10-30 14:05:16 +01:00
sqrrm
3c56268149
Merge pull request #4701 from ghubstan/5-refactor-trade-utils 
Add getRole(tradeId) to core api
 2020-10-30 13:43:15 +01:00
sqrrm
ed14442992
Merge pull request #4699 from ghubstan/3-refactor-trade-utils 
Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil
 2020-10-30 11:11:15 +01:00
sqrrm
258d44ebb7
Merge pull request #4697 from ghubstan/2-refactor-trade-utils 
Replace TradeUtils with singleton TradeUtil
 2020-10-29 22:36:54 +01:00
sqrrm
3356c8f632
Merge pull request #4696 from ghubstan/1-add-grpc-trade-proto-fields 
Add fields to grpc TradeInfo proto & wrapper
 2020-10-29 22:31:26 +01:00
sqrrm
407fa3f28c
Merge pull request #4692 from ghubstan/blocking-fee-request 
Block on tx-fee-request in core TakeOfferModel init
 2020-10-29 22:18:51 +01:00
chimp1984
db3ac48758
Reformat to force codacy update 2020-10-29 13:04:51 -05:00
chimp1984
5639a5e474
Add TRANSFERWISE to TradeStatistics3.PaymentMethodMapper 2020-10-28 23:30:56 -05:00
chimp1984
1f45d492ef
Remove todos 2020-10-28 21:52:38 -05:00
chimp1984
ebce18c338
Add transferwise account 2020-10-28 21:35:47 -05:00
sqrrm
9a871373c2
Merge pull request #4681 from oscarguindzberg/removeAddressClassFromBsqClasses 
Use LegacyAddress instead of Address for BSQ
 2020-10-27 23:59:44 +01:00
sqrrm
917ab4ee32
Merge pull request #4689 from chimp1984/revert-dao-data-json-export-changes 
Revert changes for json export of dao data
 2020-10-27 23:58:35 +01:00
ghubstan
b38507c6e6
Implement api method 'canceloffer' 2020-10-27 15:31:57 -03:00
ghubstan
027a7d5cd3
Stub out canceloffer api method 
The implementation will be added to CoreOffersService in the next PR.
 2020-10-27 14:54:50 -03:00
Oscar Guindzberg
8370bc98d5
Use LegacyAddress instead of Address for BSQ 2020-10-27 13:56:20 -03:00
ghubstan
a3631a022f
Implement api methods 'keepfunds', 'withdrawfunds' 
The CoreTradesService was refactored to work for newly added api methods:

- keepfunds -- close trade, keep funds in bisq wallet

- withdrawfunds -- close trade, withdraw funds to external btc wallet

A getKey accessor was added to CoreWalletsService (needed by withdrawfunds impl).
 2020-10-26 20:44:39 -03:00
ghubstan
a8decafc2f
Stub out api methods 'keepfunds', 'withdrawfunds' 
This PR adds trade closing method stubs to keep funds in the
Bisq wallet or send them to an external BTC wallet.

- Add grpc protos
- Add new methods to GrpcTradesService, CoreApi
- Stub out implementations in CoreTradesService
- Add methods to CLI
 2020-10-26 17:43:08 -03:00
chimp1984
8bfe9b82c8
Remove outliers when calculating BSQ rate 
Add percentage for upper and lower threshold for outlier detection.
 2020-10-25 18:34:22 -05:00
ghubstan
161dbade0d
Add getRole(tradeId) to core api 
API users will need to see their role as maker/taker when looking at trade details.

- Add getRole(trade) to TradeUtil.
- Add getTradeRole(tradeId) to CoreApi, CoreTradesService.
- Add role field to TradeInfo proto and its wrapper class.
 2020-10-25 16:22:20 -03:00
ghubstan
bbd7a31c88
Remove unused import 2020-10-25 11:38:03 -03:00
ghubstan
95bcb1ef9c
Refactor PendingTradesDataModel methods -> TradeUtil 
Scope of this refactoring is small;  more can be done, but the short
term goal is to share trade util logic with core api.

- Removed unused method getCurrencyCode()
- Made minor style changes
- Removed duplicated code block
 2020-10-25 11:27:30 -03:00
ghubstan
24ba9215cd
Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil 2020-10-25 10:41:19 -03:00
ghubstan
ccd3c99f2e
Fix comment typos 2020-10-24 17:45:01 -03:00
ghubstan
296e4f98cb
Replace static TradeUtil with singleton TradeUtil 
The API is going to need some desktop trade utilities, which should be
shared between :desktop and :core.api.
 2020-10-24 17:26:10 -03:00
ghubstan
63cf436990
Add fields to grpc TradeInfo proto & wrapper 2020-10-24 16:27:03 -03:00
ghubstan
ab20225cd2
Add compiler warning suppression, remove comment 2020-10-24 16:25:20 -03:00
Christoph Atteneder
55c663ad47
Merge pull request #4676 from jmacxx/show_tx_fee 
Show current tx fee rate on main screen
 2020-10-24 11:40:34 +02:00
sqrrm
93a3188659
Merge pull request #4680 from chimp1984/add-InventoryMonitor-module 
Add inventory monitor module
 2020-10-23 19:26:53 +02:00
chimp1984
f7b44f1646
Improve logs 2020-10-23 11:02:47 -05:00
ghubstan
cb65de6d2e
Block on tx-fee-request in core TakeOfferModel init 
Added license comment too.
 2020-10-23 12:47:06 -03:00
sqrrm
9e76f5fdc3
Merge pull request #4606 from ghubstan/remove-dup-statuscheck 
Delete redundant core.api.StatusCheck
 2020-10-23 15:42:34 +02:00
chimp1984
330f14ff1f
Revert changes for json export of dao data 
Backend is not ready yet and the changes are bigger than initially expected.

Was changed as part of 0d469066ce

See discussion at https://github.com/bisq-network/bisq/pull/4670
 2020-10-23 01:39:49 -05:00
chimp1984
f1fdf3c0a5
Improve deviation model 2020-10-23 01:17:34 -05:00