Manfred Karrer
3c08a2739f
Merge pull request #2178 from tau3/feature/refactor-ballot-service
...
Unit test for BallotListService
2019-01-06 04:06:03 +01:00
Manfred Karrer
f832633593
Merge branch 'master' into dao-fix-performance-issue-at-parsing
2019-01-05 16:23:17 +01:00
Manfred Karrer
4d8a348efb
Merge branch 'master' into dao-fix-vote-reveal-tx-publishing
2019-01-05 16:12:36 +01:00
Manfred Karrer
f12ff5ce92
Adjust % value for offer price tolerance window
...
- There have been some reports that the 0,5% value is too narrow so we
increase it to 1%.
2019-01-04 13:50:38 +01:00
Manfred Karrer
0a5417b861
Add duration for batch parsing to logs
2019-01-04 00:08:00 +01:00
Manfred Karrer
930d7a79e3
Call onParseBlockComplete listeners only after onParseBlockChainComplete
...
To avoid performance issues we omit the listener calls at
onParseBlockComplete as long we are in the batch processing of blocks.
Without that optimization it took about 50 sec. for 4000 blocks, with it
we could reduce it to 4 seconds.
2019-01-04 00:07:35 +01:00
Manfred Karrer
c334018845
Change log level
2019-01-04 00:01:21 +01:00
Manfred Karrer
9ab941ff4a
Move logs and comments to 'if' clause
2019-01-03 23:33:30 +01:00
Manfred Karrer
2f9125a3db
Improve logs
2019-01-03 22:55:05 +01:00
Manfred Karrer
d23bb2cd18
Improve logs
2019-01-03 22:34:58 +01:00
Manfred Karrer
c87383a017
Refactorings
2019-01-03 22:34:47 +01:00
Manfred Karrer
c1792a3e7f
Ignore items if isBlindVoteInCorrectPhaseAndCycle is false.
...
If we get a voteReveal tx which was published too late we ignore it.
- Refactorings
- Improve logs
2019-01-03 22:34:13 +01:00
Manfred Karrer
0a9f4fc236
Remove phase and cycle check for vote reveal txs.
...
We do not check phase or cycle as a late voteReveal tx is considered
a valid BSQ tx. The vote result though will ignore such votes.
Add more log info.
2019-01-03 22:32:27 +01:00
Manfred Karrer
c137e7ec09
Refactor maybeRevealVotes method.
...
Add exception handling to revealVote
2019-01-03 22:31:14 +01:00
Manfred Karrer
ef37dc3256
Set chainTipHeight before parsing.
2019-01-03 22:30:25 +01:00
Manfred Karrer
4fd8490df1
Handle late vote reveal txs
...
If the phase and cycle for the vote reveal tx was missed we still
publish it but it is considered invalid. We do not throw an exception
but filter such txs away from the vote result evaluation.
We cannot use the strategy to unlock the BSQ from the vote tx in such a
case because the blind vote tx is already in the past and is not parsed
again (snapshot).
Alternatively we could have used a different tx type for the unlock
purpose but we prefer to keep such an exceptional case simple.
2019-01-03 16:44:39 +01:00
Manfred Karrer
00d0aa51e3
Use chain tip height for vote reveal tx publishing
...
- Use the chain tip height and not the current chain height in the
parsing to check if we are in the correct phase and cycle. Only
publish the tx if we are in the correct cycle.
2019-01-03 15:39:03 +01:00
Manfred Karrer
96581155e8
Add chainTipHeight property
...
- We want to know for the vote reveal service what is the latest block.
Currently that is not exposed in the DAO only in the BitcoinJ classes,
but we don't want to access it from there.
2019-01-03 15:37:44 +01:00
Manfred Karrer
ff22470262
Improve logging
2019-01-03 15:07:37 +01:00
Manfred Karrer
c63ecb1ec3
Improve logging
2019-01-03 14:00:39 +01:00
Manfred Karrer
d57f6ad3d2
Fix startup behaviour.
...
Call fillListFromProtectedStore and fillListFromAppendOnlyDataStore
at start. The listeners are not triggered as registered after we have
received the initial data. So we need to read the P2P network data at
the start method.
2019-01-03 14:00:19 +01:00
Manfred Karrer
abb34230a3
Change handling of addListeners and start calls
...
We add first all listeners at all services and then call the start methods.
Some services are listening on others so we need to make sure that the
listeners are set before we call start as that might trigger state change
which triggers listeners.
- Change order of ballotListService and proposalService to reflect
dependency.
2019-01-03 13:58:58 +01:00
Manfred Karrer
5c747d71d9
Use lambda
2019-01-03 10:51:41 +01:00
Manfred Karrer
a6a974ef5c
Remove final qualifier
2019-01-03 10:51:19 +01:00
Manfred Karrer
9f27fefe22
Add number of blocks in comment
2019-01-03 10:30:42 +01:00
Manfred Karrer
a7be0c4d31
Improve error logs
2019-01-03 10:16:26 +01:00
Manfred Karrer
1b17109b6b
Add more logs
2019-01-03 00:23:33 +01:00
Manfred Karrer
cbc559c7ee
Only log warning if mainnet
2019-01-02 02:02:07 +01:00
Manfred Karrer
b48984c8f5
Add comment
2019-01-02 00:07:31 +01:00
Manfred Karrer
4c3a721535
Improve logging
2019-01-02 00:05:14 +01:00
Manfred Karrer
0dadc05233
Add toString methods
2019-01-02 00:04:55 +01:00
BravoIndia
48cf173b27
Update displayStrings.properties
...
Clarifying/correcting grammar of bug report message.
2018-12-31 16:17:05 +07:00
Oscar Guindzberg
eff0db051c
Remove Networks and AbstractBitcoinNetParams since they are not used
2018-12-28 17:31:49 -03:00
Sergey
04febc22b3
implemented unit test for BallotListService#addListeners
2018-12-28 13:10:37 +04:00
Cave Spectre
e9f8a78d66
Fix typos and improve grammer
2018-12-21 22:06:11 -05:00
Oscar Guindzberg
6ab548707d
Fix getActiveKeyChain() typo
2018-12-19 17:42:33 -03:00
Manfred Karrer
2a0f12edbf
Merge pull request #2148 from ripcurlx/fix-minor-translation-typo
...
Remove unnecessary backslash
2018-12-19 17:25:27 +01:00
Christoph Atteneder
1616388912
Remove unnecessary backslash
2018-12-19 16:35:10 +01:00
Oscar Guindzberg
a164dec427
BisqRiskAnalysis: update comment
2018-12-18 12:50:25 -03:00
Oscar Guindzberg
6633e22ffd
BisqWalletFactory: Remove method already declared on superinterface
2018-12-18 12:50:07 -03:00
Oscar Guindzberg
9e21a388fa
Add missing @Override
2018-12-18 12:49:19 -03:00
Christoph Atteneder
38e5688dc6
Remove spaces upfront as long as we don't use a monospace font
2018-12-13 10:16:35 +01:00
Christoph Atteneder
54bd2d57c4
Update translations
2018-12-13 09:48:25 +01:00
Manfred Karrer
9ee3c0e39b
Add missing param for test
2018-12-12 18:56:05 +01:00
Manfred Karrer
5bf7ba46a7
Handle cycles in case of applying a empty snapshot
2018-12-12 13:35:13 +01:00
Manfred Karrer
6ad2c1e324
Merge branch 'master' into fix-reorg-issues-with-phases
2018-12-12 12:02:30 +01:00
Manfred Karrer
d2341b659a
Merge pull request #2111 from ripcurlx/ui-fixes
...
Different ui bug fixes
2018-12-11 19:19:41 +01:00
Christoph Atteneder
2da9643606
Round volume in contract views. Fixes #2042 .
2018-12-11 16:07:27 +01:00
Manfred Karrer
a54298690f
Update display string
...
- Remove info that you cannot import seeds from pre v0.5.0 wallets
2018-12-11 12:10:28 +01:00
Steve Jain
c433663808
Change customer service text
2018-12-10 18:36:06 -05:00
