Christoph Atteneder
50ab4283b2
Merge pull request #4718 from jmacxx/fix_issue_4708
...
Cleanup user interface elements in Send Funds screen
2020-10-28 10:02:16 +01:00
jmacxx
a5c62a545d
Cleanup user interface elements in Send Funds screen
...
Selects "Amount includes mining fee" by default. Fixes #4708
Unrestrict the length of "Withdraw to address" & "Withdrawal memo" fields. Fixes #4656
2020-10-27 18:06:30 -05:00
sqrrm
9a871373c2
Merge pull request #4681 from oscarguindzberg/removeAddressClassFromBsqClasses
...
Use LegacyAddress instead of Address for BSQ
2020-10-27 23:59:44 +01:00
sqrrm
917ab4ee32
Merge pull request #4689 from chimp1984/revert-dao-data-json-export-changes
...
Revert changes for json export of dao data
2020-10-27 23:58:35 +01:00
ghubstan
91a2e2ce1f
Add canceloffer test
2020-10-27 19:06:59 -03:00
sqrrm
91bc88c86c
Merge pull request #4695 from chimp1984/cleanup-monitor-module
...
Cleanup monitor module
2020-10-27 19:55:59 +01:00
ghubstan
b38507c6e6
Implement api method 'canceloffer'
2020-10-27 15:31:57 -03:00
sqrrm
6cb0130a41
Merge pull request #4694 from cd2357/update-tor-repos
...
Update netlayer references to bisq repos
2020-10-27 19:27:20 +01:00
ghubstan
0f1d4f8ac3
Fix typo
2020-10-27 15:03:36 -03:00
ghubstan
027a7d5cd3
Stub out canceloffer api method
...
The implementation will be added to CoreOffersService in the next PR.
2020-10-27 14:54:50 -03:00
Oscar Guindzberg
8370bc98d5
Use LegacyAddress instead of Address for BSQ
2020-10-27 13:56:20 -03:00
ghubstan
2746b27674
Fix apitest dummy payment acct init bug
...
This commit fixes non-trade tests broken by the last refactoring.
2020-10-27 13:47:23 -03:00
ghubstan
1e25be5bdc
Test trade closing api methods 'keepfunds' withdrawfunds'
...
Some refactoring of the api test case hierarchy is included in this commit.
2020-10-27 13:04:53 -03:00
ghubstan
b8ae566b69
Add method for printing current jupiter test name
2020-10-27 13:03:48 -03:00
ghubstan
f1db254073
Make formatSatoshis visible for testing
2020-10-27 13:01:33 -03:00
ghubstan
a3631a022f
Implement api methods 'keepfunds', 'withdrawfunds'
...
The CoreTradesService was refactored to work for newly added api methods:
- keepfunds -- close trade, keep funds in bisq wallet
- withdrawfunds -- close trade, withdraw funds to external btc wallet
A getKey accessor was added to CoreWalletsService (needed by withdrawfunds impl).
2020-10-26 20:44:39 -03:00
ghubstan
a8decafc2f
Stub out api methods 'keepfunds', 'withdrawfunds'
...
This PR adds trade closing method stubs to keep funds in the
Bisq wallet or send them to an external BTC wallet.
- Add grpc protos
- Add new methods to GrpcTradesService, CoreApi
- Stub out implementations in CoreTradesService
- Add methods to CLI
2020-10-26 17:43:08 -03:00
chimp1984
8bfe9b82c8
Remove outliers when calculating BSQ rate
...
Add percentage for upper and lower threshold for outlier detection.
2020-10-25 18:34:22 -05:00
ghubstan
a2b292318c
Add boolean 'showcontract' argument to api's 'gettrade'
...
Optionally print the json contract for a given trade id.
2020-10-25 17:44:18 -03:00
chimp1984
114b79fc2b
Fix updates of list
...
Add missing show to error popup
2020-10-25 15:27:47 -05:00
ghubstan
2b23704b5a
Add 'gettrade' to api method CLI
2020-10-25 17:15:02 -03:00
ghubstan
31435bba51
Move semicolon up from blank line
2020-10-25 17:02:40 -03:00
ghubstan
d8bc26588c
Add license comment
2020-10-25 16:52:45 -03:00
ghubstan
3379376bab
Refactor CLI output formatting code & add trade formatter
...
- Move output column header specs to its own shared constants class.
- Add new TradeFormat class for printing trade details in the console.
- Print formatted trade in api trade tests -- to see output before
using formatter in CLI (in next PR).
2020-10-25 16:50:22 -03:00
ghubstan
161dbade0d
Add getRole(tradeId) to core api
...
API users will need to see their role as maker/taker when looking at trade details.
- Add getRole(trade) to TradeUtil.
- Add getTradeRole(tradeId) to CoreApi, CoreTradesService.
- Add role field to TradeInfo proto and its wrapper class.
2020-10-25 16:22:20 -03:00
chimp1984
93031ba66e
Add export to csv hyperlink (a button takes too much vertical space)
2020-10-25 13:54:58 -05:00
sqrrm
17745e3bee
Clean up riskFactor methods
2020-10-25 18:55:04 +01:00
sqrrm
b64c816047
Refactor getTradeLimit
2020-10-25 18:47:07 +01:00
sqrrm
56c8cd1507
Remove unused old activation date
2020-10-25 18:47:07 +01:00
ghubstan
bbd7a31c88
Remove unused import
2020-10-25 11:38:03 -03:00
ghubstan
95bcb1ef9c
Refactor PendingTradesDataModel methods -> TradeUtil
...
Scope of this refactoring is small; more can be done, but the short
term goal is to share trade util logic with core api.
- Removed unused method getCurrencyCode()
- Made minor style changes
- Removed duplicated code block
2020-10-25 11:27:30 -03:00
ghubstan
36ad137949
Remove trailing spaces for codacy
2020-10-25 10:54:40 -03:00
ghubstan
24ba9215cd
Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil
2020-10-25 10:41:19 -03:00
ghubstan
ccd3c99f2e
Fix comment typos
2020-10-24 17:45:01 -03:00
ghubstan
296e4f98cb
Replace static TradeUtil with singleton TradeUtil
...
The API is going to need some desktop trade utilities, which should be
shared between :desktop and :core.api.
2020-10-24 17:26:10 -03:00
ghubstan
63cf436990
Add fields to grpc TradeInfo proto & wrapper
2020-10-24 16:27:03 -03:00
ghubstan
ab20225cd2
Add compiler warning suppression, remove comment
2020-10-24 16:25:20 -03:00
chimp1984
44a9756f80
Apply code inspection suggestions
...
Add checks if optional is present
2020-10-24 13:20:29 -05:00
chimp1984
37952c8dd0
Use networkPostfix for file name
2020-10-24 13:03:52 -05:00
chimp1984
832bc83e93
Add ifPresent check at optional
2020-10-24 13:03:03 -05:00
cd2357
ca56d002df
Update netlayer references to bisq repos
...
Update build.gradle to rely on the netlayer libraries from the bisq-network repo. The library versions (commit IDs) remain the same, only the repo from which they are pulled is changed.
2020-10-24 13:33:22 +02:00
Christoph Atteneder
55c663ad47
Merge pull request #4676 from jmacxx/show_tx_fee
...
Show current tx fee rate on main screen
2020-10-24 11:40:34 +02:00
sqrrm
93a3188659
Merge pull request #4680 from chimp1984/add-InventoryMonitor-module
...
Add inventory monitor module
2020-10-23 19:26:53 +02:00
chimp1984
f7b44f1646
Improve logs
2020-10-23 11:02:47 -05:00
ghubstan
cb65de6d2e
Block on tx-fee-request in core TakeOfferModel init
...
Added license comment too.
2020-10-23 12:47:06 -03:00
sqrrm
9e76f5fdc3
Merge pull request #4606 from ghubstan/remove-dup-statuscheck
...
Delete redundant core.api.StatusCheck
2020-10-23 15:42:34 +02:00
chimp1984
330f14ff1f
Revert changes for json export of dao data
...
Backend is not ready yet and the changes are bigger than initially expected.
Was changed as part of 0d469066ce
See discussion at https://github.com/bisq-network/bisq/pull/4670
2020-10-23 01:39:49 -05:00
chimp1984
f1fdf3c0a5
Improve deviation model
2020-10-23 01:17:34 -05:00
chimp1984
0c4eb14077
Only log and increase numAllConnectionsLostEvents if we have not called shutDown
...
We also do not call listeners in that case as some listeners have some restart routines
on that event which is not what we want at shut down
2020-10-23 01:17:34 -05:00
chimp1984
5bdc5abe34
Add numAllConnectionsLostEvents
2020-10-23 01:17:34 -05:00