When declaring a fiat currency and only providing the currency code,
it uses the system locale to get the currency display name.
This potentially causes different sorting results in
testUpdateWhenNotSortNumerically when locale is not en_US.
Now, it specifies the en_US locale when defining the fiat currencies
for this test.
Fixes https://github.com/bisq-network/bisq/issues/2259
- feeTxSizeEstimationRecursionCounter was never reset, so that caused
probably bugs by ignoring fee estimation after it was called >10 times.
The default size was used then so the bug was not very obvious as long
the tx size was not very large.
- For supporting Grin we want to add it to the next release but Grin
is not launched yet (15.1.2018 is launch date). We deactivate the asset
by using the filter message and enable it at launch date.
To support that at the altcoin account screen this commit implements
the required code.
Add updateButtonDisabledState() to onPaymentAccountSelected() in
TakeOfferViewModel since changing the account dropdown in the take
offer screen does not trigger an update of the "Next Step" button.
The default amount of an offer should not change to less than what is
actually offered, change onPaymentAccountSelected() in
TakeOfferDataModel to take into account the min. amount offered.
In TakeOfferView, the payment account defaults to the last one
selected. Make sure TakeOfferViewModel and TakeOfferDataModel take
this into account in a couple locations.
An RPM package is now generated as part of the Linux packaging script.
The packaging script can be run on any Debian or Redhat based
system and will generate both a deb and rpm package.
Resolves https://github.com/bisq-network/bisq/issues/401
The 64bitBuild.sh script has been renamed to package.sh and has
been updated so that it is capable of performing the complete packaging
process without having to rely on the jar first being built and prepped
from the MacOS scripts. However, it does support having the jar
previously built and prepped and will look for a prepped jar in the
desktop/package folder. If not found, it will build and prep it
prior to packaging.
Additionally, the Bruntime option passed to javapackager is unnecessary and
has been removed. The Bruntime option is valid only when the -native
option is set to jnlp.
Also, the prepare-system.sh script was removed as it did not appear to be
doing anything useful.
Finally, a release.sh script has been added that will perform the
release process of copying necessary files to a versioned release folder
and generating/verifying signatures. Windows and MacOS packaged installers
should be copied to their appropriate package folders prior to
executing this script if they are to be included in this release
process, otherwise only the Linux files will be included.
- Increase the minimum supported OS version to Windows 7 with SP1.
Previously it was Windows XP which has been EOL for some time now.
Hopefully no one is still using Windows XP.
- Show a final dialog once the install has completed. This will inform
the user that the install has completed with an option to launch the
application. Previously it would skip this final dialog and immediately
launch the application, but the user may not want to launch it
immediately.
- Create an application shortcut on the user's desktop.
- Check if the application is running prior to install or uninstall and
abort with a prompt to the user that the application must first be
closed.
- German, French, and Spanish translations. The installer should
auto-detect the OS language and display all text in the appropriate
language. For now I have just added a couple languages, but it is very
easy to add any of the other languages supported by Inno Setup.
- Additionally, I removed a few unnecessary items that weren't being
utilized such as installing a service.
The 64bitBuild.bat script has been renamed to package.bat and has
been updated so that it is capable of performing the complete packaging
process without having to rely on the jar first being built and prepped
from the MacOS scripts. However, it does support having the jar
previously built and prepped and will look for a prepped jar in the
desktop/package folder. If not found, it will build and prep it
prior to packaging the executable.
Additionally, some unnecessary options that were being passed to
javapackager.exe have been eliminated such as BappVersion and Bruntime.
AppVersion is now being passed via environment variables and the
Bruntime option is valid only when the -native option is set to jnlp.
The Bisq.iss file was changed so it no longer needs to be updated with
AppVersion every time as it is being passed from package.bat via
environment variables. Also, AppCopyrightYear does not need to be
updated as it is determined automatically. A few other options were
added or tweaked as well.
Finally, a release.bat script has been added that will perform the
release process of copying necessary files to a versioned release folder
and generating/verifying signatures. Linux and MacOS packaged installers
should be copied to their appropriate package folders prior to
executing this script if they are to be included in this release
process, otherwise only the Windows files will be included.
The MacOS and Linux packaging scripts should be reviewed and updated
accordingly.
Sorry was too fast with an untested ACK and merge.
- The icon loses it's color so its always black now. I think we should
stick with the colors.
- The duration was set to 10 seconds. I thinks that is too long.
- Not clear what the 'Object a = new Object() {{' definition means. I
assume you want a initializer block instead
('{ itemProperty().addListener.... }')
- We should maybe better make a small component out of that button
which behaves similar like the checkbox or radio button animation.
Maybe we can use those components instead of a normal button.
Or maybe the normal button animation from the new UI framework is enough.
- Trigger apply from snapshot if rpc error is detected
- Add warn handler to show only warning msg instead of error msg if
btc full node is not running in full mode
Applying the proposal "Remove BCH from Bisq"
(https://github.com/bisq-network/proposals/issues/61)
There have been 44 upvotes and 0 downvotes so a clear signal that the
Bisq community does not want to have BCH listed on Bisq.
JavaFX reuses the cells in a table as they're expensive to create. The
iconButton needs to be a temporary as it will otherwise update cells
with the button icon of another item when scrolling fast.
- reason for dispute fields have been not visible in dispute payout
window (row index of next iem was not increased)
- Moved payout amount fields to second column to not exceed window
height
- Set window width wider
- Cleanups
We had set the data to 0 which would lead to set the wallet date to the
genesis block. We had a "hard fork" with v0.5. so we can use that date
to ensure that the wallet birth date cannot be older.
Rename getValidAndConfirmedBallots to getAllValidBallots.
We cannot do a phase and cycle check as we are interested in
historical ballots as well.
Use warn level for logs in case data is missing and requested to
give more weight to those exceptional cases.
