Commit graph

453 commits

Author SHA1 Message Date
Chris Beams
36b3b82e52
Refactor Node from interface to value type
The modeling of BootstrapNode as an enum implementing the Node interface
became awkward, requiring an ugly, package-private 'NodeImpl' class and
other problems.

This change eliminates NodeImpl, refactors Node from being an interface
to being a value type [1,2], and refactors BootstrapNode from being an
enum to being an interface (the #all method there takes the place of
what was the enum's inherited #values method). This is slightly more
verbose in the end than being modeled as an enum, but in the end, we
were never using BootstrapNode as an enum (e.g., never used in switch
statements or == equality comparisons, etc).

[1]: http://blog.joda.org/2014/03/valjos-value-java-objects.html
[2]: http://docs.oracle.com/javase/8/docs/api/java/lang/doc-files/ValueBased.html
2014-11-06 13:52:59 +01:00
Chris Beams
640a736ec3
Repeat TomP2PTests tests using @Repeat vs. loops 2014-11-06 13:17:54 +01:00
Chris Beams
1a92b05bf4
Introduce @Repeat and RepeatRule for repeatable @Test methods
With thanks to original author Frank Appel (@fappel)

See:
 - https://gist.github.com/fappel/8bcb2aea4b39ff9cfb6e
 - http://www.codeaffine.com/2013/04/10/running-junit-tests-repeatedly-without-loops/
2014-11-06 13:17:28 +01:00
Chris Beams
8b6f0ac64e
Refactor TomP2PTests
- Introduce use of Node abstraction for concision
 - Use to BootstrapNode#LOCALHOST and #DIGITAL_OCEAN1 vs. repeating info
 - Make all configuration variables static and final constants
2014-11-06 13:17:28 +01:00
Chris Beams
655100e69f
Introduce Node#at static factory and NodeTests 2014-11-06 11:25:52 +01:00
Chris Beams
1f136de1a1
Apply consistent style to argument help text 2014-11-06 11:25:51 +01:00
Chris Beams
da163bcc97
Introduce io.bitsquare.network.Node#DEFAULT_PORT 2014-11-06 11:25:51 +01:00
Chris Beams
ce5155ebdc
Rename BootstrapNode#{LOCAL_HOST => LOCALHOST} 2014-11-06 11:24:31 +01:00
Chris Beams
1ea30fb4ae
Clarify concept of 'default network' in BitcoinModule 2014-11-06 11:24:31 +01:00
Manfred Karrer
c7524edef3 Add bootstrap info to splash screen, user final wehn possible, cleanup 2014-11-06 09:21:53 +01:00
Manfred Karrer
dbbe7cec49 Extract isSuccess in P2PNode, set custom log levels 2014-11-05 23:15:36 +01:00
Manfred Karrer
399842d8e2 Extract isSuccess to a method and return always true to ignore a bug from TomP2P (isSuccess returns always false) 2014-11-05 22:12:48 +01:00
Manfred Karrer
df3a507066 Change polling from 1 sec to 3 sec, refactorings 2014-11-05 22:00:55 +01:00
Manfred Karrer
4fb8030a43 Add loops, add extra SeedNode class, remove LanTest class 2014-11-05 20:41:34 +01:00
Manfred Karrer
bcaa8b9946 Fix random ports 2014-11-05 17:02:26 +01:00
Manfred Karrer
96f8a6c281 Use @Ignore 2014-11-05 16:47:12 +01:00
Manfred Karrer
ef68e08b50 Fix return value 2014-11-05 16:44:59 +01:00
Manfred Karrer
c8a470fb7b Add test with pong reply 2014-11-05 16:20:07 +01:00
Manfred Karrer
25be5bdbe1 Finished tests for localhost case 2014-11-05 15:37:27 +01:00
Manfred Karrer
afe7ec295b Add shutdown method 2014-11-05 15:09:37 +01:00
Manfred Karrer
879c5ca244 Use @Ignore for class, add Put test 2014-11-05 15:06:04 +01:00
Manfred Karrer
5533be6e57 Rename to TomP2PTests, add logs 2014-11-05 14:59:59 +01:00
Manfred Karrer
7fa631dfde Refactor tests (WIP) 2014-11-05 14:45:50 +01:00
Manfred Karrer
c0524120e2 Use Localhost and regtest as default, cleanup seednode 2014-11-05 13:30:49 +01:00
Manfred Karrer
e665c7ebd1 Remove ServerID as default 2014-11-05 13:26:47 +01:00
Manfred Karrer
8b468f58cf Changed to protected 2014-11-05 02:39:53 +01:00
Manfred Karrer
3a1b84ce50 Add localhost 2014-11-05 02:19:08 +01:00
Manfred Karrer
ab45d2aee0 Add missing icon 2014-11-05 02:15:11 +01:00
Manfred Karrer
28b6e0ad9d WIP 2014-11-05 02:05:42 +01:00
Manfred Karrer
58da80ca2d Add bootstrapping methods 2014-11-05 02:05:42 +01:00
Chris Beams
dc7d861f8e
Rename io.bitsquare.{=>gui}.FatalException
Localize this exception within the gui package for now, as it's the only
place where it's used at the moment.
2014-11-05 01:13:31 +01:00
Chris Beams
922a2cd22f
Introduce io.bitsquare.offer package
Move io.bitsquare.trade.{Offer,Directory=>}.offer, in order to remove
the final cycle between the msg and trade packages
2014-11-05 01:13:31 +01:00
Chris Beams
8eb988616f
Rename i.b.{BitsquareArgumentParser=>ArgumentParser} 2014-11-05 01:13:30 +01:00
Chris Beams
55ef0b43d7
Rename io.bitsquare.{di=>app}.BitsquareModule 2014-11-05 01:13:30 +01:00
Chris Beams
89a68589e0
Untangle trade and msg packages 2014-11-05 01:13:29 +01:00
Chris Beams
4f66404ae8
Remove obsolete NoopMessageFacade 2014-11-05 01:13:29 +01:00
Chris Beams
d77af7900f
Rename io.bitsquare.{msg.SeedNodeAddress=>network.Node} 2014-11-05 01:13:29 +01:00
Chris Beams
11b6a4a341
Remove BitsquareTestSuite
This class is unnecessary; Gradle runs all JUnit test classes by
default, and IDEA and other IDEs automatically detect JUnit test classes
as well.
2014-11-05 01:13:28 +01:00
Chris Beams
fe3985a510
Rename io.bitsquare.{util=>gui}.ViewLoader 2014-11-05 01:13:28 +01:00
Chris Beams
568fcaffd0
Rename io.bitsquare.{di=>}AbstractBitsquareModule 2014-11-05 01:13:27 +01:00
Chris Beams
e579ce41f9
Remove non-Akka SeedNode implementation 2014-11-05 01:13:27 +01:00
Chris Beams
9ab965f2d5
Rename io.bitsquare.{Bitsquare=>app.cli.SeedNode} 2014-11-05 01:13:27 +01:00
Chris Beams
a969b415b4
Rename io.bitsquare.{BitsquareUI=>app.gui.Main} 2014-11-05 01:13:26 +01:00
Chris Beams
865cf39e64
Remove static access to Bitsquare#getAppName 2014-11-05 01:13:26 +01:00
Chris Beams
6f27c5ce29
Remove static access to BitsquareUI#getPrimaryStage
- Bind BitsquareUI#start's primaryStage for DI
 - Statically inject primaryStage directly into Help and Popups
2014-11-05 01:13:25 +01:00
Chris Beams
f6368754b9
Begin separation of JavaFX GUI and seed node CLI 2014-11-05 01:13:25 +01:00
Chris Beams
ad1b3ccd1e
Relocate BitsquareUI#getPrimaryStage 2014-11-05 01:13:24 +01:00
Chris Beams
f278db01ac
Remove cycle between SystemTray and BitsquareUI 2014-11-05 01:13:24 +01:00
Chris Beams
b9e9882865
Move ActorSystem shutdown logic out of SystemTray 2014-11-05 01:13:23 +01:00
Chris Beams
fa7d7a08a5
Refactor SystemTray 2014-11-05 01:13:23 +01:00