Commit graph

14052 commits

Author SHA1 Message Date
ghubstan
fce3aab40d
Improve description
For suggested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560905251
2021-01-20 10:59:49 -03:00
ghubstan
86758414b7
Fix punctuation
For suggested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560902858
2021-01-20 10:45:41 -03:00
ghubstan
71ffa0f997
Explain that paid tx fees are forfeited
For suggested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560901896
2021-01-20 10:41:21 -03:00
ghubstan
4eabb9804e
Fix indentation
For suggested change
https://github.com/bisq-network/bisq/pull/5093#discussion_r560898873
2021-01-20 10:35:53 -03:00
sqrrm
2c348f7d7a
Merge pull request #5094 from chimp1984/fix-bug-with-ignoreLocalBtcNode
Fix bug with ignoreLocalBtcNode
2021-01-20 13:24:39 +01:00
chimp1984
ccc6f3f466
Do not pass proxySocketFactory to BlockingClientManager
if we use a local Bitcoin node.
2021-01-19 15:08:49 -05:00
ghubstan
cf419d2d58
Make price request frequency configurable
Added a -w option to  allow user to control the frequency of price requests.
The minimum value = 20s, default value = 120s.
2021-01-19 16:13:21 -03:00
ghubstan
48a326b990
Add env requirement and usage comments 2021-01-19 15:00:47 -03:00
ghubstan
93c3735f9c
Fix bash bugs & style problems for codacy 2021-01-19 14:38:22 -03:00
ghubstan
873c661218
Add api trade simulation scripts
Two regtest trading simulation scripts are contained in this change:

- trade-simulation.sh goes through the steps of creating F2F payment
  accounts for Bob & Alice, and each step of a trade from createoffer to
  completion.

- limit-order-simulation.sh shows one way to trigger creation of an offer
  when a limit price is reached.

Each script prints CLI commands just before they are run.

Both scripts depend on functions contained in supporting bash and python3
scripts.

Examples:

trade-simulation.sh

  Simulate the entire trade protocol between Bob (taker) & Alice (maker),
  where Alice buys 0.1 BTC from Bob, paying in Renminbi (CYN).

  Note the script takes a country code (CN) not a currency code, so the
  script can create the appropriate country based face to face payment accounts.

  $ apitest/scripts/trade-simulation.sh -d buy -c cn -m 0.0 -a 0.1

limit-order.sh

  Create a CAD/BUY 0.1 BTC order at mkt price margin of 0.0% if price falls to
  or below 47900 CAD.

  Note the script takes a country code (CA) not a currency code, so the script
  can create the appropriate country based face to face  payment accounts.

  $ apitest/scripts/limit-order-simulation.sh -l 47900 -d buy -c CA -m 0.0 -a 0.1

  Create a USD/SELL 0.1 BTC order at mkt price margin of 0.0% if price rises to
  or above 37200 USD.

  $ apitest/scripts/limit-order-simulation.sh -l 37200 -d sell -c US -m 0.0 -a 0.1
2021-01-19 13:46:55 -03:00
ghubstan
fbc31a5e86
Merge branch 'master' into 01-add-method-help-docs 2021-01-19 10:23:41 -03:00
jmacxx
531e8ca408
Add CASH_BY_MAIL to TradeStatistics3 enum 2021-01-19 07:12:14 -06:00
sqrrm
71b6b84b43
Merge pull request #5087 from ripcurlx/improve-responsiveness
Keep main navigation items left aligned
2021-01-19 11:12:03 +01:00
Christoph Atteneder
728439eecb
Merge pull request #5077 from stejbac/fix-reimbursement-validator
Fix request amount bounds in ReimbursementValidator
2021-01-19 11:00:17 +01:00
Christoph Atteneder
071e1e5a57
Merge pull request #5090 from jmacxx/disable_cpu_intensive_animations
Disable CPU-intensive animations
2021-01-19 10:54:12 +01:00
Christoph Atteneder
3d9e2a5ad8
Merge pull request #5083 from stejbac/fix-btc-node-converter-test
Avoid reverse DNS lookup in BtcNodeConverterTest
2021-01-19 10:37:27 +01:00
Christoph Atteneder
3f5c455f06
Merge pull request #5091 from jmacxx/test2
Reword "trade started" popup messages per suggestion
2021-01-19 10:27:43 +01:00
Christoph Atteneder
88c4272c63
Merge pull request #5080 from chimp1984/do-not-require-reason-for-payment
Change rule for "reason for payment" field to not use trade ID but leave it empty
2021-01-19 10:01:52 +01:00
jmacxx
2a33434a4e
codacy 2021-01-18 22:05:42 -06:00
jmacxx
3839f5961c
codacy 2021-01-18 21:58:14 -06:00
jmacxx
e11209d395
Add payment method "Cash by mail" 2021-01-18 21:15:18 -06:00
jmacxx
d7339196b7
Fix apostrophe; add message about discussing reason for payment text. 2021-01-18 19:35:17 -06:00
jmacxx
a90d606c01
Reword trade started popups per @m52go suggestion 2021-01-18 16:43:43 -06:00
jmacxx
daf5106e84
Disable animated progress indicator for Take offer 2021-01-18 15:07:08 -06:00
jmacxx
feb88bc769
Disable CPU-intensive animations
Comments out the code for footer bar progress indicator shown when
receiving a DAO block

Comments out the code for the spinner indicator shown when waiting
for trade to be funded

https://github.com/bisq-network/bisq/issues/4649#issuecomment-761950701

Fixes #4649
2021-01-18 13:23:18 -06:00
Steven Barclay
3dd552c2b3
Avoid reverse DNS lookup in BtcNodeConverterTest
Prevent failure of testConvertClearNode() on some machines, caused by
use of InetAddress.getHostName on the mock peer address. This does a
reverse DNS lookup and potentially returns something other than the
expected "192.168.0.1" string.

Also avoid an unnecessary getHostName() call on the SOCKS5 Tor proxy
InetAddress in WalletConfig, by using an alternative InetSocketAddress
constructor.
2021-01-18 16:21:52 +00:00
Christoph Atteneder
6ba04dd432
Keep main navigation items left aligned 2021-01-18 11:29:27 +01:00
ghubstan
8907d6b4a8
Keep CLI method enum members in alphabetical order 2021-01-17 13:05:07 -03:00
ghubstan
04657d9054
Explain example 2021-01-17 12:59:54 -03:00
ghubstan
44c11922a6
Add method help docs 2021-01-17 12:58:26 -03:00
sqrrm
d3971ef7dd
Merge pull request #5072 from chimp1984/persist-and-republish-mailbox-messages
Persist and republish mailbox messages
2021-01-16 20:24:13 +01:00
ghubstan
13d0d3e9f1
Add method help doc 2021-01-16 15:43:59 -03:00
ghubstan
9efeee83e3
Explain example 2021-01-16 15:35:43 -03:00
ghubstan
a133b0d7e3
Add method help doc 2021-01-16 15:35:14 -03:00
ghubstan
dab65e7f78
Fix typo 2021-01-16 15:27:46 -03:00
ghubstan
cde9a6d7c8
Add method help docs 2021-01-16 15:27:14 -03:00
ghubstan
68092a0f82
Add --memo opt to help text 2021-01-16 15:09:52 -03:00
ghubstan
d14fc40029
Fix help text typos 2021-01-16 15:07:06 -03:00
ghubstan
03f6c2a4d3
Add method help docs 2021-01-16 15:04:23 -03:00
ghubstan
629f408bdf
Add method help docs 2021-01-16 13:45:07 -03:00
ghubstan
ef4acc0b73
Make opt description generic 2021-01-16 13:44:02 -03:00
ghubstan
5538914cf8
Add line break 2021-01-16 12:03:06 -03:00
sqrrm
44cbea886a
Merge pull request #5081 from ghubstan/04-posix-cli-opts+method-help
Use posix-style CLI opts, provide method help
2021-01-16 13:43:18 +01:00
ghubstan
1ad7b351b6
Remove uneeded method 2021-01-15 16:33:52 -03:00
ghubstan
ec9f783eb5
Remove switch(hardcoded enum.name)
There is no need for a switch here, the doc exists or it does not.
2021-01-15 16:25:39 -03:00
chimp1984
5d13fdcdbb
Return early 2021-01-14 20:42:36 -05:00
ghubstan
f2a899917c
Fix default opt values 2021-01-14 19:05:27 -03:00
ghubstan
baf79e2b50
Make opt description more generic 2021-01-14 19:03:49 -03:00
ghubstan
acf2c7c50e
Remove deprecated NegativeNumberOptions
Not needed anymore, and all method opts are posix style.
(The opts parsing lib used to treat negative numbers as opt labels.)
2021-01-14 10:27:47 -03:00
ghubstan
9f0f083cf7
Change CLI opts to posix-style 2021-01-14 10:26:11 -03:00