chimp1984
2aa5feebc1
Move stopTimeout to second message handler
2020-09-21 22:23:01 -05:00
chimp1984
a725227ff3
Refactor: set string at success handlers correctly
2020-09-21 22:20:08 -05:00
chimp1984
53526e3c20
Remove repeated TakerVerifyMakerAccount and TakerVerifyMakerFeePayment from taker protocol
2020-09-21 22:08:24 -05:00
chimp1984
a8a3318f67
Refactoring: cleanups
2020-09-21 22:07:51 -05:00
chimp1984
5705d8e67a
Refactoring: rename inputsForDepositTxResponse , add more checkNotNull checks
2020-09-21 22:01:30 -05:00
chimp1984
e02355704b
Unsubscribe before state is set to avoid duplicate calls
...
Cleanups
2020-09-21 21:53:45 -05:00
chimp1984
03c2fbfb1d
Refactoring: cleanups
2020-09-21 20:45:52 -05:00
chimp1984
dc8ddbd4ae
Refactoring: cleanups
2020-09-21 20:31:22 -05:00
chimp1984
3a7af57a43
Refactoring: cleanups, add more checkNotNull tests
2020-09-21 20:18:47 -05:00
chimp1984
3269e8c6f0
Remove check that account age signature can be null. Such old versions are not supported anymore.
...
Cleanups.
2020-09-21 20:11:06 -05:00
chimp1984
a3864efe9a
Refactor: Remove final
2020-09-21 20:10:16 -05:00
chimp1984
525360c3ce
Use ApplyFilter at start at take offer process.
...
Make paymentAccountPayload nullable
Set TempTradingPeerNodeAddress with value from trade.getTradingPeerNodeAddress()
2020-09-21 20:02:50 -05:00
chimp1984
c88135713e
Revert removal of Nullable. arbitratorNodeAddress is null (confused it with acceptedArbitratorNodeAddresses)
2020-09-21 20:01:24 -05:00
chimp1984
19afb449d5
Refactor: rename inputsForDepositTxRequest to request
...
Remove final
Cleanups
2020-09-21 19:49:36 -05:00
chimp1984
a25dcf29fa
Refactor: Rename sig to accountAgeWitnessSignatureOfOfferId to make context more clear
2020-09-21 19:48:35 -05:00
chimp1984
87c2ddf200
Remove Nullable annotations. arbitratorNodeAddress is not null and accountAgeWitnessSignatureOfOfferId
...
was added in v 0.6 so is with todays versions also not null
2020-09-21 19:48:01 -05:00
chimp1984
6a83534377
Cleanups. Small functional change by removing wrapping into arraylist
2020-09-21 19:29:15 -05:00
chimp1984
3d56312ccd
Refactor:
...
- Remove '@SuppressWarnings({"unused"})'
2020-09-21 19:11:44 -05:00
chimp1984
4d7b2897fc
Refactor:
...
- Use `TaskRunner<Trade> taskHandler` instead of `TaskRunner taskHandler`
2020-09-21 19:11:07 -05:00
chimp1984
944a77d695
Refactor:
...
- Rename getFundsNeededForTradeAsLong to getFundsNeededForTrade
- Use checkNotNull instead of if/else check
- Cleanups
2020-09-21 19:09:14 -05:00
chimp1984
690104e6ea
Show popup on MissingDelayedPayoutTxException. Update display string of popup
2020-09-21 18:56:58 -05:00
Christoph Atteneder
6af2a46e49
Merge pull request #4542 from chimp1984/refactor-regexvalidator
...
Refactor regexvalidator
2020-09-21 20:16:53 +02:00
Oscar Guindzberg
93f9f83136
Make codacy happy
2020-09-21 12:40:53 -03:00
Oscar Guindzberg
2a33095021
WalletService.isOutputScriptConvertibleToAddress() include segwit outputs
2020-09-21 12:40:53 -03:00
Oscar Guindzberg
e8c82549a8
Use Address.fromString() for btc addresses
...
Use Address.fromString() instead of LegacyAddress.fromBase58() for btc addresses.
Trade protocol addresses not migrated yet.
2020-09-21 12:40:52 -03:00
Oscar Guindzberg
87833fd3fc
Declare returning type as LegacyAddress
2020-09-21 12:40:52 -03:00
Oscar Guindzberg
8a3d403bfc
Rename WalletService.emptyWallet() to emtyBtcWallet()
2020-09-21 12:40:52 -03:00
Oscar Guindzberg
fe79369be6
Rename Base58BitcoinAddressValidator to Base58AddressValidator
2020-09-21 12:40:49 -03:00
chimp1984
9c0b40a3b9
Refactor: Move Regex test methods from GUIUtilTest to RegexValidatorTest in core
2020-09-20 22:16:22 -05:00
chimp1984
c6f2732062
Refactor: Move RegexValidator factory methods to RegexValidatorFactory in core
2020-09-20 22:14:14 -05:00
chimp1984
3675e76194
Refactor: Move egexValidator from desktop to core
2020-09-20 22:13:18 -05:00
chimp1984
48a3f7443e
Merge branch 'master_upstream' into fix-trade-protocol-issues
...
# Conflicts:
# core/src/main/java/bisq/core/offer/placeoffer/tasks/CreateMakerFeeTx.java
2020-09-19 10:23:40 -05:00
Oscar Guindzberg
9a7439bef7
Break lines at 120 characters
2020-09-18 18:29:39 -03:00
Oscar Guindzberg
b89e9e1168
Code quality: Use {} in if oneliners
2020-09-18 18:29:39 -03:00
Oscar Guindzberg
24da46879f
bugfix: When creating a new BSQ wallet, use the BTC wallet seed
2020-09-18 18:29:39 -03:00
Oscar Guindzberg
f1738f0b19
Code polishing to make Codacy happier
2020-09-18 18:29:38 -03:00
Oscar Guindzberg
f342c89c8e
Code polishing to make Codacy happy
2020-09-18 18:29:37 -03:00
Oscar Guindzberg
02559f2334
Revert "bitcoinj 0.15: Remove call to PeerGroup.setIgnoreHttpSeeds(true)."
...
This reverts commit 9be6a9dd295b439a66c4d369563411009c9db329.
2020-09-18 18:29:37 -03:00
Oscar Guindzberg
daaacecafb
Use bitcoinj 0.15.8 (commit 0d98efb)
2020-09-18 18:29:37 -03:00
Oscar Guindzberg
4de39fc2a3
Make it clear P2PKH is used always used
...
Make it clear P2PKH is used for both BSQ and BTC wallets
until segwit is implemented.
2020-09-18 18:29:36 -03:00
Oscar Guindzberg
d0b00fb6f4
Use bitcoinj 0.15.8 (commit 0d7762b)
2020-09-18 18:29:36 -03:00
Oscar Guindzberg
00c9f401c1
WalletConfig.preferredOutputScriptType: make it a method variable
2020-09-18 18:29:36 -03:00
Oscar Guindzberg
5a00770377
bitcoinj 0.15: BisqRiskAnalisys: Add commented out code to match original DefaultRiskAnalysis.
2020-09-18 18:29:35 -03:00
Oscar Guindzberg
d8e0ba752f
bitcoinj 0.15: Replace deprecated Script methods with ScriptPattern methods.
2020-09-18 18:29:34 -03:00
Oscar Guindzberg
76e6955aa4
bitcoinj 0.15: Replace deprecated Transaction.getHash() with Transaction.getTxId().
2020-09-18 18:29:34 -03:00
Oscar Guindzberg
9a9b067d70
bitcoinj 0.15: Replace deprecated Transaction.getHashAsString with Transaction.getTxId().toString().
2020-09-18 18:29:33 -03:00
Oscar Guindzberg
6e50996ae4
bitcoinj 0.15: Remove call to PeerGroup.setIgnoreHttpSeeds(true).
2020-09-18 18:29:33 -03:00
Oscar Guindzberg
e5fa24e909
bitcoinj 0.15: Bip44 refactor.
...
- WalletConfig was rewritten from scratch based on bitcoinj 0.15 WalletAppKit.
- bitcoinj 0.15 allows bip32 custom paths by constructor parameters, some subclasses were removed.
2020-09-18 18:29:33 -03:00
Oscar Guindzberg
7b172c1280
bitcoinj 0.15: PeerAddress: BtcNodeConverterTest fixes.
2020-09-18 18:29:32 -03:00
Oscar Guindzberg
3717323444
bitcoinj 0.15: PeerAddress: Use InetSocketAddress constructor instead of InetAddress+port.
2020-09-18 18:29:32 -03:00
