Commit graph

7031 commits

Author SHA1 Message Date
Alejandro García
2669d736b6
Merge pull request #6631 from alejandrogarcia83/update-data-stores-for-v1.9.10
Update data stores for v1.9.10
2023-04-04 06:53:23 +00:00
yonson2023
8e43f15114
Code review changes. 2023-04-03 11:45:18 +10:00
yonson2023
ce4bae99bb
Move knaccc test module to core/xmr. 2023-04-03 11:45:11 +10:00
yonson2023
2ec4dd256d
Check private view key is a valid scalar. 2023-04-03 11:45:05 +10:00
yonson2023
5f54905c71
Validate that XMR subaddress view key matches the main address. 2023-04-03 11:44:43 +10:00
Alejandro García
1b6547b0c4
Update bitcoinj checkpoints for v1.9.10 2023-04-03 10:41:29 +10:00
Alejandro García
b5298fb848
Update translations for v1.9.10 2023-04-02 11:11:20 +10:00
HenrikJannsen
ee83607225
Add total received BTC field
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-03-31 19:47:34 +07:00
HenrikJannsen
aa5de89ee2
Add total revenue to burningman details.
We do not add a column to the overview table because calculating the balance entries is expensive and doing it over all burningmen would take too long. There is headroom for performance improvements in that area...

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-03-31 18:17:53 +07:00
Christoph Atteneder
cf56ae316e
Merge pull request #6597 from jmacxx/support_ui_improvements
Support UI improvements
2023-03-27 13:46:20 +02:00
jmacxx
9feccb6b46
BSQ trade fee validation NACK if tx unconfirmed for a long time. 2023-03-23 12:19:12 -05:00
jmacxx
c404eb1e91
Support UI improvements (per bisq project 67). 2023-03-11 22:06:07 -06:00
Alejandro García
fe30b21643
Merge pull request #6599 from yonson2023/bm_distribution_report
Add report showing monthly BTC paid to BurningMen.
2023-03-11 15:12:40 +00:00
yonson2023
289f546f7f
Add report showing monthly BTC paid to BurningMen. 2023-03-07 18:34:42 -06:00
jmacxx
8a41637b58
Limit offer min/max amount deviation to 50%. 2023-02-27 20:24:52 -06:00
yonson2023
030bb3f64c
Payout tx confidence should be after block height of deposit. 2023-02-19 16:21:54 -06:00
Alejandro García
71615824a8
Merge pull request #6585 from yonson2023/fix_payment_started_bug
Fix NPE at trade payment started event.
2023-02-18 18:12:04 +00:00
Alejandro García
3dc3464114
Merge pull request #6581 from alvasw/rename_network_filter_to_ban_filter
Rename NetworkFilter to BanFilter
2023-02-15 18:24:55 +00:00
jmacxx
6801ebfbd7
Fix exception due to missing read lock. 2023-02-15 10:48:59 -06:00
yonson2023
9d4d575739
Fix NPE at trade payment started event. 2023-02-13 21:29:41 -06:00
Alva Swanson
d411ae1252
Remove unused ConnectionListener.onError(...) method 2023-02-12 20:44:38 +02:00
Alva Swanson
f9a0e5d6d0
Rename NetworkFilter to BanFilter 2023-02-12 20:30:58 +02:00
Alejandro García
581fbd1d2d
Merge pull request #6579 from stejbac/further-speed-up-transactions-view-load
Further speed up transactions view load
2023-02-12 14:05:36 +00:00
yonson2023
baad09bfc8
Fix unhandled exception when empty txId passed. 2023-02-11 08:55:08 -06:00
Steven Barclay
37b6a4becf
Cache formatters to speed up DisplayUtils.formatDateTime
Make 'FormattingUtils.formatDateTime(Date, boolean)' two or three times
faster by caching the 'java.text.DateFormat' objects used to format the
given date & time in either the local or UTC time zone. Since these
formatters are not thread safe (though they may be reused), use a
ThreadLocal to store them (as a tuple, along with the current locale to
make sure it hasn't changed since the last invocation).

This is a minor hotspot for the Transactions view load, since the date
strings in TransactionsListItem are formatted eagerly (via DisplayUtils)
for the purpose of filtering the items by substring match. (Other list
views seem to format dates lazily, though it's possible that there will
be speedups elsewhere in the UI.)
2023-02-11 15:47:04 +08:00
Alejandro García
b1e2cb03ad
Merge pull request #6568 from alvasw/gradle_apply_central_bisq_java_conventions
Gradle apply central bisq java conventions
2023-02-05 22:43:48 +00:00
Alejandro García
c61bd70ead
Merge pull request #6562 from alvasw/move_get_single_thread_executor_to_own_utils
Move SingleThreadExecutors to its own Utils class
2023-02-05 22:42:02 +00:00
Alva Swanson
53837bf00b
Move SingleThreadExecutors to its own Utils class 2023-02-05 22:11:35 +01:00
Alva Swanson
b2870ccee3
Delagate thread pool shutdown to Guava MoreExecutors 2023-02-05 22:09:56 +01:00
Alva Swanson
c1c4caf87f
Gradle: Apply bisq.java-conventions to all projects 2023-02-05 22:02:13 +01:00
Alejandro García
e6f2703738
Merge pull request #6557 from alvasw/export_json_files_service_shutdown_executor
ExportJsonFilesService: Shutdown Executor
2023-02-05 18:58:00 +00:00
Alva Swanson
7665780ca4
ExportJsonFilesService: Shutdown Executor 2023-02-05 13:36:09 +01:00
Alva Swanson
5506443d54
ScryptUtil: Fix thread leak
Each time someone called the static method
ScryptUtil.deriveKeyWithScrypt(...) a new worker pool was created. The
worker pool was never shutdown.
2023-02-05 13:31:15 +01:00
Alva Swanson
4779c82d0b
Fix BurningManAccountingStore data races
Multiple threads read and write to the accounting blocks list causing
data races. Luckily, the LinkedList threw a ConcurrentModificationException
to limit damage. Now, a ReadWriteLock protects the LinkedList against
data races. Multiple threads can read the list at the same time but only
one thread can write to it. Other writing threads wait until it's their
turn.

Fixes #6545
2023-02-03 23:41:51 +01:00
Alejandro García
f24e0f231d
Merge pull request #6548 from alvasw/fix_dao_state_storage_service_shutdown_data_corruption_bug
DaoStateStorageService: Fix shutdown data corruption bug
2023-02-03 15:14:44 +00:00
Alejandro García
2239924225
Merge pull request #6552 from stejbac/speed-up-closed-trades-view-load
Speed up loading and scrolling of trade history
2023-02-03 15:13:58 +00:00
Alejandro García
27613de363
Merge pull request #6546 from jmacxx/offer_availability_dao_sync_check
Maker check DAO health when handling OfferAvailabilityRequest.
2023-02-03 15:10:57 +00:00
Steven Barclay
57b2b4b864
Add txs-by-id cache to WalletService to speed up trade history view
Add a third cache to WalletService, cleared upon wallet change events,
which maps txIds to txs. This allows the speedup of repeated calls to
'WalletService.getConfidenceForTxId', by avoiding the need to copy and
scan the entire set of wallet txs to find the one with matching id,
for each method invocation.

This is mainly to provide a further speedup to the closed-trades-view
load, by making it much faster to filter the list of BSQ swap trades by
tx confirmation status in 'ClosedTradesDataModel.applyList' and
'ClosedTradesManager.getNumPastTrades'.
2023-02-01 23:02:25 +08:00
Steven Barclay
42ea12f74c
Rename WalletService.getAddressToMatchingTxSetMultiset to multimap
The return value is a (cached) SetMultimap, not a multiset.
2023-02-01 20:48:32 +08:00
Steven Barclay
f02bc787d5
Optimize 'getNumPastTrades' to speed up trade history view
Reduce a bottleneck in the closed-trades-view load & table scrolling,
caused by a call to 'ClosedTradesManager.getNumPastTrades' for each
list item displayed. This repeatedly scans the entire collection of
closed trades and BSQ swap trades, in order to count all those which
share a given peer node address. (Scanning the BSQ swap trades is
particularly slow due to their filtering by tx confirmation status.)

To this end, cache the counts of trades by peer node address with a
nullable Multiset field in ClosedTradesManager & BsqSwapTradeManager,
so that the trades are scanned at most once when the view loads. Add
listeners to clear the respective cache when the trade list changes or
the BSQ wallet txs change.
2023-02-01 19:59:48 +08:00
Alva Swanson
d9372f3a4c
XmrTxProofRequest: Shutdown executor service in terminate() 2023-01-31 17:21:34 +02:00
Alva Swanson
1066e83a27
DaoStateStorageService: Fix shutdown data corruption bug
The DaoStateStorageService submits tasks to a daemon thread executor
service. The JVM continues to execute threads until all non-daemon
threads have terminated. So the JVM will kill the DaoStateStorageService
during write requests leading to data corruption.

This change uses a non-daemon thread executor service at waits during
shutdown until all data is written to disk.
2023-01-31 16:04:06 +02:00
jmacxx
d43a0e42cf
Maker check DAO health when handling OfferAvailabilityRequest. 2023-01-29 21:46:56 -06:00
Alejandro García
f43b5fe04b
Merge pull request #6544 from jmacxx/fix_withdrawal_fee_estimation
Fix withdrawal fee calculation & the min relay fee problem.
2023-01-28 19:25:06 +00:00
Alejandro García
71c05f6ac2
Merge pull request #6541 from alvasw/dao_state_storage_service_do_not_call_executor_service_shutdown_twice
DaoStateStorageService: Don't call executorService.shutdown() twice
2023-01-28 19:23:23 +00:00
jmacxx
efac12e8ce
Fix withdrawal fee calculation & the min relay fee problem. 2023-01-27 12:02:02 -06:00
Alva Swanson
eca9aedaa7
DaoStateStorageService: Don't call executorService.shutdown() twice
MoreExecutors.shutdownAndAwaitTermination(executorService, ...) calls
executorService.shutdown() before starting its force shutdown timer.
2023-01-27 16:28:44 +02:00
Alva Swanson
6a8fb05156
Centralize all ExecutorService creations in Utilities 2023-01-27 16:15:24 +02:00
Alejandro García
d682d956a1
Merge pull request #6539 from HenrikJannsen/improve_price_feed_service
Improve price feed service
2023-01-27 13:45:08 +00:00
HenrikJannsen
fa03f16917
Use auto-indexed thread name as prefix for thread name
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
2023-01-26 12:27:30 +08:00