Commit graph

2557 commits

Author SHA1 Message Date
Manfred Karrer
250c7c1e19
Improve comment 2019-01-23 12:32:06 +01:00
Manfred Karrer
ed8df87a9b
Add comment to give more background about the fee estimation 2019-01-18 21:47:16 +01:00
Manfred Karrer
877d0ae3ac
Break up test method
Set ignore to failing tests

@Bernard could you have a look and try to get those working?
Reason for problem is that repeated calls to getEstimatedFeeTxSize
do not work (returns 0 at second call in loop which cause test to fail)
2019-01-14 15:09:37 +01:00
Manfred Karrer
461dd1d02b
Use constants for tx size values 2019-01-14 15:08:22 +01:00
Manfred Karrer
645719cf64
Remove PowerMockRunner 2019-01-14 14:33:40 +01:00
Manfred Karrer
d09296e86c
Use TxFeeEstimationService
- feeTxSizeEstimationRecursionCounter was never reset, so that caused
 probably bugs by ignoring fee estimation after it was called >10 times.
 The default size was used then so the bug was not very obvious as long
 the tx size was not very large.
2019-01-11 23:23:30 +01:00
Manfred Karrer
ba114cbdd0
Remove estimateBtcTradingFeeTxSize 2019-01-11 23:21:17 +01:00
Manfred Karrer
274beef3e5
Add getEstimatedFeeTxSize method 2019-01-11 23:21:06 +01:00
Manfred Karrer
76dd6b5126
Add TxFeeEstimationServiceTest 2019-01-11 23:20:46 +01:00
Manfred Karrer
d876cc14fc
Add TxFeeEstimationService 2019-01-11 23:20:18 +01:00
Bernard Labno
7e9bc1fee8
Altcoin disclaimer 2019-01-09 12:24:35 +01:00
Manfred Karrer
00722129cb
Add validation for trade statistics
We got a trade statistics object with price and amount 0. Unclear why
that can happen (maybe some dev was debugging things or it was created
with the API). We need to add validation when creating and publishing
a trade statistics object as well. This is just a fast fix for getting
a new release out.

Fixes #2222 and #2223
2019-01-08 18:56:04 +01:00
Manfred Karrer
c6e6d55465
Fix test 2019-01-08 15:23:34 +01:00
Manfred Karrer
7ced5d74eb
Update mainCryptoCurrencies 2019-01-08 15:11:40 +01:00
Manfred Karrer
cfb308f98b
Add more logs 2019-01-08 14:52:10 +01:00
Manfred Karrer
f5270ed559
Add log 2019-01-08 13:44:28 +01:00
Manfred Karrer
93c8f36410
Fix getBsqStateBuilder bug
putAllUnspentTxOutputMap was used 2 times instead of
putAllNonBsqTxOutputMap
2019-01-08 13:39:23 +01:00
Manfred Karrer
d6a5798003
Add check to avoid division with 0 2019-01-08 13:23:09 +01:00
Christoph Atteneder
9536223d52
Added Persian 2019-01-08 11:07:57 +01:00
Christoph Atteneder
d1221f662f
Update newly added assets 2019-01-08 11:00:08 +01:00
Christoph Atteneder
9e237be841
Update translations 2019-01-08 09:48:36 +01:00
Manfred Karrer
724247fe73
Don't show filtered currencies
- For supporting Grin we want to add it to the next release but Grin
is not launched yet (15.1.2018 is launch date). We deactivate the asset
by using the filter message and enable it at launch date.
To support that at the altcoin account screen this commit implements
the required code.
2019-01-08 02:39:08 +01:00
Manfred Karrer
ae537082d0
Update coins in isWarmingUp 2019-01-08 01:20:41 +01:00
Manfred Karrer
d5a53e9fdf
Merge pull request #2207 from ManfredKarrer/preparations-for-http-api
Preparations for http api
2019-01-07 23:31:05 +01:00
Christoph Atteneder
2a79f1a8af
Show information popup if more than one payment account is available for offer
I still used a popup as it is a more rare case that someone sets up multiple accounts of the same payment method for its first offer.
2019-01-07 16:16:00 +01:00
Christoph Atteneder
83a812a0f9
Show more verbose action when taking an existing offer 2019-01-07 16:03:52 +01:00
Manfred Karrer
e3a17d2ef5
Reduce maker fee, increase take fee
- Reduce maker fee to 0,1%, increase take fee to 0,3%

As approved by proposal
https://github.com/bisq-network/proposals/issues/65
2019-01-07 02:07:08 +01:00
Manfred Karrer
af439a86ad
Remove market price based fee calculation 2019-01-07 01:52:32 +01:00
Manfred Karrer
3c08a2739f
Merge pull request #2178 from tau3/feature/refactor-ballot-service
Unit test for BallotListService
2019-01-06 04:06:03 +01:00
Manfred Karrer
578c56c21b
Add null check at getMyTradeLimit
Other small changes:
- Remove final from User as http-api branch will require to extend it.
- Add comment
2019-01-06 03:44:50 +01:00
Manfred Karrer
dbc028e821
Use transaction from onSuccess callback 2019-01-06 03:40:56 +01:00
Manfred Karrer
3bfcd86532
Use List instead of ArrayList as type 2019-01-06 03:39:07 +01:00
Manfred Karrer
622282a446
Clone AddressEntryList at toProtoMessage 2019-01-06 03:36:59 +01:00
Manfred Karrer
618281cee9
Remove BisqFacade 2019-01-06 03:34:14 +01:00
Manfred Karrer
c7f8faa804
Implement BisqSetupCompleteListener at BisqExecutable 2019-01-06 03:30:27 +01:00
Manfred Karrer
f832633593
Merge branch 'master' into dao-fix-performance-issue-at-parsing 2019-01-05 16:23:17 +01:00
Manfred Karrer
4d8a348efb
Merge branch 'master' into dao-fix-vote-reveal-tx-publishing 2019-01-05 16:12:36 +01:00
Manfred Karrer
f12ff5ce92
Adjust % value for offer price tolerance window
- There have been some reports that the 0,5% value is too narrow so we
increase it to 1%.
2019-01-04 13:50:38 +01:00
Manfred Karrer
0a5417b861
Add duration for batch parsing to logs 2019-01-04 00:08:00 +01:00
Manfred Karrer
930d7a79e3
Call onParseBlockComplete listeners only after onParseBlockChainComplete
To avoid performance issues we omit the listener calls at
onParseBlockComplete as long we are in the batch processing of blocks.
Without that optimization it took about 50 sec. for 4000 blocks, with it
we could reduce it to 4 seconds.
2019-01-04 00:07:35 +01:00
Manfred Karrer
c334018845
Change log level 2019-01-04 00:01:21 +01:00
Manfred Karrer
9ab941ff4a
Move logs and comments to 'if' clause 2019-01-03 23:33:30 +01:00
Manfred Karrer
2f9125a3db
Improve logs 2019-01-03 22:55:05 +01:00
Manfred Karrer
d23bb2cd18
Improve logs 2019-01-03 22:34:58 +01:00
Manfred Karrer
c87383a017
Refactorings 2019-01-03 22:34:47 +01:00
Manfred Karrer
c1792a3e7f
Ignore items if isBlindVoteInCorrectPhaseAndCycle is false.
If we get a voteReveal tx which was published too late we ignore it.
- Refactorings
- Improve logs
2019-01-03 22:34:13 +01:00
Manfred Karrer
0a9f4fc236
Remove phase and cycle check for vote reveal txs.
We do not check phase or cycle as a late voteReveal tx is considered
a valid BSQ tx. The vote result though will ignore such votes.

Add more log info.
2019-01-03 22:32:27 +01:00
Manfred Karrer
c137e7ec09
Refactor maybeRevealVotes method.
Add exception handling to revealVote
2019-01-03 22:31:14 +01:00
Manfred Karrer
ef37dc3256
Set chainTipHeight before parsing. 2019-01-03 22:30:25 +01:00
Manfred Karrer
4fd8490df1
Handle late vote reveal txs
If the phase and cycle for the vote reveal tx was missed we still
publish it but it is considered invalid. We do not throw an exception
but filter such txs away from the vote result evaluation.

We cannot use the strategy to unlock the BSQ from the vote tx in such a
case because the blind vote tx is already in the past and is not parsed
again (snapshot).
Alternatively we could have used a different tx type for the unlock
purpose but we prefer to keep such an exceptional case simple.
2019-01-03 16:44:39 +01:00