Commit Graph

90 Commits

Author SHA1 Message Date
Christoph Atteneder
9ce8b215e1
Merge pull request #1775 from devinbileck/fix-take-offer-view
Hide text that is not applicable in take offer view
2018-10-17 10:17:31 +02:00
Devin Bileck
5e27cbb2f6
Fix field visibility for fixed amount offer 2018-10-16 14:52:41 -07:00
Devin Bileck
d435afdd03
Merge remote-tracking branch 'upstream/master' into fix-take-offer-view 2018-10-16 10:06:11 -07:00
Manfred Karrer
ce5a8b4f19
Merge branch 'arbitration-system-improvements' of https://github.com/ManfredKarrer/bisq into ManfredKarrer-arbitration-system-improvements
# Conflicts:
#	desktop/src/main/java/bisq/desktop/main/account/content/arbitratorselection/ArbitratorSelectionView.java
2018-10-16 11:48:11 -05:00
Manfred Karrer
dc6c25ed81
Merge branch 'master' into arbitration-system-improvements 2018-10-16 11:32:07 -05:00
Christoph Atteneder
05c47ae1d6
Merge pull request #1767 from devinbileck/labels-truncated-with-display-scaling
Workaround for JDK-8199592; text being truncated at certain display scaling levels
2018-10-16 12:16:30 +02:00
Christoph Atteneder
ad5e2329ce
Merge pull request #1774 from devinbileck/fix-preferences-view-combobox-selection
Fix preferences view combobox selection
2018-10-16 12:08:19 +02:00
Christoph Atteneder
866ea007dd
Merge pull request #1771 from devinbileck/fix-arbitrator-language-selection
Fix arbitrator language selection
2018-10-16 12:00:04 +02:00
Devin Bileck
3d3045c4d6
Move when offerAvailabilityBusyAnimation is stopped
Stop the offerAvailabilityBusyAnimation sooner, prior to showing
securityDepositInfo popup, when it is hiding related fields.
2018-10-14 23:39:03 -07:00
Devin Bileck
b0e232097e
Hide text that is not applicable in take offer view
When taking an offer that does not specify an amount range, hide
the "Check if offer is available" text.

Fixes https://github.com/bisq-network/bisq/issues/1742
2018-10-13 22:38:34 -07:00
Devin Bileck
26d03afbb4
Fix currency not sorted when added back to ComboBox
When removing a previously selected fiat or crypto currency, it was
adding it back to the bottom of the combobox rather than alphabetically.
So make sure to sort when adding a currency to the list.
2018-10-13 21:51:20 -07:00
Devin Bileck
933b0b8277
Fix prompt text disappearing after selection
After selecting an option from the combobox, it would no longer
display the prompt text and instead would be blank.

As per the documentation
https://docs.oracle.com/javase/10/docs/api/javafx/scene/control/ComboBoxBase.html#promptTextProperty:
> Prompt text is not displayed in all circumstances, it is dependent
> upon the subclasses of ComboBoxBase to clarify when promptText will be
> shown.

Therefore, use a custom buttonCell on the combo box to display the
prompt text.
2018-10-13 21:43:14 -07:00
Devin Bileck
313971d7d8
Fix combobox selection using arrow keys
Utilize the onHiding event rather than onAction event to prevent the
first option from being added when using arrow keys to navigate the
combobox. This will add the selected option when the combobox is
closing.
2018-10-13 21:37:22 -07:00
Devin Bileck
b1066d8fe1
Fix arbitrator language selection prompt text
After selecting a language from the combobox, it would no longer
display the prompt text and instead would be blank.

As per the documentation
https://docs.oracle.com/javase/10/docs/api/javafx/scene/control/ComboBoxBase.html#promptTextProperty:
> Prompt text is not displayed in all circumstances, it is dependent
> upon the subclasses of ComboBoxBase to clarify when promptText will be
> shown.

Therefore, use a custom buttonCell on the combo box to display the
prompt text.
2018-10-12 23:45:49 -07:00
Devin Bileck
cb42942d86
Fix arbitrator language selection using arrow keys
To prevent the issue mentioned in
https://github.com/bisq-network/bisq/issues/354 where using arrow keys
to navigate the combobox would add the first language, utilize the
onHiding event rather than onAction event. This will add the selected
language when the combobox is closing.
2018-10-12 23:35:37 -07:00
Devin Bileck
52a565a3b0
Workaround for labels being truncated at certain display scaling levels (JDK-8199592)
As per the workaround mentioned in https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8199592, explicitly calling sizeToScene appears to suppress the bug at DPI levels other than 175%.
2018-10-10 23:49:58 -07:00
Manfred Karrer
c8f0098b2b
Add comments, cleanups 2018-10-10 14:03:53 -05:00
Manfred Karrer
d2c98438ab
Merge branch 'master' into Dao-UI-improvements 2018-10-10 00:45:08 -05:00
Manfred Karrer
a63d1cc580
Merge remote-tracking branch 'upstream/master' 2018-10-10 00:43:51 -05:00
Manfred Karrer
56965c1904
Merge pull request #1765 from devinbileck/cancel-wallet-password-prompt
Show cancel button in wallet password prompt
2018-10-10 00:42:59 -05:00
Manfred Karrer
db3cd329b9
Add VoteResultExceptionHandler 2018-10-09 23:31:43 -05:00
Devin Bileck
1d179544f6
Hide the forgot password button in the SeedWordsView 2018-10-09 00:14:43 -07:00
Devin Bileck
c76fd598cd
Reworked implementation so as not to affect other uses of the
WalletPasswordWindow
2018-10-08 23:08:17 -07:00
Manfred Karrer
58e6db0a25
Persist DecryptedBallotsWithMeritsList 2018-10-08 20:13:22 -05:00
Manfred Karrer
4cc17feace
Persist EvaluatedProposalList 2018-10-08 19:47:54 -05:00
Devin Bileck
269912d1bb
Show cancel button in wallet password prompt 2018-10-08 15:51:36 -07:00
Manfred Karrer
57355f2b19
Merge branch 'Dao-UI-improvements' 2018-10-08 11:18:42 -05:00
Manfred Karrer
8232eeecd8
Deactivate OKPay as it does not exist anymore
OkPay seems to have rebranded to Weezzo.
The OkPay webpage is offline but some links go to Weezzo.
Seems pretty unprofessional hwo they did the move...
Seems they have been involved with BTC-e…
https://bitcointalk.to/index.php?topic=2094721.0
2018-10-07 21:54:00 -05:00
Manfred Karrer
fbbec72eb0
Merge branch 'master' into arbitration-system-improvements 2018-10-07 00:47:42 -05:00
Manfred Karrer
5dfbb6d596
Merge branch 'master' into Dao-UI-improvements 2018-10-07 00:46:48 -05:00
Manfred Karrer
2d593ee88f
Merge branch 'master' into arbitration-system-improvements 2018-10-05 15:21:41 -05:00
Manfred Karrer
4770ac9ef5
Remove asset from comboBoxes if it was removed by voting 2018-10-05 00:46:03 -05:00
Manfred Karrer
3e7eba8f04
Add Generic- and removeAsset proposals 2018-10-04 23:24:14 -05:00
Manfred Karrer
072cedc29b
Improve param change selection (WIP)
- Show current formatted value
- Parse input to correct domain value
- Add validation (WIP)
- Add boundary checks (WIP)
2018-10-04 21:36:17 -05:00
Manfred Karrer
ccdac8e20b
Add new items to Param
- Add COMPENSATION_REQUEST_MIN_AMOUNT and COMPENSATION_REQUEST_MAX_AMOUNT
As BSQ based validation values can change over time if BSQ value
rise we need to support that in the Params as well.

- Add validateParamValue to ChangeParamValidator
2018-10-04 20:28:17 -05:00
Manfred Karrer
5f43bea278
Improve setFitToRowsForTableView method 2018-10-04 19:13:19 -05:00
Manfred Karrer
93b38d20b5
Add ButtonCell and PromptText to ComboBox in FormBuilder
Default ComboBox does not show promptText after clear selection.
https://stackoverflow.com/questions/50569330/how-to-reset-combobox-and-display-prompttext?noredirect=1&lq=1
2018-10-04 18:53:14 -05:00
Manfred Karrer
281e156449
Rename AvoidStandbyMode to AvoidStandbyModeService 2018-10-04 11:36:29 -05:00
Manfred Karrer
0728d04b02
Improve logs, don't show popups in dev mode 2018-10-04 11:33:44 -05:00
fotispap
c305a3cb03 Remove age from limitations of altcoin accounts 2018-10-03 22:26:50 +02:00
Manfred Karrer
6346b14577
Remove hasMatchingArbitrator check 2018-10-02 22:47:16 -05:00
Manfred Karrer
cb17b008a3
Remove arbitrator selection view 2018-10-02 22:35:16 -05:00
Manfred Karrer
308d9d63a4
Remove autoSelectArbitratorsCheckBox 2018-10-02 22:11:43 -05:00
Manfred Karrer
8bcefaa135
Implement new arbitrator selection rule 2018-10-02 22:09:15 -05:00
Manfred Karrer
d68f9b5474
Fix wrong validation checks on proposals and ballots
- We cannot validate the txType at startup as the blockchain is nto ready at that moment. So we cannot apply that validation when we receive the payloads. We do the validation instead at the access to the lists.
- We fix a glitch with missing cycle start time in ResultsOfCycle
- Cleanup in VoteResultView
2018-10-01 21:19:12 -05:00
Manfred Karrer
d7be7f48f2
Remove unneeded BtcWalletService field 2018-09-28 13:05:06 -05:00
Manfred Karrer
2b5731ce7f
Add buyers payment account name to trade screen
In case the buyer has setup multiple accounts for a payment method
we show the used payment account for that offer in the trade screen.

See: https://github.com/bisq-network/bisq/issues/1733
2018-09-28 12:04:09 -05:00
Manfred Karrer
bd44aea27a
Add comment for @ripcurlx to add some visual element
If we have multiple payment accounts we should show some info/warning to
make sure the user has selected the account he wants to use.
To use a popup is not recommended as we have already 3 popups at the
first time (if user has not clicked
don't show again).
@ripcurlx Maybe a similar warn triangle as used in create offer
might work?

See: https://github.com/bisq-network/bisq/issues/1733
2018-09-28 11:25:07 -05:00
Manfred Karrer
afdd14e391
Remove remaining "N/A" in offer screen after price is set
- If the price is not available we display "N/A". Once the price
becomes available the listener handler was not removing the text (N/A).
2018-09-28 11:09:22 -05:00
Manfred Karrer
a9e32c0bdd
Move maker classes back to desktop module 2018-09-27 00:16:24 -05:00