Commit graph

12088 commits

Author SHA1 Message Date
jmacxx
05cc29d854
Minor bug fixes for XMR tx proof feature
Fix missing CSS color code xmr-orange, was missing from dark mode.

Fix log message spelling/typo errors.

Removed 2 fixes from SellerStep3View so that chimp1984 can make
changes.

Remove address validator from XMR service address settings because
it does not support https prefix.
2020-09-07 09:55:05 +02:00
Christoph Atteneder
38cff29d97
Merge pull request #4490 from jmacxx/origin/add-xmr-tx-key-service-fix
Minor bug fixes for XMR tx proof feature
2020-09-07 09:54:38 +02:00
Christoph Atteneder
27a9f9636f
Merge pull request #4493 from chimp1984/deactive-confirm-buttons-once-mediation-started
Deactive confirm buttons once mediation started
2020-09-07 09:42:59 +02:00
chimp1984
b1b3136969
Improve handling of nullable assetTxProof fields 2020-09-07 09:39:11 +02:00
chimp1984
9eb7900d51
Fix handling of username/accountId
We apply userName to accountId if it is not set (e.g. new account
created with new version). We do not use that for display or for
account signing in case both fields are the same but we need to use
accountId in case the user trades with a not updated user who expects
accountId as only field.
I improved a bit the display of account data in the trade screens.
In case accountId was set with the phone number (updated account with
phone nr used for account signing) we show both userName and phone nr.

- Show phone number if accountId was set by old account. Otherwise
show only userName
- For old users they will see the user name as phone number displayed
if they trade with new users if the new user has created a new account.
If he has updated an existing account the accountId (phone number) is
used, so it displays the phone number.
- At step 2 changed display of own account data to show account name
- Add 'Recipients' prefix to account data of peer at step 2

Step 3: Buyers account data can be
- Phone number if peer is using old version
- User name if peer is updated user with new account (we apply userName
to accountId)
- Phone number if user is on old version and peer is updated user with
updated account (we keep accountId as phone number)
- User name/Phone number if peer is updated user with updated account
2020-09-07 09:39:02 +02:00
chimp1984
1a2b17b1cd
Move revolutAccountsUpdateHandler code up to BisqSetup 2020-09-07 09:38:51 +02:00
chimp1984
a4f6d2af2e
Add check if xmrTxProof is used to avoid null pointer exception 2020-09-07 09:38:44 +02:00
chimp1984
05353bb43d
Add JsonExclude to userName
For backward compatibility we need to exclude the new field for
the contract json.
We can remove that after a while when risk that users with
pre 1.3.8 version trade with updated
users is very low.
2020-09-07 09:38:37 +02:00
chimp1984
e080b06736
Remove unused method 2020-09-07 09:34:57 +02:00
chimp1984
9cc614a790
Add alert icon to list entries
Support agent can mark a suspicious dispute as resolved so it does not
show the alert icon anymore. In the full report a [ACK] got added to
that dispute.
2020-09-07 09:34:47 +02:00
chimp1984
67e90f908a
Remove unused var 2020-09-07 09:34:39 +02:00
chimp1984
cc2d258915
Scan disputes for accounts where same user used diff. real names.
Might be fraudulent traders.
2020-09-07 09:34:31 +02:00
chimp1984
38d33ceab3
Remove offer from takers offerbook after take offer is completed.
We do not wait until the offer got removed by a network remove message but remove it
directly from the offer book. The broadcast gets now bundled and has 2 sec. delay so the
removal from the network is a bit slower as it has been before. To avoid that the taker gets
confused to see the same offer still in the offerbook we remove it manually. This removal has
only local effect. Other trader might see the offer for a few seconds
still (but cannot take it).
2020-09-07 09:30:44 +02:00
wiz
d55cc47284
Fix compile error in core/src/main/java/bisq/core/user/Preferences.java 2020-09-07 09:28:28 +02:00
wiz
f5d8f6ddc2
Add new Monero Explorer node77.monero.wiz.biz with onion 2020-09-07 09:28:17 +02:00
chimp1984
2ab779f9b8
Remove DevTestXmrTxProofHttpClient 2020-09-07 01:05:07 -05:00
chimp1984
6a061d2c58
Create new HttpClient for each request. 2020-09-07 01:04:23 -05:00
jmacxx
f49aa0f674
Minor bug fixes for XMR tx proof feature
Fix missing CSS color code xmr-orange, was missing from dark mode.

Fix log message spelling/typo errors.

Removed 2 fixes from SellerStep3View so that chimp1984 can make
changes.

Remove address validator from XMR service address settings because
it does not support https prefix.
2020-09-07 00:06:50 -05:00
chimp1984
c40bcfedfc
Fix merge mistake 2020-09-06 23:51:24 -05:00
chimp1984
0bf433350a
Use a checkArgument to ensure that the methods are not called once a
dispute has been opened. This will cause a Runtime exception but that
is justified as the caller need to ensure to do the check and do not
allow to get to that point.
2020-09-06 23:22:31 -05:00
chimp1984
f3c96bbb62
Merge branch 'master_upstream' into deactive-confirm-buttons-once-mediation-started
# Conflicts:
#	desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java
2020-09-06 23:13:43 -05:00
chimp1984
087dde0e9d
Add check if trade have been dispute to protocol classes 2020-09-06 23:09:45 -05:00
chimp1984
1419f05152
Add comment to empty method 2020-09-06 23:06:27 -05:00
chimp1984
a4b43f66a9
Apply codacy suggestion (this time a good one ;-)) 2020-09-06 22:04:41 -05:00
chimp1984
f3a3b6e9a8
Bug fixes
- useXmrTxProof was set at active but used in addContent which was
called before activate.
- Fix bug with using currencyName instead of currencyCode
- Refactor: Use methods in base class instead of repeated code
2020-09-06 21:37:25 -05:00
chimp1984
7c480babad
Add missing 'git lfs pull' command at build from scratch 2020-09-06 20:46:14 -05:00
chimp1984
199d543c23
Remove ugly parameter
The 'arePeersPaymentAccountDataBanned' method in filterManager had a
parameter 'PaymentAccountFilter[] appliedPaymentAccountFilter' which
was used to pass over the PaymentAccountFilter which matched a banned
account. The result was only used at the fault handler (log) in the
ApplyFilter task. I think this was not needed to display and if it
should be done in a different way, e..g using a Consumer to pass back
the value, but as the method is a validation method returning a boolean
we should avoid to add side-effects like writing some property.
2020-09-06 20:43:43 -05:00
chimp1984
e99e6a478e
Add InvalidProtocolBufferException in catch clause 2020-09-06 20:18:50 -05:00
chimp1984
a32653f790
Add log in case protoOutputStream.writeEnvelope fails 2020-09-06 20:18:02 -05:00
chimp1984
00fe80ef0e
Refactor
Use a stream filter instead of a if clause
2020-09-06 20:16:00 -05:00
sqrrm
cafbbdf94c
Merge pull request #4488 from wiz/add-wiz-xmr-explorer
Add new Monero Explorer node77.monero.wiz.biz with onion
2020-09-07 00:24:10 +02:00
sqrrm
d152f88285
Merge pull request #4479 from chimp1984/improve-xmr-proof-p2pNetworkAndWalletReady-handling
Improve handling of p2pNetworkAndWalletReady
2020-09-06 23:33:05 +02:00
sqrrm
7389bf898c
Merge pull request #4480 from chimp1984/add-support-for-monero-address-prefix
Remove 'monero:' prefix when adding a XMR account
2020-09-06 23:24:40 +02:00
sqrrm
236e9e6d4b
Merge pull request #4487 from chimp1984/remove-offer-from-offer-list-for-taker
Remove offer from takers offerbook after take offer is completed.
2020-09-06 23:23:19 +02:00
sqrrm
c188284d0b
Merge pull request #4484 from chimp1984/detect-accounts-with-diff-real-names
Scan disputes for accounts where same user used diff. real names.
2020-09-06 23:17:32 +02:00
sqrrm
682cc402e7
Merge pull request #4481 from chimp1984/add-backward-compatibility-for-revolut-change
Add backward compatibility for revolut change
2020-09-06 19:13:09 +02:00
chimp1984
ec31ecbf43
Improve handling of nullable assetTxProof fields 2020-09-06 12:05:39 -05:00
sqrrm
f35bc6d016
Merge pull request #4483 from wiz/tweak-dao-bonded-role-names
Tweak a few DAO bonded role names in strings file
2020-09-06 18:57:14 +02:00
wiz
4b9a1a0138
Fix compile error in core/src/main/java/bisq/core/user/Preferences.java 2020-09-07 00:46:06 +09:00
wiz
82f8cf6d40
Add new Monero Explorer node77.monero.wiz.biz with onion 2020-09-06 18:36:32 +09:00
chimp1984
7fff461669
Remove offer from takers offerbook after take offer is completed.
We do not wait until the offer got removed by a network remove message but remove it
directly from the offer book. The broadcast gets now bundled and has 2 sec. delay so the
removal from the network is a bit slower as it has been before. To avoid that the taker gets
confused to see the same offer still in the offerbook we remove it manually. This removal has
only local effect. Other trader might see the offer for a few seconds
still (but cannot take it).
2020-09-05 19:45:00 -05:00
chimp1984
9908bcf33a
Rename method 2020-09-05 19:19:49 -05:00
chimp1984
55e55d4f19
Deactivate confirm payment or payment received buttons once a dispute
is opened.
2020-09-05 19:18:33 -05:00
chimp1984
959009d6d6
Remove unused method 2020-09-05 17:54:32 -05:00
chimp1984
4a4bd7cd12
Add alert icon to list entries
Support agent can mark a suspicious dispute as resolved so it does not
show the alert icon anymore. In the full report a [ACK] got added to
that dispute.
2020-09-05 17:39:22 -05:00
chimp1984
5a65b150fe
Remove unused var 2020-09-05 07:41:27 -05:00
chimp1984
7c78e98192
Scan disputes for accounts where same user used diff. real names.
Might be fraudulent traders.
2020-09-05 01:40:35 -05:00
wiz
7fba82779a
Tweak a few DAO bonded role names in strings file
* Rename "BSQ explorer operator" to "Explorer operator", as per https://github.com/bisq-network/proposals/issues/257
* Rename "Markets API operator" to "Markets operator" as per https://github.com/bisq-network/projects/issues/41
2020-09-05 15:28:19 +09:00
chimp1984
97d3383dbb
Fix handling of username/accountId
We apply userName to accountId if it is not set (e.g. new account
created with new version). We do not use that for display or for
account signing in case both fields are the same but we need to use
accountId in case the user trades with a not updated user who expects
accountId as only field.
I improved a bit the display of account data in the trade screens.
In case accountId was set with the phone number (updated account with
phone nr used for account signing) we show both userName and phone nr.

- Show phone number if accountId was set by old account. Otherwise
show only userName
- For old users they will see the user name as phone number displayed
if they trade with new users if the new user has created a new account.
If he has updated an existing account the accountId (phone number) is
used, so it displays the phone number.
- At step 2 changed display of own account data to show account name
- Add 'Recipients' prefix to account data of peer at step 2

Step 3: Buyers account data can be
- Phone number if peer is using old version
- User name if peer is updated user with new account (we apply userName
to accountId)
- Phone number if user is on old version and peer is updated user with
updated account (we keep accountId as phone number)
- User name/Phone number if peer is updated user with updated account
2020-09-04 18:30:08 -05:00
chimp1984
9e6db6e738
Move revolutAccountsUpdateHandler code up to BisqSetup 2020-09-04 18:20:16 -05:00