Commit graph

4840 commits

Author SHA1 Message Date
Oscar Guindzberg
1f3c585c35
Serialize tx without segwit
This is for backwards compatibility with bisq nodes that have not
upgraded to bitcoinj 0.15.
2020-10-08 16:33:52 -03:00
Oscar Guindzberg
f9f5d92941
Add segwit/legacy checbox for address creation 2020-10-08 16:33:52 -03:00
Oscar Guindzberg
a9cc28f65a
AddressEntryList: arbitrator entry use P2PKH 2020-10-08 16:33:52 -03:00
Oscar Guindzberg
a3708485f9
New AddressEntry: use different script types
Use P2WPKH for AVAILABLE context and P2PKH for the rest.
Disable reusing unused AVAILABLE entries until segwit support is
mandatory in Bisq.
2020-10-08 16:33:51 -03:00
Oscar Guindzberg
d8b755794e
WalletService: adapt to segwit wallet 2020-10-08 16:33:51 -03:00
Oscar Guindzberg
25515710ab
TradeWalletService: adapt to segwit wallet 2020-10-08 16:33:51 -03:00
Oscar Guindzberg
0f4c66f43d
Comment out segwit BSQ account path
Segwit is not used for BSQ
2020-10-08 16:33:50 -03:00
Oscar Guindzberg
0c7f3456b6
Fix log msg in BtcCoinSelector 2020-10-08 16:33:50 -03:00
Oscar Guindzberg
e85c66b810
Stop using LegacyAddress for btc addresses 2020-10-08 16:33:49 -03:00
Oscar Guindzberg
ced357ce25
AddressEntry: Add boolean segwit flag 2020-10-08 16:33:49 -03:00
Oscar Guindzberg
cd28660069
Add a P2WPKH keychain for existing wallets 2020-10-08 16:33:49 -03:00
Oscar Guindzberg
f13a7b164c
Create a P2WPKH keychain for new btc wallets 2020-10-08 16:33:48 -03:00
Christoph Atteneder
2d06946c18
Update translations for v1.4.0 2020-10-08 09:41:42 +02:00
Christoph Atteneder
90d00a2c7f
Merge pull request #4603 from ncstdc/patch-2
Update displayStrings.properties for Mediation Popup
2020-10-08 09:30:45 +02:00
chimp1984
076af0a3e1
Do not log full tiler object in case of an invalid Filter
Instead log signerPubKeyAsHex and creation date. We have currently the old filter still around (intended) so we get that log called and it would confuse ppl reading the log without knowing more about the context.
2020-10-07 09:42:01 -05:00
sqrrm
723a1f5cf9
Merge pull request #4592 from chimp1984/improve-bisq-setup
Improve bisq setup
2020-10-07 14:08:10 +02:00
Christoph Atteneder
7d14ff37d8
Merge pull request #4595 from ghubstan/remove-duplicated-supporttype-enum
Remove redundant DisputeAgentType enum
2020-10-07 09:37:15 +02:00
Christoph Atteneder
66f6e49f83
Merge pull request #4596 from ghubstan/refactor-placeoffer-tx-handling
Simplify GrpcOffersService#createOffer (refactor)
2020-10-07 09:30:40 +02:00
chimp1984
7ecae0e5be
Set amounts before setting state, as the state triggers the check where the amount is needed 2020-10-06 11:30:44 -05:00
dchoe
39d37e1070
Update displayStrings.properties
Better wording
2020-10-06 10:44:09 -05:00
chimp1984
4a0fe3e62e
Move checks to enable confirm to Trade
Use it in view to disable button
2020-10-06 10:40:39 -05:00
chimp1984
0e89c27021
Add mediationResultAppliedPenaltyToSeller method to Trade
Add util methods to DisputeState
Impl. paymentReceivedEnabled method for SellerProtocol
Impl. paymentStartedEnabled method for BuyerProtocol
Remove notDisputed method as not used anymore

Add final keywords
2020-10-06 10:22:22 -05:00
ghubstan
5f9b1e6e1a
Format exception message 2020-10-06 11:30:17 -03:00
ghubstan
30e6dae90b
Change return type to void
The prior Offer return type is redundant and confusing given the
new offer is passed up via the Consumer<Offer> resultHandler.
2020-10-06 11:19:08 -03:00
Christoph Atteneder
049b6209b7
Merge pull request #4594 from ghubstan/refactor-api-price-service
Tidy up CorePriceService (refactor)
2020-10-06 10:04:00 +02:00
ghubstan
3f3f4f06f5
Use consumer::accept instead of a countdown latch
This is more readable and stylistically consistent.
2020-10-05 14:32:05 -03:00
ghubstan
2d34730bd8
Fix method name 2020-10-05 13:51:48 -03:00
ghubstan
dd67acc153
Simplify GrpcOffersService#createOffer (refactor)
Push the placeOffer call down into CoreOffersService#createOffer,
and use a countdown latch to wait for async placeOffer to
complete.
2020-10-05 12:23:54 -03:00
chimp1984
474c4138d2
Refactor: rearrange methods 2020-10-04 17:24:03 -05:00
chimp1984
52f5f2f064
Extract domain initialisation to domainInitialisation class 2020-10-04 17:24:03 -05:00
chimp1984
d6c3ccd605
Add AppStartupState and DomainInitialisation.accountAgeWitnessService
See comments to classes for reasoning.
2020-10-04 17:24:03 -05:00
chimp1984
e179ee4e32
Use Collection for constructor which is called from the fromProto methods.
We do not set the collection as list but we fill the list created via the createList method.
2020-10-04 16:13:45 -05:00
chimp1984
d18b243322
Do not use persistNow for snapshots but requestPersistence
This avoids frequent write at dao sync and better performance.
2020-10-04 13:34:28 -05:00
chimp1984
f9f33aa16d
Add PersistableListAsObservable
Remove ObservableList methods from PersistableList
Let DisputeList and TradableList extend PersistableListAsObservable
Fix param names
2020-10-04 13:18:25 -05:00
chimp1984
f7c2464fbc
Fix typo 2020-10-04 13:16:49 -05:00
ghubstan
9942529448
Remove redundant DisputeAgentType enum
Use existing SupportType enum instead, and map the valid api
'registerdisputeagent' method's dispute-agent-type parameter
names to SupportType.
2020-10-03 15:42:27 -03:00
ghubstan
0cc998c4e2
Tidy up CorePriceService
Remove unnecessary String.format call and do a null check.
2020-10-03 14:48:49 -03:00
chimp1984
e9db7c6808
Rename Priority to Source. This should make it more clear what is the intention of the usage.
Rename:
LOW to NETWORK
MID to PRIVATE_LOW_PRIO
HIGH to PRIVATE

Change delay of MID/PRIVATE_LOW_PRIO from 30 min to 2 hours (we had different datastores before using it, now its only real low prio stores)

Add comment to each enum
2020-10-03 12:48:23 -05:00
chimp1984
137b5e81d1
Enforce that clients set the priority. Remove the initialize methods which did not have priority as a param.
Make initializePersistenceManager in StorageService abstract to enforce in concrete class to define priority.

Change priorities for future renaming to a different meaning. instead of priority we want to describe the category: private data, public data,.... will come in next commit
2020-10-03 12:48:22 -05:00
chimp1984
b712445e34
Remove duplicate startApplication call. Remove checkCryptoSetup call and fields used only for that. 2020-10-03 12:48:22 -05:00
chimp1984
32238f2050
Rename getClosedTradables and getFailedTrades to getObservableList 2020-10-03 12:48:22 -05:00
chimp1984
c789650d0b
Move methods to base class 2020-10-03 12:48:22 -05:00
chimp1984
e88a810dd0
Revert exit code to 1 as it was before. Not sure if there have been some scripts for seeds which expect an error code at shutdown for auto restart. I remotely remember there have been something... 2020-10-03 12:48:22 -05:00
chimp1984
e242c54dab
Refactor: Rename getTradesAsObservableList to getObservableList 2020-10-03 12:48:22 -05:00
chimp1984
5f47ed20d8
Use decrementAndGet instead of getAndDecrement 2020-10-03 12:48:21 -05:00
chimp1984
ccfda5b043
Cleanups, add generics, add final, remove unused code/comments/todos, 2020-10-03 12:48:21 -05:00
chimp1984
fa0d261397
Fix remaining issues, cleanups, add persit calls, remove unused code,...
Sorry too tired to create another 20 commits...
2020-10-03 12:48:21 -05:00
chimp1984
253c6c3336
Remove unneeded param. Add requestPersistence calls. Cleanup removeTrade and addTrade methods 2020-10-03 12:48:21 -05:00
chimp1984
b901f358a7
Add missing persist calls. Add generics. Remove persist method. Add final. 2020-10-03 12:48:21 -05:00
chimp1984
7b4611e177
Add requestPersistence call
Cleanups
2020-10-03 12:48:21 -05:00