Commit Graph

12722 Commits

Author SHA1 Message Date
Oscar Guindzberg
e2f74f0250
Don't create a wallet address when not needed 2020-10-08 16:33:53 -03:00
Oscar Guindzberg
58afc00282
Don't create an extra address at startup 2020-10-08 16:33:53 -03:00
Oscar Guindzberg
1f3c585c35
Serialize tx without segwit
This is for backwards compatibility with bisq nodes that have not
upgraded to bitcoinj 0.15.
2020-10-08 16:33:52 -03:00
Oscar Guindzberg
f9f5d92941
Add segwit/legacy checbox for address creation 2020-10-08 16:33:52 -03:00
Oscar Guindzberg
a9cc28f65a
AddressEntryList: arbitrator entry use P2PKH 2020-10-08 16:33:52 -03:00
Oscar Guindzberg
a3708485f9
New AddressEntry: use different script types
Use P2WPKH for AVAILABLE context and P2PKH for the rest.
Disable reusing unused AVAILABLE entries until segwit support is
mandatory in Bisq.
2020-10-08 16:33:51 -03:00
Oscar Guindzberg
d8b755794e
WalletService: adapt to segwit wallet 2020-10-08 16:33:51 -03:00
Oscar Guindzberg
25515710ab
TradeWalletService: adapt to segwit wallet 2020-10-08 16:33:51 -03:00
Oscar Guindzberg
0f4c66f43d
Comment out segwit BSQ account path
Segwit is not used for BSQ
2020-10-08 16:33:50 -03:00
Oscar Guindzberg
0c7f3456b6
Fix log msg in BtcCoinSelector 2020-10-08 16:33:50 -03:00
Oscar Guindzberg
e85c66b810
Stop using LegacyAddress for btc addresses 2020-10-08 16:33:49 -03:00
Oscar Guindzberg
ced357ce25
AddressEntry: Add boolean segwit flag 2020-10-08 16:33:49 -03:00
Oscar Guindzberg
cd28660069
Add a P2WPKH keychain for existing wallets 2020-10-08 16:33:49 -03:00
Oscar Guindzberg
f13a7b164c
Create a P2WPKH keychain for new btc wallets 2020-10-08 16:33:48 -03:00
Christoph Atteneder
18a8a14114
Merge pull request #4605 from ghubstan/fix-test-assert
Fix register dipute agent test assert
2020-10-08 09:57:44 +02:00
Christoph Atteneder
2d06946c18
Update translations for v1.4.0 2020-10-08 09:41:42 +02:00
Christoph Atteneder
5294820eb6
Bump version number for v1.4.0 2020-10-08 09:39:01 +02:00
Christoph Atteneder
90d00a2c7f
Merge pull request #4603 from ncstdc/patch-2
Update displayStrings.properties for Mediation Popup
2020-10-08 09:30:45 +02:00
Christoph Atteneder
2af3668615
Merge pull request #4607 from chimp1984/dont-log-invalid-filter
Do not log full filter object in case of an invalid Filter
2020-10-08 09:30:01 +02:00
ghubstan
3a3f456fc9
Wrap Exception in gRPC StatusRuntimeException 2020-10-07 15:58:43 -03:00
Christoph Atteneder
992eee8fad
Merge pull request #4604 from cd2357/bump-netlayer-tor-browser-10.0
Bump netlayer to use tor binary from tor browser v10.0
2020-10-07 20:36:54 +02:00
ghubstan
29d1905f31
Add new 'getoffer offer-id' api method
There are a number of use cases where a user may want to see a single
offer instead of every offer for a currency pair on the buy or sell side.
The changes are:

- Add getoffer to grpc.proto
- Add new method to GrpcOffersService, CoreApi, CoreOffersService
- Add new method to CLI
- Adjust create offer tests to use this new convenience
2020-10-07 12:09:13 -03:00
chimp1984
076af0a3e1
Do not log full tiler object in case of an invalid Filter
Instead log signerPubKeyAsHex and creation date. We have currently the old filter still around (intended) so we get that log called and it would confuse ppl reading the log without knowing more about the context.
2020-10-07 09:42:01 -05:00
ghubstan
449a0b25bd
Delete redundant core.api.StatusCheck
We are migrating to the new core.app.AppStartupState class.
2020-10-07 11:28:46 -03:00
ghubstan
1a8f97afab
Fix register dipute agent test assert
This should have been included in commit 5f9b1e6, PR 4595.
2020-10-07 11:19:05 -03:00
sqrrm
723a1f5cf9
Merge pull request #4592 from chimp1984/improve-bisq-setup
Improve bisq setup
2020-10-07 14:08:10 +02:00
Christoph Atteneder
7d14ff37d8
Merge pull request #4595 from ghubstan/remove-duplicated-supporttype-enum
Remove redundant DisputeAgentType enum
2020-10-07 09:37:15 +02:00
Christoph Atteneder
66f6e49f83
Merge pull request #4596 from ghubstan/refactor-placeoffer-tx-handling
Simplify GrpcOffersService#createOffer (refactor)
2020-10-07 09:30:40 +02:00
Christoph Atteneder
d88583307f
Merge pull request #4602 from chimp1984/re-activate-confirm-buttons-again
Re activate confirm buttons again
2020-10-07 09:22:51 +02:00
chimp1984
7ecae0e5be
Set amounts before setting state, as the state triggers the check where the amount is needed 2020-10-06 11:30:44 -05:00
chimp1984
2d99ae7d09
Remove isDisputed checks 2020-10-06 11:04:20 -05:00
cd2357
6ef9368b75
Bump netlayer to use tor binary from tor browser v10.0
Upgrade netlayer to a version that uses tor binaries extracted from the latest tor-browser v10.0.
2020-10-06 18:03:59 +02:00
chimp1984
b4bd1df27f
Refactor: Move method 2020-10-06 10:45:19 -05:00
dchoe
39d37e1070
Update displayStrings.properties
Better wording
2020-10-06 10:44:09 -05:00
chimp1984
4a0fe3e62e
Move checks to enable confirm to Trade
Use it in view to disable button
2020-10-06 10:40:39 -05:00
chimp1984
f0606f9266
Refactor: Remove commented out code and comments 2020-10-06 10:26:11 -05:00
chimp1984
0e89c27021
Add mediationResultAppliedPenaltyToSeller method to Trade
Add util methods to DisputeState
Impl. paymentReceivedEnabled method for SellerProtocol
Impl. paymentStartedEnabled method for BuyerProtocol
Remove notDisputed method as not used anymore

Add final keywords
2020-10-06 10:22:22 -05:00
ghubstan
5f9b1e6e1a
Format exception message 2020-10-06 11:30:17 -03:00
ghubstan
30e6dae90b
Change return type to void
The prior Offer return type is redundant and confusing given the
new offer is passed up via the Consumer<Offer> resultHandler.
2020-10-06 11:19:08 -03:00
Christoph Atteneder
454b3a97d5
Merge pull request #4587 from wiz/update-tac-for-price-indices
Update text/URL in Terms and Conditions window for Bisq Price Indices
2020-10-06 10:10:21 +02:00
Christoph Atteneder
049b6209b7
Merge pull request #4594 from ghubstan/refactor-api-price-service
Tidy up CorePriceService (refactor)
2020-10-06 10:04:00 +02:00
Christoph Atteneder
be0946609e
Merge pull request #4597 from wiz/revert-mempool-back-to-medium-prio
Reduce mempool fee estimation back to "medium" priority
2020-10-06 09:56:03 +02:00
Christoph Atteneder
36bc15df2e
Merge pull request #4600 from chimp1984/avoid-illegal-reflective-access-operation-warning
Setting jvm option  `-Djdk.module.illegalAccess=deny`
2020-10-06 09:50:53 +02:00
chimp1984
be204c457d
Setting jvm option -Djdk.module.illegalAccess=deny avoids the warning logs at startup
Not sure how to add it to gradle so its set at normal compilation as well...

User get confused by the warning as it sounds somehow alerting.

`WARNING: An illegal reflective access operation has occurred
 WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/Users/dev/.gradle/caches/modules-2/files-2.1/com.google.inject/guice/4.2.2/6dacbe18e5eaa7f6c9c36db33b42e7985e94ce77/guice-4.2.2.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
 WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
 WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
 WARNING: All illegal access operations will be denied in a future release`
2020-10-06 00:19:50 -05:00
ghubstan
3f3f4f06f5
Use consumer::accept instead of a countdown latch
This is more readable and stylistically consistent.
2020-10-05 14:32:05 -03:00
ghubstan
2d34730bd8
Fix method name 2020-10-05 13:51:48 -03:00
wiz
894cdf3536
Reduce mempool fee estimation back to "medium" priority
Now that we've recently optimized the "medium" fee estimation algorithm
in mempool/mempool@15bb5a96, we can move Bisq back to "medium", since
always using "high" will be a bit wasteful on the weekends when the
mempool is empty.
2020-10-06 01:30:34 +09:00
ghubstan
dd67acc153
Simplify GrpcOffersService#createOffer (refactor)
Push the placeOffer call down into CoreOffersService#createOffer,
and use a countdown latch to wait for async placeOffer to
complete.
2020-10-05 12:23:54 -03:00
chimp1984
474c4138d2
Refactor: rearrange methods 2020-10-04 17:24:03 -05:00
chimp1984
52f5f2f064
Extract domain initialisation to domainInitialisation class 2020-10-04 17:24:03 -05:00