Commit graph

11857 commits

Author SHA1 Message Date
sqrrm
4d32da7289
Merge pull request #4420 from stejbac/fix-blank-offer-book-price-cells
Fix intermittent blank price cells in offer book view
2020-08-31 19:02:19 +02:00
sqrrm
c551adb441
Merge pull request #4436 from chimp1984/bundle-msg-at-broadcast
Bundle messages at broadcast
2020-08-31 18:01:14 +02:00
chimp1984
e2de5221bf
Fix + prefix in string keys 2020-08-31 10:51:21 -05:00
chimp1984
f7951d5943
Combine if/else branches. Improve comments and variables 2020-08-31 10:38:46 -05:00
chimp1984
bc802c861d
Change log level to avoid too verbose logs 2020-08-31 10:37:58 -05:00
chimp1984
5555c43ea9
Merge branch 'master_upstream' into refactor-filter 2020-08-31 10:15:42 -05:00
chimp1984
591011e516
Add comment 2020-08-31 09:51:53 -05:00
chimp1984
59ebefc7d9
Revert to use empty string as default for accountId instead of null.
Prefer to keep old functionality here...
2020-08-31 09:47:35 -05:00
sqrrm
136da0c481
Merge pull request #4443 from ghubstan/upgrade-jfoenix
Upgrade JFoenix to v9.0.10
2020-08-31 16:41:47 +02:00
sqrrm
8c6b525553
Merge pull request #4433 from ghubstan/5-add-remote-debug-option
Allow remote debugging of background Bisq apps
2020-08-31 16:39:33 +02:00
sqrrm
51d1441dcc
Merge pull request #4432 from ghubstan/4-remove-redundant-options
Remove redundant ApiTestConfig options
2020-08-31 16:37:13 +02:00
sqrrm
f8a8904cd6
Merge pull request #4431 from ghubstan/3-remove-dupllicated-grpcstubs
Remove duplicated grpc stub creation logic
2020-08-31 16:34:53 +02:00
sqrrm
00cc9a1f7d
Merge pull request #4430 from ghubstan/2-mv-bats-test
Move bats based mainnet test from :cli to :apitest
2020-08-31 16:24:12 +02:00
sqrrm
de56c1efb9
Merge pull request #4429 from ghubstan/1-add-setup-scaffold-param
Fix setUpScaffold() signature
2020-08-31 16:21:27 +02:00
sqrrm
944825e24b
Close other tab when opening signing tab 2020-08-31 16:18:03 +02:00
sqrrm
51908fcb2a
Use mediation cases to popupate arbitrator signing in dev mode 2020-08-31 15:26:44 +02:00
sqrrm
91e30de637
Make a separate signing tab
Helps dev work to have a separate signing area without need for legacy
arbitrator registration. Legacy arbitrator key is still needed to sign
accounts. Account information is also needed.
2020-08-31 14:40:57 +02:00
chimp1984
e9e7b489be
Various refactorings, bug fixes and improvements.
Sorry for the messy commit... its late ;-)
2020-08-31 00:10:41 -05:00
chimp1984
4f0e574bf9
Use static field for dev test values 2020-08-30 21:38:32 -05:00
chimp1984
2967530878
Max amount was set to 0.1 BTC, should be 1 BTC 2020-08-30 21:37:17 -05:00
chimp1984
aab478a63c
Refactor:
- Rename XmrAutoConfirmationManager to XmrTxProofService
2020-08-30 19:38:29 -05:00
chimp1984
f3ad669fab
Refactor:
- Rename XmrTransferProofService to XmrTxProofRequestService
2020-08-30 19:38:05 -05:00
chimp1984
0e2268d6fe
Refactor:
- Rename XmrTransferProofRequest to XmrTxProofRequest
2020-08-30 19:37:43 -05:00
chimp1984
a758880211
Refactor:
- Rename XmrProofInfo to XmrTxProofModel
2020-08-30 19:37:22 -05:00
chimp1984
87070531dd
Refactor:
- Rename XmrProofParser to XmrTxProofParser (and rename test)
2020-08-30 19:36:54 -05:00
chimp1984
44782223ec
Refactor:
- Rename XmrAutoConfirmResult to XmrTxProofResult
2020-08-30 19:35:56 -05:00
chimp1984
f8b5c30fb4
Refactor:
- Rename AutoConfirmResult to AssetTxProofResult
- Update protobuf entry
2020-08-30 19:35:26 -05:00
chimp1984
40a7320f32
Refactor:
- Rename XmrTransferProofRequester to XmrTransferProofRequest
2020-08-30 19:25:02 -05:00
chimp1984
6f56f90a66
Refactor:
- Rename processCounterCurrencyExtraData to startRequestTxProofProcess
- Change activeTrades from Stream to List
2020-08-30 19:23:41 -05:00
chimp1984
0740f8d12b
Remove @nullable from socks5ProxyProvider param
Remove @Inject from XmrTxProofHttpClient as we pass the
Socks5ProxyProvider anyway
2020-08-30 19:15:32 -05:00
chimp1984
ef9ac12519
Refactoring:
-Reduce visibility
2020-08-30 19:09:04 -05:00
chimp1984
b76357e620
Refactoring:
Change test package from bisq.core.trade.asset.xmr to bisq.core.trade.autoconf.xmr
2020-08-30 19:07:04 -05:00
chimp1984
213dffbef9
Refactoring:
- Rename getKey to getUID
- Rename key to uid
2020-08-30 19:05:18 -05:00
chimp1984
c6c8a3e5cb
Refactoring:
- Move xmrProofInfo.checkApiResponse to XmrProofParser.parse
2020-08-30 19:03:37 -05:00
chimp1984
38ac145213
Add devMode check for NO_MATCH case.
Inline method
2020-08-30 17:56:44 -05:00
chimp1984
867e023e87
Merge branch 'master_upstream' into add-xmr-tx-key-service-3 2020-08-30 17:02:15 -05:00
chimp1984
2a887e1f01
Improve SetXmrTxKeyWindow 2020-08-30 17:01:21 -05:00
chimp1984
94c84b6f50
Add @Override, cleanup 2020-08-30 16:47:39 -05:00
chimp1984
2fb625642a
Refactoring: Rename getTextStatus to getStatusAsDisplayString 2020-08-30 16:45:46 -05:00
chimp1984
595c968f2d
Various small cleanups... 2020-08-30 16:44:45 -05:00
chimp1984
67723fa1a7
Do not pass over xmrAutoConfirmationManager to ProcessModel but use a
getter from tradeManager. Avoids boilerplate code (I know there is more
in the existing code to optimize here ;-))
2020-08-30 16:43:32 -05:00
chimp1984
219094e9d1
Merge branch 'add-xmr-tx-key-service-2' into add-xmr-tx-key-service-3 2020-08-30 16:11:12 -05:00
chimp1984
77c203e87e
No functional change, pure refactoring
Move to convertToRawHex CryptoNoteUtils as well as the classes inside
the validator.
2020-08-30 16:08:07 -05:00
chimp1984
5143b1ed59
Apply suggested changes from code analysis 2020-08-30 15:56:44 -05:00
chimp1984
bfab6ffc2e
Replace success/failure with booleans 2020-08-30 15:51:43 -05:00
chimp1984
e5aee1ca07
No functionality has been changed by that refactoring, just moved
classes and renamed package and adjusted access modifiers.
2020-08-30 15:50:15 -05:00
chimp1984
ed5078c0f1
Add abstract AutoConfirmResult class to get better support if we want
to add auto confirm for other currencies in the future. The generic part
is only used where we would have issues with backward compatibility like
in the protobuf objects. Most of the current classes are kept XMR
specific and could be generalized once we add other assets, but that
would be an internal refactoring without breaking any network or
storage data. I think it would be premature to go further here as we
don't know the details of other use cases. I added the methods used from
clients to AutoConfirmResult, not sure if the API is well defined by
that, but as said that could become subject of a future refactoring once
another auto confirm feature gets added. Goal of that refactoring was
to avoid that we need more fields for trade and the the UI would have to
deal with lots of switch cases based on currency.

Sorry that is a larger commit, would have been hard to break up...
2020-08-30 15:45:47 -05:00
chimp1984
2f1566bb06
Add NO_MATCH_FOUND in comment 2020-08-30 14:48:15 -05:00
chimp1984
2f7b24d1c8
- Add @Nullable
- Add curly brackets to one liners
- Log improvements
2020-08-30 14:46:04 -05:00
chimp1984
07a761255d
- Make REPEAT_REQUEST_PERIOD and MAX_REQUEST_PERIOD static
- Replace httpClient.toString() with httpClient.getBaseUrl() as toString
would deliver too much for those use cases.
- Add @Nullable
- Log improvements
2020-08-30 14:45:05 -05:00