Commit graph

4576 commits

Author SHA1 Message Date
sqrrm
7830dbf4e4
Merge pull request #4460 from chimp1984/refactor-filter
Refactor filter
2020-09-01 19:48:38 +02:00
chimp1984
3b4e183633
Use tradeId for prefix for id of request.
Remove testKey test (tested uid of model)

Refactor:
- Rename uid to id (we do not have a strict guarantee for uniqueness)
- Move id from model to request (its the id of the request)
2020-09-01 11:18:09 -05:00
chimp1984
6cc074a15c
Add default clause (codacy complaint) 2020-09-01 10:44:50 -05:00
ghubstan
1efb8c8bee
Make CoreApi a singleton 2020-09-01 10:49:37 -03:00
sqrrm
43ad831916
Merge pull request #4451 from chimp1984/add-check-for-option-trade
Add check for option trade
2020-09-01 11:12:59 +02:00
chimp1984
d36306a73c
More refactoring.... 2020-09-01 00:56:54 -05:00
chimp1984
7b3dc54815
dont use restart routing for seed nodes if in devmode 2020-08-31 19:29:56 -05:00
chimp1984
86999e52d1
- Remove isPublicKeyInList check at remove as its irrelevant (dev could
add his key anyway to src code)
- Fix wrong logs
- Remove duplicated line
2020-08-31 17:13:09 -05:00
chimp1984
12ef5aafe0
Update comment 2020-08-31 16:25:07 -05:00
chimp1984
8bf75b5f45
- Filter out prices with code "NON_EXISTING_SYMBOL"
- Add comments
2020-08-31 15:19:31 -05:00
chimp1984
b409c8add5
Merge branch 'master_upstream' into add-tether-pinguin 2020-08-31 14:17:59 -05:00
chimp1984
334cb43c3b
Rename verifySignature to isSignatureValid 2020-08-31 13:53:17 -05:00
chimp1984
c755fc2592
Add isPrivilegedDevPubKeyBanned method
It is used atm only for filter itself which might have limited effect.
Applying it to alert and priv notification requires adding pubKey fields
there which is outside of the scope of that PR but should be added soon
as well.
2020-08-31 13:51:41 -05:00
chimp1984
5209018f4d
Add pub key 2020-08-31 13:24:02 -05:00
chimp1984
78142bda7d
Fix tests 2020-08-31 13:23:51 -05:00
chimp1984
4a2f7dc92c
Rename bannedSignerPubKeys to bannedAccountWitnessSignerPubKeys
We use several signing keys, so better to make it more explicit.
protobuf entry is not changed to not risk issues (i guess it would
work renaming it)
2020-08-31 13:01:44 -05:00
chimp1984
9a142be86e
Add bannedPrivilegedDevPubKeys field 2020-08-31 12:51:01 -05:00
chimp1984
1b5e449114
Remove dev test code 2020-08-31 12:34:16 -05:00
chimp1984
cc20a3b6c7
- Add support for multiple pubKeys
- Add more validation
- Add SignerPubKeyAsHex to filter
- Refactor add/remove filter code
2020-08-31 12:33:45 -05:00
chimp1984
e2de5221bf
Fix + prefix in string keys 2020-08-31 10:51:21 -05:00
chimp1984
5555c43ea9
Merge branch 'master_upstream' into refactor-filter 2020-08-31 10:15:42 -05:00
chimp1984
59ebefc7d9
Revert to use empty string as default for accountId instead of null.
Prefer to keep old functionality here...
2020-08-31 09:47:35 -05:00
sqrrm
91e30de637
Make a separate signing tab
Helps dev work to have a separate signing area without need for legacy
arbitrator registration. Legacy arbitrator key is still needed to sign
accounts. Account information is also needed.
2020-08-31 14:40:57 +02:00
chimp1984
e9e7b489be
Various refactorings, bug fixes and improvements.
Sorry for the messy commit... its late ;-)
2020-08-31 00:10:41 -05:00
chimp1984
4f0e574bf9
Use static field for dev test values 2020-08-30 21:38:32 -05:00
chimp1984
2967530878
Max amount was set to 0.1 BTC, should be 1 BTC 2020-08-30 21:37:17 -05:00
chimp1984
aab478a63c
Refactor:
- Rename XmrAutoConfirmationManager to XmrTxProofService
2020-08-30 19:38:29 -05:00
chimp1984
f3ad669fab
Refactor:
- Rename XmrTransferProofService to XmrTxProofRequestService
2020-08-30 19:38:05 -05:00
chimp1984
0e2268d6fe
Refactor:
- Rename XmrTransferProofRequest to XmrTxProofRequest
2020-08-30 19:37:43 -05:00
chimp1984
a758880211
Refactor:
- Rename XmrProofInfo to XmrTxProofModel
2020-08-30 19:37:22 -05:00
chimp1984
87070531dd
Refactor:
- Rename XmrProofParser to XmrTxProofParser (and rename test)
2020-08-30 19:36:54 -05:00
chimp1984
44782223ec
Refactor:
- Rename XmrAutoConfirmResult to XmrTxProofResult
2020-08-30 19:35:56 -05:00
chimp1984
f8b5c30fb4
Refactor:
- Rename AutoConfirmResult to AssetTxProofResult
- Update protobuf entry
2020-08-30 19:35:26 -05:00
chimp1984
40a7320f32
Refactor:
- Rename XmrTransferProofRequester to XmrTransferProofRequest
2020-08-30 19:25:02 -05:00
chimp1984
6f56f90a66
Refactor:
- Rename processCounterCurrencyExtraData to startRequestTxProofProcess
- Change activeTrades from Stream to List
2020-08-30 19:23:41 -05:00
chimp1984
0740f8d12b
Remove @nullable from socks5ProxyProvider param
Remove @Inject from XmrTxProofHttpClient as we pass the
Socks5ProxyProvider anyway
2020-08-30 19:15:32 -05:00
chimp1984
ef9ac12519
Refactoring:
-Reduce visibility
2020-08-30 19:09:04 -05:00
chimp1984
b76357e620
Refactoring:
Change test package from bisq.core.trade.asset.xmr to bisq.core.trade.autoconf.xmr
2020-08-30 19:07:04 -05:00
chimp1984
213dffbef9
Refactoring:
- Rename getKey to getUID
- Rename key to uid
2020-08-30 19:05:18 -05:00
chimp1984
c6c8a3e5cb
Refactoring:
- Move xmrProofInfo.checkApiResponse to XmrProofParser.parse
2020-08-30 19:03:37 -05:00
chimp1984
38ac145213
Add devMode check for NO_MATCH case.
Inline method
2020-08-30 17:56:44 -05:00
chimp1984
2a887e1f01
Improve SetXmrTxKeyWindow 2020-08-30 17:01:21 -05:00
chimp1984
94c84b6f50
Add @Override, cleanup 2020-08-30 16:47:39 -05:00
chimp1984
2fb625642a
Refactoring: Rename getTextStatus to getStatusAsDisplayString 2020-08-30 16:45:46 -05:00
chimp1984
595c968f2d
Various small cleanups... 2020-08-30 16:44:45 -05:00
chimp1984
67723fa1a7
Do not pass over xmrAutoConfirmationManager to ProcessModel but use a
getter from tradeManager. Avoids boilerplate code (I know there is more
in the existing code to optimize here ;-))
2020-08-30 16:43:32 -05:00
chimp1984
219094e9d1
Merge branch 'add-xmr-tx-key-service-2' into add-xmr-tx-key-service-3 2020-08-30 16:11:12 -05:00
chimp1984
77c203e87e
No functional change, pure refactoring
Move to convertToRawHex CryptoNoteUtils as well as the classes inside
the validator.
2020-08-30 16:08:07 -05:00
chimp1984
5143b1ed59
Apply suggested changes from code analysis 2020-08-30 15:56:44 -05:00
chimp1984
bfab6ffc2e
Replace success/failure with booleans 2020-08-30 15:51:43 -05:00