mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-02-23 15:00:30 +01:00
Code Issues Projects Releases Packages Wiki Activity

Avoid repeated Set<Tradable> build in transactions view load

Browse source 
Move the line,

   Set<Tradable> tradables = tradableRepository.getAll();

to the top level of 'TransactionsView.updateList', instead of needlessly
calling 'TradableRepository.getAll' (which builds a new set every
invocation) for each wallet transaction being iterated over.

This was causing a significant slowdown of the view load.
This commit is contained in:
Steven Barclay 2023-02-09 21:35:32 +08:00
parent 3aacc99f38
commit fb78345ba3
No known key found for this signature in database
GPG key ID: 9FED6BF1176D500B
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsView.java
View file

@ -288,11 +288,11 @@ public class TransactionsView extends ActivatableView<VBox, Void> {
}
private void updateList() {
Set<Tradable> tradables = tradableRepository.getAll();
List<TransactionsListItem> transactionsListItems = btcWalletService.getTransactions(false)
.stream()
.map(transaction -> {
Set<Tradable> tradables = tradableRepository.getAll();
TransactionAwareTradable maybeTradable = tradables.stream()
.map(tradable -> {
if (tradable instanceof OpenOffer) {