Fix codacy comment

This commit is contained in:
sqrrm 2020-02-07 01:08:20 +01:00 committed by Christoph Atteneder
parent bc654f439c
commit fab37f9f01
No known key found for this signature in database
GPG key ID: CD5DC1C529CDFD3B

View file

@ -764,13 +764,14 @@ public class AccountAgeWitnessService {
checkNotNull(trade.getContract().getBuyerPaymentAccountPayload()); checkNotNull(trade.getContract().getBuyerPaymentAccountPayload());
boolean checkingSignTrade = true; boolean checkingSignTrade = true;
boolean isBuyer = trade.getContract().isMyRoleBuyer(keyRing.getPubKeyRing()); boolean isBuyer = trade.getContract().isMyRoleBuyer(keyRing.getPubKeyRing());
if (myWitness == null) { AccountAgeWitness witness = myWitness;
myWitness = isBuyer ? if (witness == null) {
witness = isBuyer ?
getMyWitness(trade.getContract().getBuyerPaymentAccountPayload()) : getMyWitness(trade.getContract().getBuyerPaymentAccountPayload()) :
getMyWitness(trade.getContract().getSellerPaymentAccountPayload()); getMyWitness(trade.getContract().getSellerPaymentAccountPayload());
checkingSignTrade = false; checkingSignTrade = false;
} }
boolean isSignWitnessTrade = accountIsSigner(myWitness) && boolean isSignWitnessTrade = accountIsSigner(witness) &&
!peerHasSignedWitness(trade) && !peerHasSignedWitness(trade) &&
tradeAmountIsSufficient(trade.getTradeAmount()); tradeAmountIsSufficient(trade.getTradeAmount());
log.info("AccountSigning: " + log.info("AccountSigning: " +
@ -791,7 +792,7 @@ public class AccountAgeWitnessService {
getWitnessDebugLog(trade.getContract().getSellerPaymentAccountPayload(), getWitnessDebugLog(trade.getContract().getSellerPaymentAccountPayload(),
trade.getContract().getSellerPubKeyRing()), trade.getContract().getSellerPubKeyRing()),
checkingSignTrade, // Following cases added to use same logic as in seller signing check checkingSignTrade, // Following cases added to use same logic as in seller signing check
accountIsSigner(myWitness), accountIsSigner(witness),
peerHasSignedWitness(trade), peerHasSignedWitness(trade),
trade.getTradeAmount(), trade.getTradeAmount(),
tradeAmountIsSufficient(trade.getTradeAmount()), tradeAmountIsSufficient(trade.getTradeAmount()),