mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-02-24 23:18:17 +01:00
Code Issues Projects Releases Packages Wiki Activity

Add null checks, improve comment

Browse source
This commit is contained in:
chimp1984 2020-12-15 19:08:37 -05:00
parent 0f084d3aec
commit ecad724046
No known key found for this signature in database
GPG key ID: 9801B4EC591F90E3
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/src/main/java/bisq/core/locale/CurrencyUtil.java
View file

@ -64,8 +64,8 @@ public class CurrencyUtil {
// Calls to isFiatCurrency and isCryptoCurrency are very frequent so we use a cache of the results. // Calls to isFiatCurrency and isCryptoCurrency are very frequent so we use a cache of the results.
// The main improvement was already achieved with using memoize for the source maps, but // The main improvement was already achieved with using memoize for the source maps, but
// the caching still improves performance by about 20% for isCryptoCurrency and about 100% // the caching still reduces performance costs by about 20% for isCryptoCurrency (1752 ms vs 2121 ms) and about 50%
// for isFiatCurrency calls. // for isFiatCurrency calls (1777 ms vs 3467 ms).
// See: https://github.com/bisq-network/bisq/pull/4955#issuecomment-745302802 // See: https://github.com/bisq-network/bisq/pull/4955#issuecomment-745302802
private static final Map<String, Boolean> isFiatCurrencyMap = new ConcurrentHashMap<>(); private static final Map<String, Boolean> isFiatCurrencyMap = new ConcurrentHashMap<>();
private static final Map<String, Boolean> isCryptoCurrencyMap = new ConcurrentHashMap<>(); private static final Map<String, Boolean> isCryptoCurrencyMap = new ConcurrentHashMap<>();
@ -399,7 +399,7 @@ public class CurrencyUtil {
} }
public static boolean isFiatCurrency(String currencyCode) { public static boolean isFiatCurrency(String currencyCode) {
if (isFiatCurrencyMap.containsKey(currencyCode)) { if (currencyCode != null && isFiatCurrencyMap.containsKey(currencyCode)) {
return isFiatCurrencyMap.get(currencyCode); return isFiatCurrencyMap.get(currencyCode);
} }
@ -438,7 +438,7 @@ public class CurrencyUtil {
* contains 3 entries (CryptoCurrency, Fiat, Undefined). * contains 3 entries (CryptoCurrency, Fiat, Undefined).
*/ */
public static boolean isCryptoCurrency(String currencyCode) { public static boolean isCryptoCurrency(String currencyCode) {
if (isCryptoCurrencyMap.containsKey(currencyCode)) { if (currencyCode != null && isCryptoCurrencyMap.containsKey(currencyCode)) {
return isCryptoCurrencyMap.get(currencyCode); return isCryptoCurrencyMap.get(currencyCode);
} }