Dont remove listener on fault

This commit is contained in:
Manfred Karrer 2016-05-25 15:53:29 +02:00
parent 148278a959
commit ea76c0577e
3 changed files with 14 additions and 9 deletions

View File

@ -6,7 +6,7 @@ import org.slf4j.LoggerFactory;
public class DevFlags {
private static final Logger log = LoggerFactory.getLogger(DevFlags.class);
public static final boolean STRESS_TEST_MODE = true;
public static final boolean STRESS_TEST_MODE = false;
public static final boolean DEV_MODE = STRESS_TEST_MODE || false;
public static final boolean IS_RELEASE_VERSION = !DEV_MODE && true;

View File

@ -60,9 +60,8 @@ public abstract class TradeProtocol {
TradeMessage tradeMessage = (TradeMessage) message;
nonEmptyStringOf(tradeMessage.tradeId);
if (tradeMessage.tradeId.equals(processModel.getId())) {
if (tradeMessage.tradeId.equals(processModel.getId()))
doHandleDecryptedMessage(tradeMessage, peersNodeAddress);
}
}
} else {
//TODO not clear anymore what case is handled here
@ -82,14 +81,14 @@ public abstract class TradeProtocol {
public void completed() {
cleanup();
processModel.getP2PService().removeDecryptedDirectMessageListener(decryptedDirectMessageListener);
}
private void cleanup() {
log.debug("cleanup " + this);
stopTimeout();
processModel.getP2PService().removeDecryptedDirectMessageListener(decryptedDirectMessageListener);
// Don't remove removeDecryptedDirectMessageListener as it might be a non critical bug and it would prevent
// that we get further messages
}
public void applyMailboxMessage(DecryptedMsgWithPubKey decryptedMsgWithPubKey, Trade trade) {

View File

@ -225,9 +225,8 @@ public abstract class TradeStepView extends AnchorPane {
}
private void showDisputeInfoLabel() {
if (notificationGroup != null) {
if (notificationGroup != null)
notificationGroup.setLabelAndHeadlineVisible(true);
}
}
private void showOpenDisputeButton() {
@ -308,6 +307,10 @@ public abstract class TradeStepView extends AnchorPane {
notificationGroup.label.setText(getWarningText());
}
private void removeWarning() {
hideNotificationGroup();
}
protected String getWarningText() {
return "";
}
@ -402,7 +405,10 @@ public abstract class TradeStepView extends AnchorPane {
case NORMAL:
break;
case HALF_REACHED:
showWarning();
if (trade.getState().getPhase().ordinal() < Trade.Phase.FIAT_RECEIVED.ordinal())
showWarning();
else
removeWarning();
break;
case TRADE_PERIOD_OVER:
onOpenForDispute();