mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-02-22 22:45:21 +01:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #3250 from chimp1984/remove-required-capability

Browse source 
Remove CapabilityRequiringPayload from NewBlockBroadcastMessage
This commit is contained in:
Christoph Atteneder 2019-09-13 09:26:51 +02:00 • committed by GitHub
commit e84fffb13b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
core/src/main/java/bisq/core/dao/node/messages/NewBlockBroadcastMessage.java
View file

@ -20,20 +20,21 @@ package bisq.core.dao.node.messages;
import bisq.core.dao.node.full.RawBlock; import bisq.core.dao.node.full.RawBlock;
import bisq.network.p2p.storage.messages.BroadcastMessage; import bisq.network.p2p.storage.messages.BroadcastMessage;
import bisq.network.p2p.storage.payload.CapabilityRequiringPayload;
import bisq.common.app.Capabilities;
import bisq.common.app.Capability;
import bisq.common.app.Version; import bisq.common.app.Version;
import bisq.common.proto.network.NetworkEnvelope; import bisq.common.proto.network.NetworkEnvelope;
import lombok.EqualsAndHashCode; import lombok.EqualsAndHashCode;
import lombok.Getter; import lombok.Getter;
// We remove the CapabilityRequiringPayload interface to avoid risks that new BSQ blocks are not well distributed in
// case the capability is not exchanged at the time when the message is sent. We need to improve the capability handling
// so that we can be sure that we know the actual capability of the peer.
// This message is sent only to lite DAO nodes (full nodes get block from their local bitcoind) // This message is sent only to lite DAO nodes (full nodes get block from their local bitcoind)
@EqualsAndHashCode(callSuper = true) @EqualsAndHashCode(callSuper = true)
@Getter @Getter
public final class NewBlockBroadcastMessage extends BroadcastMessage implements CapabilityRequiringPayload { public final class NewBlockBroadcastMessage extends BroadcastMessage /*implements CapabilityRequiringPayload*/ {
private final RawBlock block; private final RawBlock block;
public NewBlockBroadcastMessage(RawBlock block) { public NewBlockBroadcastMessage(RawBlock block) {
@ -63,8 +64,8 @@ public final class NewBlockBroadcastMessage extends BroadcastMessage implements
messageVersion); messageVersion);
} }
@Override // @Override
public Capabilities getRequiredCapabilities() { // public Capabilities getRequiredCapabilities() {
return new Capabilities(Capability.RECEIVE_BSQ_BLOCK); // return new Capabilities(Capability.RECEIVE_BSQ_BLOCK);
} // }
} }