From e55594d1e37a273166a32265ecdbec46c36962ee Mon Sep 17 00:00:00 2001 From: cd2357 Date: Wed, 16 Sep 2020 11:35:33 +0200 Subject: [PATCH] Fix FeeReceiverSelectorTest Split test into sub-tests in order to avoid mockito UnnecessaryStubbingExceptions. These exceptions occurred because of 3 ambiguous uses of "when().thenReturn()" in the same test. These calls were ambiguous, because the when() argument was identical and mockito did not check the thenReturn() arguments, which would have differentiated the calls. Splitting this test method into 4 test methods achieved this call differentiation. --- .../bisq/core/util/FeeReceiverSelectorTest.java | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/core/src/test/java/bisq/core/util/FeeReceiverSelectorTest.java b/core/src/test/java/bisq/core/util/FeeReceiverSelectorTest.java index ce2f3f6f83..bf6ddc5a8b 100644 --- a/core/src/test/java/bisq/core/util/FeeReceiverSelectorTest.java +++ b/core/src/test/java/bisq/core/util/FeeReceiverSelectorTest.java @@ -67,17 +67,32 @@ public class FeeReceiverSelectorTest { } @Test - public void testGetAddress_noValidReceivers() { + public void testGetAddress_noValidReceivers_nullFilter() { when(daoFacade.getParamValue(Param.RECIPIENT_BTC_ADDRESS)).thenReturn("default"); when(filterManager.getFilter()).thenReturn(null); assertEquals("default", FeeReceiverSelector.getAddress(daoFacade, filterManager)); + } + + @Test + public void testGetAddress_noValidReceivers_filterWithNullList() { + when(daoFacade.getParamValue(Param.RECIPIENT_BTC_ADDRESS)).thenReturn("default"); when(filterManager.getFilter()).thenReturn(filterWithReceivers(null)); assertEquals("default", FeeReceiverSelector.getAddress(daoFacade, filterManager)); + } + + @Test + public void testGetAddress_noValidReceivers_filterWithEmptyList() { + when(daoFacade.getParamValue(Param.RECIPIENT_BTC_ADDRESS)).thenReturn("default"); when(filterManager.getFilter()).thenReturn(filterWithReceivers(List.of())); assertEquals("default", FeeReceiverSelector.getAddress(daoFacade, filterManager)); + } + + @Test + public void testGetAddress_noValidReceivers_filterWithIllFormedList() { + when(daoFacade.getParamValue(Param.RECIPIENT_BTC_ADDRESS)).thenReturn("default"); when(filterManager.getFilter()).thenReturn(filterWithReceivers(List.of("ill-formed"))); assertEquals("default", FeeReceiverSelector.getAddress(daoFacade, filterManager));