mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-02-22 22:45:21 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove delay form UserThread.execute

Browse source 
For tradeStateListener that would cause a wrong state as we would get
called after we have completed and do the isPayoutPublished check.
Keeping it in sync does remove the listener before we complete the
trade.

For autoConfirmSettings it would probably not cause and issue but as
we use a CopyOnWriteArrayList there the remove is safe anyway (to not
cause a ConcurrentListModification exception).
This commit is contained in:
chimp1984 2020-09-02 11:16:06 -05:00
parent 37241f98d8
commit d725590a9c
No known key found for this signature in database
GPG key ID: 9801B4EC591F90E3
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofRequestsPerTrade.java
View file

@ -25,7 +25,6 @@ import bisq.core.user.AutoConfirmSettings;
import bisq.network.Socks5ProxyProvider;
import bisq.common.UserThread;
import bisq.common.handlers.FaultHandler;
import org.bitcoinj.core.Coin;
@ -182,10 +181,10 @@ class XmrTxProofRequestsPerTrade implements AssetTxProofRequestsPerTrade {
requests.forEach(XmrTxProofRequest::terminate);
requests.clear();
if (tradeStateListener != null) {
UserThread.execute(() -> trade.stateProperty().removeListener(tradeStateListener));
trade.stateProperty().removeListener(tradeStateListener);
}
if (autoConfirmSettingsListener != null) {
UserThread.execute(() -> autoConfirmSettings.removeListener(autoConfirmSettingsListener));
autoConfirmSettings.removeListener(autoConfirmSettingsListener);
}
}