mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 18:03:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5234 from BtcContributor/hidebankid

Browse Source 
Fix BankId leak
This commit is contained in:
Christoph Atteneder 2021-04-13 10:57:51 +02:00 committed by GitHub
commit c951dc2288
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/main/resources/i18n/displayStrings.properties
View File

@ -2655,8 +2655,6 @@ offerDetailsWindow.minBtcAmount=Min. BTC amount
offerDetailsWindow.min=(min. {0})
offerDetailsWindow.distance=(distance from market price: {0})
offerDetailsWindow.myTradingAccount=My trading account
offerDetailsWindow.offererBankId=(maker's bank ID/BIC/SWIFT)
offerDetailsWindow.offerersBankName=(maker's bank name)
offerDetailsWindow.bankId=Bank ID (e.g. BIC or SWIFT)
offerDetailsWindow.countryBank=Maker's country of bank
offerDetailsWindow.commitment=Commitment

17
desktop/src/main/java/bisq/desktop/main/overlays/windows/OfferDetailsWindow.java
View File

@ -253,25 +253,8 @@ public class OfferDetailsWindow extends Overlay<OfferDetailsWindow> {
addConfirmationLabelLabel(gridPane, ++rowIndex, Res.get("offerDetailsWindow.myTradingAccount"), myPaymentAccount.getAccountName());
} else {
final String method = Res.get(paymentMethod.getId());
String methodWithBankId = method + bankId;
String paymentMethodLabel = Res.get("shared.paymentMethod");
if (countryCode != null && (isNationalBanks || isSpecificBanks || isSepa)) {
if (BankUtil.isBankIdRequired(countryCode))
addConfirmationLabelLabel(gridPane, ++rowIndex,
paymentMethodLabel + " " + Res.get("offerDetailsWindow.offererBankId"),
methodWithBankId);
else if (BankUtil.isBankNameRequired(countryCode))
addConfirmationLabelLabel(gridPane, ++rowIndex,
paymentMethodLabel + " " + Res.get("offerDetailsWindow.offerersBankName"),
methodWithBankId);
} else if (paymentMethod.equals(PaymentMethod.CASH_DEPOSIT)) {
addConfirmationLabelLabel(gridPane, ++rowIndex,
paymentMethodLabel + " " + Res.get("offerDetailsWindow.offererBankId"),
methodWithBankId);
} else {
addConfirmationLabelLabel(gridPane, ++rowIndex, Res.get("shared.paymentMethod"), method);
}
}
if (showXmrAutoConf) {
String isAutoConf = offer.isXmrAutoConf() ?