mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-02-24 15:10:44 +01:00
Code Issues Projects Releases Packages Wiki Activity

Merge branch 'master' into Development

Browse source
This commit is contained in:
Manfred Karrer 2017-12-07 12:32:41 -05:00
commit bec01232a0
No known key found for this signature in database
GPG key ID: 401250966A6B2C46
2 changed files with 17 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
doc/ui-development-notes.md
View file

@ -11,17 +11,17 @@ That interpretation is also confirmed by the Java FX reference: "A controller is
The described pattern is only applied yet to that package:
io.bisq.gui.trade.createoffer;
io.bisq.gui.main.offer.createoffer;
For prototyping the UI we stick first with a more rapid development style approach.
###Elements
### Elements
* View
* CodeBehind (CB)
* Presentation Model (PM)
* Model
#####Overview:
##### Overview:
* View/CB is responsible for the visual representation. No logic. No state.
* Presentation model holds the view/CB state.
* Presentation model handles view specific logic.
@ -29,12 +29,12 @@ For prototyping the UI we stick first with a more rapid development style approa
* Model is the domain specific representation of the view. It holds domain data and handles domain logic.
###View
### View
Typically FXML is used.
It knows the CodeBehind (fx:controller)
#####Responsibility:
##### Responsibility:
* Defines visible parts of the UI
* Define UI element properties
* Layout
@ -42,7 +42,7 @@ It knows the CodeBehind (fx:controller)
* Event handler definition
###CodeBehind (CB)
### CodeBehind (CB)
It is conceptually part of the view layer. It adds functionality which cannot be expressed in the declarative FXML
format.
It is the JavaFX controller associated with the FXML view, but we don't use the term controller as it has too much
@ -51,7 +51,7 @@ setup with the FXML view is done by the framework.
It knows the presentation model (via Guice injection) but not the model.
#####Responsibility:
##### Responsibility:
* Setup binding for updates from PM to view elements (also bidirectional for used for input data).
* Those binding are only simple bindings to plain presenter properties, no logical bindings.
* Listens to UI events (Actions) from UI controls and calls method in presentation model.
@ -62,13 +62,13 @@ It knows the presentation model (via Guice injection) but not the model.
* Has **no logic** and **no state**!
###Presentation model (PM)
### Presentation model (PM)
It is the abstraction/presentation of the view.
Can be used for unit testing.
It knows the model (via Guice injection) but it does not know the CodeBehind (View)
#####Responsibility:
##### Responsibility:
* Holds the state of the view/CB
* Formats domain data to the needed representation for the view/CB.
* Receive user input via method calls from CodeBehind.
@ -76,7 +76,7 @@ It knows the model (via Guice injection) but it does not know the CodeBehind (Vi
* Listen to updates from model via bindings.
###Data model
### Data model
Represents the domain scope which is handled by the view.
Is interface to application domain objects.
We use Guice for dependency injection of the application domain objects.
@ -84,7 +84,7 @@ Can be used for unit testing.
Does not know the PM and View/CB
#####Responsibility:
##### Responsibility:
* Holds domain data for that view
* Apply domain business logic
* Interacts with application domain objects
@ -95,4 +95,4 @@ Does not know the PM and View/CB
[Presentation Model](http://martinfowler.com/eaaDev/PresentationModel.html)
[Model View ViewModel - MVVM](http://msdn.microsoft.com/en-us/magazine/dd419663.aspx)
[Java FX FXML controllers]
(http://docs.oracle.com/javafx/2/api/javafx/fxml/doc-files/introduction_to_fxml.html#controllers)
(http://docs.oracle.com/javafx/2/api/javafx/fxml/doc-files/introduction_to_fxml.html#controllers)

5
gui/src/main/java/io/bisq/gui/main/offer/offerbook/OfferBookView.java
View file

@ -173,6 +173,11 @@ public class OfferBookView extends ActivatableViewAndModel<GridPane, OfferBookVi
placeholder.setWrapText(true);
tableView.setPlaceholder(placeholder);
marketColumn.setComparator((o1, o2) -> {
String str1 = formatter.getCurrencyPair(o1.getOffer().getCurrencyCode());
String str2 = formatter.getCurrencyPair(o2.getOffer().getCurrencyCode());
return str1 != null && str2 != null ? str1.compareTo(str2) : 0;
});
priceColumn.setComparator((o1, o2) -> {
Price price1 = o1.getOffer().getPrice();
Price price2 = o2.getOffer().getPrice();