From af4994534af0926055ed332727042a07fdf6ec22 Mon Sep 17 00:00:00 2001 From: Christoph Atteneder Date: Tue, 7 Jan 2020 17:54:47 +0100 Subject: [PATCH] Only validate security deposit amount if used --- .../java/bisq/desktop/main/offer/MutableOfferViewModel.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java b/desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java index a4f7ed8510..8d1f7a5d0a 100644 --- a/desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java +++ b/desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java @@ -1221,13 +1221,17 @@ public abstract class MutableOfferViewModel ext boolean inputDataValid = isBtcInputValid(amount.get()).isValid && isBtcInputValid(minAmount.get()).isValid && isPriceInputValid(price.get()).isValid && - securityDepositValidator.validate(buyerSecurityDeposit.get()).isValid && dataModel.getPrice().get() != null && dataModel.getPrice().get().getValue() != 0 && isVolumeInputValid(volume.get()).isValid && isVolumeInputValid(DisplayUtils.formatVolume(dataModel.getMinVolume().get())).isValid && dataModel.isMinAmountLessOrEqualAmount(); + // validating the percentage deposit value only makes sense if it is actually used + if (!dataModel.isMinBuyerSecurityDeposit()) { + inputDataValid = inputDataValid && securityDepositValidator.validate(buyerSecurityDeposit.get()).isValid; + } + isNextButtonDisabled.set(!inputDataValid); // boolean notSufficientFees = dataModel.isWalletFunded.get() && dataModel.isMainNet.get() && !dataModel.isFeeFromFundingTxSufficient.get(); //isPlaceOfferButtonDisabled.set(createOfferRequested || !inputDataValid || notSufficientFees);