mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 09:52:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

BisqRiskAnalysis: update comment

Browse Source
This commit is contained in:
Oscar Guindzberg 2018-12-18 12:50:25 -03:00
parent 6633e22ffd
commit a164dec427
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
core/src/main/java/bisq/core/btc/wallet/BisqRiskAnalysis.java
View File

@ -58,7 +58,8 @@ import static com.google.common.base.Preconditions.checkState;
// Copied from DefaultRiskAnalysis as DefaultRiskAnalysis has mostly private methods and constructor so we cannot // Copied from DefaultRiskAnalysis as DefaultRiskAnalysis has mostly private methods and constructor so we cannot
// override it. // override it.
// Only change to DefaultRiskAnalysis is removal of the RBF check. // The changes to DefaultRiskAnalysis are: removal of the RBF check and accept as standard an OP_RETURN outputs
// with 0 value.
// For Bisq's use cases RBF is not considered risky. Requiring a confirmation for RBF payments from a users // For Bisq's use cases RBF is not considered risky. Requiring a confirmation for RBF payments from a users
// external wallet to Bisq would hurt usability. The trade transaction requires anyway a confirmation and we don't see // external wallet to Bisq would hurt usability. The trade transaction requires anyway a confirmation and we don't see
// a use case where a Bisq user accepts unconfirmed payment from untrusted peers and would not wait anyway for at least // a use case where a Bisq user accepts unconfirmed payment from untrusted peers and would not wait anyway for at least