mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 09:52:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5746 from jmacxx/missing_invalid_transaction_diagnostic

Browse Source 
Fix issue of Trade Step 1 validation done too soon
This commit is contained in:
Christoph Atteneder 2021-10-12 10:02:23 +02:00 committed by GitHub
commit 9ad4671773
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 22 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/src/main/java/bisq/core/trade/Trade.java
View File

@ -119,10 +119,10 @@ public abstract class Trade implements Tradable, Model {
// DEPOSIT_TX_PUBLISHED_MSG // DEPOSIT_TX_PUBLISHED_MSG
// seller perspective // seller perspective
SELLER_SENT_DEPOSIT_TX_PUBLISHED_MSG(Phase.DEPOSIT_PUBLISHED), @Deprecated SELLER_SENT_DEPOSIT_TX_PUBLISHED_MSG(Phase.DEPOSIT_PUBLISHED),
SELLER_SAW_ARRIVED_DEPOSIT_TX_PUBLISHED_MSG(Phase.DEPOSIT_PUBLISHED), @Deprecated SELLER_SAW_ARRIVED_DEPOSIT_TX_PUBLISHED_MSG(Phase.DEPOSIT_PUBLISHED),
SELLER_STORED_IN_MAILBOX_DEPOSIT_TX_PUBLISHED_MSG(Phase.DEPOSIT_PUBLISHED), @Deprecated SELLER_STORED_IN_MAILBOX_DEPOSIT_TX_PUBLISHED_MSG(Phase.DEPOSIT_PUBLISHED),
SELLER_SEND_FAILED_DEPOSIT_TX_PUBLISHED_MSG(Phase.DEPOSIT_PUBLISHED), @Deprecated SELLER_SEND_FAILED_DEPOSIT_TX_PUBLISHED_MSG(Phase.DEPOSIT_PUBLISHED),
// buyer perspective // buyer perspective
BUYER_RECEIVED_DEPOSIT_TX_PUBLISHED_MSG(Phase.DEPOSIT_PUBLISHED), BUYER_RECEIVED_DEPOSIT_TX_PUBLISHED_MSG(Phase.DEPOSIT_PUBLISHED),

2
core/src/main/java/bisq/core/trade/protocol/SellerProtocol.java
View File

@ -87,7 +87,7 @@ public abstract class SellerProtocol extends DisputeProtocol {
} }
protected void handle(ShareBuyerPaymentAccountMessage message, NodeAddress peer) { protected void handle(ShareBuyerPaymentAccountMessage message, NodeAddress peer) {
expect(anyPhase(Trade.Phase.DEPOSIT_PUBLISHED, Trade.Phase.DEPOSIT_CONFIRMED) expect(anyPhase(Trade.Phase.TAKER_FEE_PUBLISHED, Trade.Phase.DEPOSIT_PUBLISHED, Trade.Phase.DEPOSIT_CONFIRMED)
.with(message) .with(message)
.from(peer)) .from(peer))
.setup(tasks(SellerProcessShareBuyerPaymentAccountMessage.class, .setup(tasks(SellerProcessShareBuyerPaymentAccountMessage.class,

22
core/src/main/java/bisq/core/trade/protocol/tasks/seller/SellerSendsDepositTxAndDelayedPayoutTxMessage.java
View File

@ -79,16 +79,15 @@ public class SellerSendsDepositTxAndDelayedPayoutTxMessage extends SendMailboxMe
@Override @Override
protected void setStateSent() { protected void setStateSent() {
trade.setStateIfValidTransitionTo(Trade.State.SELLER_SENT_DEPOSIT_TX_PUBLISHED_MSG); // we no longer set deprecated state (Trade.State.SELLER_SENT_DEPOSIT_TX_PUBLISHED_MSG);
// see https://github.com/bisq-network/bisq/pull/5746#issuecomment-939879623
processModel.getTradeManager().requestPersistence();
} }
@Override @Override
protected void setStateArrived() { protected void setStateArrived() {
trade.setStateIfValidTransitionTo(Trade.State.SELLER_SAW_ARRIVED_DEPOSIT_TX_PUBLISHED_MSG); // we no longer set deprecated state (Trade.State.SELLER_SAW_ARRIVED_DEPOSIT_TX_PUBLISHED_MSG);
// see https://github.com/bisq-network/bisq/pull/5746#issuecomment-939879623
processModel.getTradeManager().requestPersistence();
cleanup(); cleanup();
// Complete is called in base class // Complete is called in base class
} }
@ -101,9 +100,9 @@ public class SellerSendsDepositTxAndDelayedPayoutTxMessage extends SendMailboxMe
@Override @Override
protected void setStateStoredInMailbox() { protected void setStateStoredInMailbox() {
trade.setStateIfValidTransitionTo(Trade.State.SELLER_STORED_IN_MAILBOX_DEPOSIT_TX_PUBLISHED_MSG); // we no longer set deprecated state (Trade.State.SELLER_STORED_IN_MAILBOX_DEPOSIT_TX_PUBLISHED_MSG);
// see https://github.com/bisq-network/bisq/pull/5746#issuecomment-939879623
processModel.getTradeManager().requestPersistence();
// The DepositTxAndDelayedPayoutTxMessage is a mailbox message as earlier we use only the deposit tx which can // The DepositTxAndDelayedPayoutTxMessage is a mailbox message as earlier we use only the deposit tx which can
// be also received from the network once published. // be also received from the network once published.
// Now we send the delayed payout tx as well and with that this message is mandatory for continuing the protocol. // Now we send the delayed payout tx as well and with that this message is mandatory for continuing the protocol.
@ -125,12 +124,11 @@ public class SellerSendsDepositTxAndDelayedPayoutTxMessage extends SendMailboxMe
@Override @Override
protected void setStateFault() { protected void setStateFault() {
trade.setStateIfValidTransitionTo(Trade.State.SELLER_SEND_FAILED_DEPOSIT_TX_PUBLISHED_MSG); // we no longer set deprecated state (Trade.State.SELLER_SEND_FAILED_DEPOSIT_TX_PUBLISHED_MSG);
// see https://github.com/bisq-network/bisq/pull/5746#issuecomment-939879623
if (!trade.isDepositConfirmed()) { if (!trade.isDepositConfirmed()) {
tryToSendAgainLater(); tryToSendAgainLater();
} }
processModel.getTradeManager().requestPersistence();
} }
@Override @Override
@ -184,9 +182,9 @@ public class SellerSendsDepositTxAndDelayedPayoutTxMessage extends SendMailboxMe
// Once we receive an ACK from our msg we know the peer has received the msg and we stop. // Once we receive an ACK from our msg we know the peer has received the msg and we stop.
if (newValue == MessageState.ACKNOWLEDGED) { if (newValue == MessageState.ACKNOWLEDGED) {
// We treat a ACK like SELLER_SAW_ARRIVED_DEPOSIT_TX_PUBLISHED_MSG // We treat a ACK like SELLER_SAW_ARRIVED_DEPOSIT_TX_PUBLISHED_MSG
trade.setStateIfValidTransitionTo(Trade.State.SELLER_SAW_ARRIVED_DEPOSIT_TX_PUBLISHED_MSG); // we no longer set deprecated state (Trade.State.SELLER_SAW_ARRIVED_DEPOSIT_TX_PUBLISHED_MSG);
// see https://github.com/bisq-network/bisq/pull/5746#issuecomment-939879623
processModel.getTradeManager().requestPersistence();
cleanup(); cleanup();
complete(); complete();
} }

3
desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java
View File

@ -367,7 +367,8 @@ public class PendingTradesView extends ActivatableViewAndModel<VBox, PendingTrad
} }
private boolean isMaybeInvalidTrade(Trade trade) { private boolean isMaybeInvalidTrade(Trade trade) {
return trade.isTxChainInvalid() || trade.hasErrorMessage(); return trade.hasErrorMessage() ||
(Trade.Phase.DEPOSIT_PUBLISHED.ordinal() <= trade.getPhase().ordinal() && trade.isTxChainInvalid());
} }
private void onMoveInvalidTradeToFailedTrades(Trade trade) { private void onMoveInvalidTradeToFailedTrades(Trade trade) {

8
desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java
View File

@ -433,15 +433,9 @@ public class PendingTradesViewModel extends ActivatableWithDataModel<PendingTrad
// #################### Phase DEPOSIT_PAID // #################### Phase DEPOSIT_PAID
case SELLER_PUBLISHED_DEPOSIT_TX:
// DEPOSIT_TX_PUBLISHED_MSG // DEPOSIT_TX_PUBLISHED_MSG
// seller perspective // seller perspective
case SELLER_SENT_DEPOSIT_TX_PUBLISHED_MSG: case SELLER_PUBLISHED_DEPOSIT_TX:
case SELLER_SAW_ARRIVED_DEPOSIT_TX_PUBLISHED_MSG:
case SELLER_STORED_IN_MAILBOX_DEPOSIT_TX_PUBLISHED_MSG:
case SELLER_SEND_FAILED_DEPOSIT_TX_PUBLISHED_MSG:
// buyer perspective // buyer perspective
case BUYER_RECEIVED_DEPOSIT_TX_PUBLISHED_MSG: case BUYER_RECEIVED_DEPOSIT_TX_PUBLISHED_MSG:

8
proto/src/main/proto/pb.proto
View File

@ -1510,10 +1510,10 @@ message Trade {
MAKER_SEND_FAILED_PUBLISH_DEPOSIT_TX_REQUEST = 6; MAKER_SEND_FAILED_PUBLISH_DEPOSIT_TX_REQUEST = 6;
TAKER_RECEIVED_PUBLISH_DEPOSIT_TX_REQUEST = 7; TAKER_RECEIVED_PUBLISH_DEPOSIT_TX_REQUEST = 7;
SELLER_PUBLISHED_DEPOSIT_TX = 8; SELLER_PUBLISHED_DEPOSIT_TX = 8;
SELLER_SENT_DEPOSIT_TX_PUBLISHED_MSG = 9; SELLER_SENT_DEPOSIT_TX_PUBLISHED_MSG = 9 [deprecated = true];
SELLER_SAW_ARRIVED_DEPOSIT_TX_PUBLISHED_MSG = 10; SELLER_SAW_ARRIVED_DEPOSIT_TX_PUBLISHED_MSG = 10 [deprecated = true];
SELLER_STORED_IN_MAILBOX_DEPOSIT_TX_PUBLISHED_MSG = 11; SELLER_STORED_IN_MAILBOX_DEPOSIT_TX_PUBLISHED_MSG = 11 [deprecated = true];
SELLER_SEND_FAILED_DEPOSIT_TX_PUBLISHED_MSG = 12; SELLER_SEND_FAILED_DEPOSIT_TX_PUBLISHED_MSG = 12 [deprecated = true];
BUYER_RECEIVED_DEPOSIT_TX_PUBLISHED_MSG = 13; BUYER_RECEIVED_DEPOSIT_TX_PUBLISHED_MSG = 13;
BUYER_SAW_DEPOSIT_TX_IN_NETWORK = 14; BUYER_SAW_DEPOSIT_TX_IN_NETWORK = 14;
DEPOSIT_CONFIRMED_IN_BLOCK_CHAIN = 15; DEPOSIT_CONFIRMED_IN_BLOCK_CHAIN = 15;