mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 09:52:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

Cache enum.values() in ChartCalculations & TradeStatistics3

Browse Source 
Cache enum arrays 'TickUnit.values()' & 'PaymentMethodWrapper.values()'
as the JVM makes defensive copies of them every time they are returned,
and they are both being used in tight loops. In particular, profiling
suggests this will make 'TradeStatistics3.isValid' about twice as fast.
This commit is contained in:
Steven Barclay 2023-05-07 20:51:09 +01:00
parent 835593f2c9
commit 914d75682c
No known key found for this signature in database
GPG Key ID: 9FED6BF1176D500B
2 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java
View File

@ -200,7 +200,9 @@ public final class TradeStatistics3 implements ProcessOncePersistableNetworkPayl
TIKKIE, TIKKIE,
TRANSFERWISE_USD, TRANSFERWISE_USD,
ACH_TRANSFER, ACH_TRANSFER,
DOMESTIC_WIRE_TRANSFER DOMESTIC_WIRE_TRANSFER;
private static final PaymentMethodMapper[] values = values(); // cache for perf gain
} }
@Getter @Getter
@ -413,7 +415,7 @@ public final class TradeStatistics3 implements ProcessOncePersistableNetworkPayl
return paymentMethod; return paymentMethod;
} }
try { try {
return PaymentMethodMapper.values()[Integer.parseInt(paymentMethod)].name(); return PaymentMethodMapper.values[Integer.parseInt(paymentMethod)].name();
} catch (NumberFormatException | ArrayIndexOutOfBoundsException e) { } catch (NumberFormatException | ArrayIndexOutOfBoundsException e) {
return paymentMethod; return paymentMethod;
} }

11
desktop/src/main/java/bisq/desktop/main/market/trades/ChartCalculations.java
View File

@ -73,20 +73,21 @@ public class ChartCalculations {
dateMapsPerTickUnit.put(tick, new HashMap<>()); dateMapsPerTickUnit.put(tick, new HashMap<>());
} }
TradesChartsViewModel.TickUnit[] tickUnits = TradesChartsViewModel.TickUnit.values();
tradeStatisticsSet.stream() tradeStatisticsSet.stream()
.filter(e -> e.getCurrency().equals("USD")) .filter(e -> e.getCurrency().equals("USD"))
.forEach(tradeStatistics -> { .forEach(tradeStatistics -> {
for (TradesChartsViewModel.TickUnit tick : TradesChartsViewModel.TickUnit.values()) { for (TradesChartsViewModel.TickUnit tickUnit : tickUnits) {
long time = roundToTick(tradeStatistics.getLocalDateTime(), tick).getTime(); long time = roundToTick(tradeStatistics.getLocalDateTime(), tickUnit).getTime();
Map<Long, List<TradeStatistics3>> map = dateMapsPerTickUnit.get(tick); Map<Long, List<TradeStatistics3>> map = dateMapsPerTickUnit.get(tickUnit);
map.computeIfAbsent(time, t -> new ArrayList<>()).add(tradeStatistics); map.computeIfAbsent(time, t -> new ArrayList<>()).add(tradeStatistics);
} }
}); });
dateMapsPerTickUnit.forEach((tick, map) -> { dateMapsPerTickUnit.forEach((tickUnit, map) -> {
HashMap<Long, Long> priceMap = new HashMap<>(); HashMap<Long, Long> priceMap = new HashMap<>();
map.forEach((date, tradeStatisticsList) -> priceMap.put(date, getAveragePrice(tradeStatisticsList))); map.forEach((date, tradeStatisticsList) -> priceMap.put(date, getAveragePrice(tradeStatisticsList)));
usdAveragePriceMapsPerTickUnit.put(tick, priceMap); usdAveragePriceMapsPerTickUnit.put(tickUnit, priceMap);
}); });
return usdAveragePriceMapsPerTickUnit; return usdAveragePriceMapsPerTickUnit;
}); });