mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-01-19 05:44:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add test for version update check (support versions with more then 4 digits)

Browse Source
This commit is contained in:
Manfred Karrer 2017-02-10 14:11:26 -05:00
parent 54f860ddb7
commit 891580f458
2 changed files with 57 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/src/main/java/io/bitsquare/alert/Alert.java
View File

@ -17,6 +17,7 @@
package io.bitsquare.alert; package io.bitsquare.alert;
import com.google.common.annotations.VisibleForTesting;
import io.bitsquare.app.Version; import io.bitsquare.app.Version;
import io.bitsquare.common.crypto.Sig; import io.bitsquare.common.crypto.Sig;
import io.bitsquare.p2p.storage.payload.StoragePayload; import io.bitsquare.p2p.storage.payload.StoragePayload;
@ -69,9 +70,14 @@ public final class Alert implements StoragePayload {
} }
public boolean isNewVersion() { public boolean isNewVersion() {
return isNewVersion(Version.VERSION);
}
@VisibleForTesting
protected boolean isNewVersion(String appVersion) {
// Usually we use 3 digits (0.4.8) but to support also 4 digits in case of hotfixes (0.4.8.1) we // Usually we use 3 digits (0.4.8) but to support also 4 digits in case of hotfixes (0.4.8.1) we
// add a 0 at all 3 digit versions to allow correct comparison: 0.4.8 -> 480; 0.4.8.1 -> 481; 481 > 480 // add a 0 at all 3 digit versions to allow correct comparison: 0.4.8 -> 480; 0.4.8.1 -> 481; 481 > 480
String myVersionString = Version.VERSION.replace(".", ""); String myVersionString = appVersion.replace(".", "");
if (myVersionString.length() == 3) if (myVersionString.length() == 3)
myVersionString += "0"; myVersionString += "0";
int versionNum = Integer.valueOf(myVersionString); int versionNum = Integer.valueOf(myVersionString);

50
core/src/test/java/io/bitsquare/alert/AlertTest.java Normal file
View File

@ -0,0 +1,50 @@
/*
* This file is part of Bitsquare.
*
* Bitsquare is free software: you can redistribute it and/or modify it
* under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or (at
* your option) any later version.
*
* Bitsquare is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
* License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with Bitsquare. If not, see <http://www.gnu.org/licenses/>.
*/
package io.bitsquare.alert;
import org.junit.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
public class AlertTest {
private static final Logger log = LoggerFactory.getLogger(AlertTest.class);
@Test
public void testIsNewVersion() {
Alert alert = new Alert(null, true, "0.4.9.9.1");
assertTrue(alert.isNewVersion("0.4.9.9"));
assertTrue(alert.isNewVersion("0.4.9.8"));
assertTrue(alert.isNewVersion("0.4.9"));
assertTrue(alert.isNewVersion("0.4.9.9.0"));
assertFalse(alert.isNewVersion("0.4.9.9.1"));
alert = new Alert(null, true, "0.4.9.9.2");
assertTrue(alert.isNewVersion("0.4.9.9.1"));
assertFalse(alert.isNewVersion("0.4.9.9.2"));
assertTrue(alert.isNewVersion("0.4.9.8"));
assertTrue(alert.isNewVersion("0.4.9"));
alert = new Alert(null, true, "0.4.9.9");
assertTrue(alert.isNewVersion("0.4.9"));
assertTrue(alert.isNewVersion("0.4.9.8"));
assertFalse(alert.isNewVersion("0.4.9.9"));
}
}