mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-03-03 10:46:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

Use non-default regtest bitcoind -rpcport

Browse source 
The default bitcoind / bitcoin-cli rpcport option has been changed
from 18443 to 19443, to help avoid rpcport conflicts between apitest's
bitcoind instances and other bitcoind and/or bitcion-qt instances
which are probably using the bitcoin-core default (regtest) rpcport
18443.

However, this commit cannot include other changes for avoiding bind
address:port conflicts between apitest bitcoind instances and other
regtest bitcoin-core instances because bitcoinj's bind port is hardcoded
in RegTestParams.java as 18444.

In order to avoid bitcoin-core regtest mode bind address conflicts,
you must start or restart your bitcoind or bitcoin-qt instance with a
non-default bind port argument, e.g.

	bitcoin-qt -regtest -port=20444
This commit is contained in:
ghubstan 2020-08-15 12:20:25 -03:00
parent 9637cc0943
commit 72ff4dca2b
No known key found for this signature in database
GPG key ID: E35592D6800A861E
3 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apitest/src/main/java/bisq/apitest/config/ApiTestConfig.java
View file

@ -173,9 +173,9 @@ public class ApiTestConfig {
.ofType(String.class).defaultsTo("localhost"); .ofType(String.class).defaultsTo("localhost");
ArgumentAcceptingOptionSpec<Integer> bitcoinRpcPortOpt = ArgumentAcceptingOptionSpec<Integer> bitcoinRpcPortOpt =
parser.accepts(BITCOIN_RPC_PORT, "Bitcoin Core rpc port") parser.accepts(BITCOIN_RPC_PORT, "Bitcoin Core rpc port (non-default)")
.withRequiredArg() .withRequiredArg()
.ofType(Integer.class).defaultsTo(18443); .ofType(Integer.class).defaultsTo(19443);
ArgumentAcceptingOptionSpec<String> bitcoinRpcUserOpt = ArgumentAcceptingOptionSpec<String> bitcoinRpcUserOpt =
parser.accepts(BITCOIN_RPC_USER, "Bitcoin rpc user") parser.accepts(BITCOIN_RPC_USER, "Bitcoin rpc user")

1
apitest/src/main/java/bisq/apitest/linux/BitcoinCli.java
View file

@ -149,6 +149,7 @@ public class BitcoinCli extends AbstractLinuxProcess implements LinuxProcess {
verifyBitcoinPathsExist(false); verifyBitcoinPathsExist(false);
verifyBitcoindRunning(); verifyBitcoindRunning();
commandWithOptions = config.bitcoinPath + "/bitcoin-cli -regtest " commandWithOptions = config.bitcoinPath + "/bitcoin-cli -regtest "
+ " -rpcport=" + config.bitcoinRpcPort
+ " -rpcuser=" + config.bitcoinRpcUser + " -rpcuser=" + config.bitcoinRpcUser
+ " -rpcpassword=" + config.bitcoinRpcPassword + " -rpcpassword=" + config.bitcoinRpcPassword
+ " " + command; + " " + command;

1
apitest/src/main/java/bisq/apitest/linux/BitcoinDaemon.java
View file

@ -56,6 +56,7 @@ public class BitcoinDaemon extends AbstractLinuxProcess implements LinuxProcess
+ " -peerbloomfilters=1" + " -peerbloomfilters=1"
+ " -debug=net" + " -debug=net"
+ " -fallbackfee=0.0002" + " -fallbackfee=0.0002"
+ " -rpcport=" + config.bitcoinRpcPort
+ " -rpcuser=" + config.bitcoinRpcUser + " -rpcuser=" + config.bitcoinRpcUser
+ " -rpcpassword=" + config.bitcoinRpcPassword + " -rpcpassword=" + config.bitcoinRpcPassword
+ " -blocknotify=" + config.bitcoinDatadir + "/blocknotify"; + " -blocknotify=" + config.bitcoinDatadir + "/blocknotify";