- Fix incorrect isTerminal default value.

- Apply suggestions from code inspection
This commit is contained in:
chimp1984 2020-09-01 20:07:12 -05:00
parent 91cc14725c
commit 67aa46a03b
No known key found for this signature in database
GPG key ID: 9801B4EC591F90E3
5 changed files with 5 additions and 5 deletions

View file

@ -50,7 +50,7 @@ public enum AssetTxProofResult {
private final boolean isTerminal;
AssetTxProofResult() {
this(false);
this(true);
}
AssetTxProofResult(boolean isTerminal) {

View file

@ -35,6 +35,7 @@ import lombok.extern.slf4j.Slf4j;
import static com.google.common.base.Preconditions.checkNotNull;
@SuppressWarnings("SpellCheckingInspection")
@Slf4j
@Value
public class XmrTxProofModel {

View file

@ -33,6 +33,7 @@ import lombok.extern.slf4j.Slf4j;
@Slf4j
class XmrTxProofParser {
@SuppressWarnings("SpellCheckingInspection")
static XmrTxProofRequest.Result parse(XmrTxProofModel xmrTxProofModel, String jsonTxt) {
String txHash = xmrTxProofModel.getTxHash();
try {

View file

@ -164,6 +164,7 @@ class XmrTxProofRequest {
// API
///////////////////////////////////////////////////////////////////////////////////////////
@SuppressWarnings("SpellCheckingInspection")
public void start(Consumer<Result> resultHandler, FaultHandler faultHandler) {
if (terminated) {
// the XmrTransferProofService has asked us to terminate i.e. not make any further api calls
@ -239,10 +240,6 @@ class XmrTxProofRequest {
terminated = true;
}
String getServiceAddress() {
return xmrTxProofModel.getServiceAddress();
}
// Convenient for logging
@Override
public String toString() {

View file

@ -71,6 +71,7 @@ public class XmrTxProofService {
// Constructor
///////////////////////////////////////////////////////////////////////////////////////////
@SuppressWarnings("WeakerAccess")
@Inject
public XmrTxProofService(FilterManager filterManager,
Preferences preferences,