mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-02-25 07:27:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove unused tableRow field from ProposalListItem

Browse source 
The 'tableRow' field of each (voted upon) proposal list item is reset
upon selection of a cycle list item in the Vote Result view, but not set
anywhere, so remove the field along with its set/reset methods.
This commit is contained in:
Steven Barclay 2024-05-06 15:20:39 +02:00
parent 3a70213d1b
commit 6780d35716
No known key found for this signature in database
GPG key ID: 9FED6BF1176D500B
2 changed files with 1 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
desktop/src/main/java/bisq/desktop/main/dao/governance/result/ProposalListItem.java
View file

@ -40,7 +40,6 @@ import org.bitcoinj.core.Coin;
import de.jensd.fx.fontawesome.AwesomeIcon; import de.jensd.fx.fontawesome.AwesomeIcon;
import javafx.scene.control.Label; import javafx.scene.control.Label;
import javafx.scene.control.TableRow;
import javafx.scene.layout.HBox; import javafx.scene.layout.HBox;
import javafx.scene.layout.StackPane; import javafx.scene.layout.StackPane;
@ -51,18 +50,14 @@ import lombok.Getter;
import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.NotNull;
public class ProposalListItem { public class ProposalListItem {
@Getter @Getter
private EvaluatedProposal evaluatedProposal; private final EvaluatedProposal evaluatedProposal;
@Getter @Getter
private final Proposal proposal; private final Proposal proposal;
private final Vote vote; private final Vote vote;
private final boolean isMyBallotIncluded; private final boolean isMyBallotIncluded;
private final BsqFormatter bsqFormatter; private final BsqFormatter bsqFormatter;
private TableRow tableRow;
ProposalListItem(EvaluatedProposal evaluatedProposal, Ballot ballot, boolean isMyBallotIncluded, ProposalListItem(EvaluatedProposal evaluatedProposal, Ballot ballot, boolean isMyBallotIncluded,
BsqFormatter bsqFormatter) { BsqFormatter bsqFormatter) {
this.evaluatedProposal = evaluatedProposal; this.evaluatedProposal = evaluatedProposal;
@ -104,17 +99,6 @@ public class ProposalListItem {
return myVoteIcon; return myVoteIcon;
} }
public void setTableRow(TableRow tableRow) {
this.tableRow = tableRow;
}
public void resetTableRow() {
if (tableRow != null) {
tableRow.setStyle(null);
tableRow.requestLayout();
}
}
public String getProposalOwnerName() { public String getProposalOwnerName() {
return evaluatedProposal.getProposal().getName(); return evaluatedProposal.getProposal().getName();
} }

1
desktop/src/main/java/bisq/desktop/main/dao/governance/result/VoteResultView.java
View file

@ -495,7 +495,6 @@ public class VoteResultView extends ActivatableView<GridPane, Void> implements D
proposalsTableView.setItems(sortedProposalList); proposalsTableView.setItems(sortedProposalList);
sortedProposalList.comparatorProperty().bind(proposalsTableView.comparatorProperty()); sortedProposalList.comparatorProperty().bind(proposalsTableView.comparatorProperty());
proposalList.forEach(ProposalListItem::resetTableRow);
proposalList.clear(); proposalList.clear();
Map<String, Ballot> ballotByProposalTxIdMap = daoFacade.getAllValidBallots().stream() Map<String, Ballot> ballotByProposalTxIdMap = daoFacade.getAllValidBallots().stream()