Remove empty onParseTxsCompleteAfterBatchProcessing methods

Make onParseTxsCompleteAfterBatchProcessing default in listener

core/src/main/java/bisq/core/dao/DaoFacade.java

@@ -55,7 +55,6 @@ import bisq.core.dao.governance.proposal.role.RoleProposalFactory;
 import bisq.core.dao.state.DaoStateListener;
 import bisq.core.dao.state.DaoStateService;
 import bisq.core.dao.state.DaoStateStorageService;
-import bisq.core.dao.state.model.blockchain.Block;
 import bisq.core.dao.state.model.blockchain.Tx;
 import bisq.core.dao.state.model.blockchain.TxOutput;
 import bisq.core.dao.state.model.blockchain.TxOutputKey;
@@ -188,10 +187,6 @@ public class DaoFacade implements DaoSetupService {
                     periodService.getCurrentCycle().getPhaseForHeight(blockHeight).ifPresent(phaseProperty::set);
             }
 
-            @Override
-            public void onParseTxsCompleteAfterBatchProcessing(Block block) {
-            }
-
             @Override
             public void onParseBlockChainComplete() {
             }

core/src/main/java/bisq/core/dao/governance/blindvote/BlindVoteListService.java

@@ -23,7 +23,6 @@ import bisq.core.dao.governance.blindvote.storage.BlindVotePayload;
 import bisq.core.dao.governance.blindvote.storage.BlindVoteStorageService;
 import bisq.core.dao.state.DaoStateListener;
 import bisq.core.dao.state.DaoStateService;
-import bisq.core.dao.state.model.blockchain.Block;
 
 import bisq.network.p2p.P2PService;
 import bisq.network.p2p.storage.payload.PersistableNetworkPayload;
@@ -98,10 +97,6 @@ public class BlindVoteListService implements AppendOnlyDataStoreListener, DaoSta
     public void onNewBlockHeight(int blockHeight) {
     }
 
-    @Override
-    public void onParseTxsCompleteAfterBatchProcessing(Block block) {
-    }
-
     @Override
     public void onParseBlockChainComplete() {
         fillListFromAppendOnlyDataStore();

core/src/main/java/bisq/core/dao/governance/blindvote/MyBlindVoteListService.java

@@ -35,7 +35,6 @@ import bisq.core.dao.governance.period.PeriodService;
 import bisq.core.dao.governance.proposal.MyProposalListService;
 import bisq.core.dao.state.DaoStateListener;
 import bisq.core.dao.state.DaoStateService;
-import bisq.core.dao.state.model.blockchain.Block;
 import bisq.core.dao.state.model.governance.BallotList;
 import bisq.core.dao.state.model.governance.CompensationProposal;
 import bisq.core.dao.state.model.governance.DaoPhase;
@@ -176,10 +175,6 @@ public class MyBlindVoteListService implements PersistedDataHost, DaoStateListen
     public void onNewBlockHeight(int blockHeight) {
     }
 
-    @Override
-    public void onParseTxsCompleteAfterBatchProcessing(Block block) {
-    }
-
     @Override
     public void onParseBlockChainComplete() {
         rePublishOnceWellConnected();

core/src/main/java/bisq/core/dao/governance/period/CycleService.java

@@ -22,7 +22,6 @@ import bisq.core.dao.governance.param.Param;
 import bisq.core.dao.state.DaoStateListener;
 import bisq.core.dao.state.DaoStateService;
 import bisq.core.dao.state.GenesisTxInfo;
-import bisq.core.dao.state.model.blockchain.Block;
 import bisq.core.dao.state.model.governance.Cycle;
 import bisq.core.dao.state.model.governance.DaoPhase;
 
@@ -83,10 +82,6 @@ public class CycleService implements DaoStateListener, DaoSetupService {
                     .ifPresent(daoStateService.getCycles()::add);
     }
 
-    @Override
-    public void onParseTxsCompleteAfterBatchProcessing(Block block) {
-    }
-
     @Override
     public void onParseBlockChainComplete() {
     }

core/src/main/java/bisq/core/dao/governance/proposal/MyProposalListService.java

@@ -25,7 +25,6 @@ import bisq.core.dao.governance.period.PeriodService;
 import bisq.core.dao.governance.proposal.storage.temp.TempProposalPayload;
 import bisq.core.dao.state.DaoStateListener;
 import bisq.core.dao.state.DaoStateService;
-import bisq.core.dao.state.model.blockchain.Block;
 import bisq.core.dao.state.model.blockchain.Tx;
 import bisq.core.dao.state.model.governance.DaoPhase;
 import bisq.core.dao.state.model.governance.Proposal;
@@ -125,10 +124,6 @@ public class MyProposalListService implements PersistedDataHost, DaoStateListene
     public void onNewBlockHeight(int blockHeight) {
     }
 
-    @Override
-    public void onParseTxsCompleteAfterBatchProcessing(Block block) {
-    }
-
     @Override
     public void onParseBlockChainComplete() {
         rePublishOnceWellConnected();

core/src/main/java/bisq/core/dao/governance/voteresult/VoteResultService.java

@@ -33,7 +33,6 @@ import bisq.core.dao.governance.votereveal.VoteRevealConsensus;
 import bisq.core.dao.governance.votereveal.VoteRevealService;
 import bisq.core.dao.state.DaoStateListener;
 import bisq.core.dao.state.DaoStateService;
-import bisq.core.dao.state.model.blockchain.Block;
 import bisq.core.dao.state.model.blockchain.Tx;
 import bisq.core.dao.state.model.blockchain.TxOutput;
 import bisq.core.dao.state.model.governance.Ballot;
@@ -155,10 +154,6 @@ public class VoteResultService implements DaoStateListener, DaoSetupService {
         maybeCalculateVoteResult(blockHeight);
     }
 
-    @Override
-    public void onParseTxsCompleteAfterBatchProcessing(Block block) {
-    }
-
     @Override
     public void onParseBlockChainComplete() {
     }

core/src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java

@@ -36,7 +36,6 @@ import bisq.core.dao.node.BsqNode;
 import bisq.core.dao.node.BsqNodeProvider;
 import bisq.core.dao.state.DaoStateListener;
 import bisq.core.dao.state.DaoStateService;
-import bisq.core.dao.state.model.blockchain.Block;
 import bisq.core.dao.state.model.blockchain.TxOutput;
 import bisq.core.dao.state.model.governance.DaoPhase;
 
@@ -157,10 +156,6 @@ public class VoteRevealService implements DaoStateListener, DaoSetupService {
         maybeRevealVotes();
     }
 
-    @Override
-    public void onParseTxsCompleteAfterBatchProcessing(Block block) {
-    }
-
     @Override
     public void onParseBlockChainComplete() {
     }

core/src/main/java/bisq/core/dao/state/DaoStateListener.java

@@ -22,14 +22,15 @@ import bisq.core.dao.state.model.blockchain.Block;
 public interface DaoStateListener {
     void onNewBlockHeight(int blockHeight);
 
-    void onParseTxsCompleteAfterBatchProcessing(Block block);
-
     void onParseBlockChainComplete();
 
     // Never used but we still want to provide the event
     default void onEmptyBlockAdded(Block block) {
     }
 
+    default void onParseTxsCompleteAfterBatchProcessing(Block block) {
+    }
+
     default void onParseTxsComplete(Block block, boolean parseBlockChainComplete) {
     }
 }

core/src/main/java/bisq/core/dao/state/DaoStateSnapshotService.java

@@ -74,10 +74,6 @@ public class DaoStateSnapshotService implements DaoStateListener {
     public void onNewBlockHeight(int blockHeight) {
     }
 
-    @Override
-    public void onParseTxsCompleteAfterBatchProcessing(Block block) {
-    }
-
     // We listen to each ParseTxsComplete event even the batch processing of all blocks at startup is not completed
     // as we need to write snapshots during that batch processing.
     @Override

desktop/src/main/java/bisq/desktop/main/dao/governance/PhasesView.java

@@ -22,7 +22,6 @@ import bisq.desktop.util.Layout;
 
 import bisq.core.dao.DaoFacade;
 import bisq.core.dao.state.DaoStateListener;
-import bisq.core.dao.state.model.blockchain.Block;
 import bisq.core.dao.state.model.governance.DaoPhase;
 import bisq.core.locale.Res;
 
@@ -96,10 +95,6 @@ public class PhasesView implements DaoStateListener {
         applyData(height);
     }
 
-    @Override
-    public void onParseTxsCompleteAfterBatchProcessing(Block block) {
-    }
-
     @Override
     public void onParseBlockChainComplete() {
     }

desktop/src/main/java/bisq/desktop/main/dao/governance/dashboard/GovernanceDashboardView.java

@@ -25,7 +25,6 @@ import bisq.desktop.util.Layout;
 
 import bisq.core.dao.DaoFacade;
 import bisq.core.dao.state.DaoStateListener;
-import bisq.core.dao.state.model.blockchain.Block;
 import bisq.core.dao.state.model.governance.DaoPhase;
 import bisq.core.locale.Res;
 import bisq.core.util.BSFormatter;
@@ -111,10 +110,6 @@ public class GovernanceDashboardView extends ActivatableView<GridPane, Void> imp
         applyData(height);
     }
 
-    @Override
-    public void onParseTxsCompleteAfterBatchProcessing(Block block) {
-    }
-
     @Override
     public void onParseBlockChainComplete() {
     }

desktop/src/main/java/bisq/desktop/main/dao/governance/make/MakeProposalView.java

@@ -38,7 +38,6 @@ import bisq.core.dao.governance.proposal.ProposalWithTransaction;
 import bisq.core.dao.governance.proposal.TxException;
 import bisq.core.dao.governance.proposal.param.ChangeParamValidator;
 import bisq.core.dao.state.DaoStateListener;
-import bisq.core.dao.state.model.blockchain.Block;
 import bisq.core.dao.state.model.governance.DaoPhase;
 import bisq.core.dao.state.model.governance.Proposal;
 import bisq.core.dao.state.model.governance.Role;
@@ -187,10 +186,6 @@ public class MakeProposalView extends ActivatableView<GridPane, Void> implements
             proposalTypeComboBox.getSelectionModel().clearSelection();
     }
 
-    @Override
-    public void onParseTxsCompleteAfterBatchProcessing(Block block) {
-    }
-
     @Override
     public void onParseBlockChainComplete() {
     }

desktop/src/main/java/bisq/desktop/main/dao/governance/result/VoteResultView.java

@@ -184,10 +184,6 @@ public class VoteResultView extends ActivatableView<GridPane, Void> implements D
         fillCycleList();
     }
 
-    @Override
-    public void onParseTxsCompleteAfterBatchProcessing(Block block) {
-    }
-
     @Override
     public void onParseBlockChainComplete() {
     }