mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-02-22 22:45:21 +01:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2725 from ripcurlx/remove-rounding-popup-showing-redundancy

Browse source 
Only show rounding popup once during activation
This commit is contained in:
Manfred Karrer 2019-04-16 08:49:43 -05:00 • committed by GitHub
commit 536ef67be0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java
View file

@ -250,8 +250,6 @@ public abstract class MutableOfferView<M extends MutableOfferViewModel> extends
balanceTextField.setTargetAmount(model.getDataModel().totalToPayAsCoinProperty().get());
updatePriceToggle();
showFiatRoundingInfoPopup();
boolean currencyForMakerFeeBtc = model.getDataModel().isCurrencyForMakerFeeBtc();
tradeFeeInBtcToggle.setSelected(currencyForMakerFeeBtc);
tradeFeeInBsqToggle.setSelected(!currencyForMakerFeeBtc);
@ -346,7 +344,7 @@ public abstract class MutableOfferView<M extends MutableOfferViewModel> extends
// UI actions
///////////////////////////////////////////////////////////////////////////////////////////
private void showFiatRoundingInfoPopup() {
protected void showFiatRoundingInfoPopup() {
if (CurrencyUtil.isFiatCurrency(model.tradeCurrencyCode.get()) && !DevEnv.isDevMode()) {
new Popup<>().headLine(Res.get("popup.roundedFiatValues.headline"))
.information(Res.get("popup.roundedFiatValues.msg", model.tradeCurrencyCode.get()))

5
desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferView.java
View file

@ -130,6 +130,11 @@ public class EditOfferView extends MutableOfferView<EditOfferViewModel> {
removeBindings();
}
@Override
protected void showFiatRoundingInfoPopup() {
// don't show it again as it was already shown when creating the offer in the first place
}
///////////////////////////////////////////////////////////////////////////////////////////
// API
///////////////////////////////////////////////////////////////////////////////////////////