mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-02-21 14:24:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

api: Remove getoffers' --all option

Browse source
This commit is contained in:
Alva Swanson 2024-12-20 23:59:42 +00:00
parent 3e526c7497
commit 462144eb8f
No known key found for this signature in database
GPG key ID: 004760E77F753090
15 changed files with 32 additions and 49 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java
View file

@ -277,7 +277,7 @@ public class CreateBSQOffersTest extends AbstractOfferTest {
@Test
@Order(6)
public void testGetAvailableBsqOffers() {
List<OfferInfo> offers = bobClient.getOffersSortedByDate(BSQ, false);
List<OfferInfo> offers = bobClient.getOffersSortedByDate(BSQ);
log.debug("All Bob's Available BSQ Offers:\n{}", toOffersTable.apply(offers));
assertEquals(4, offers.size());
log.debug("BOB'S BALANCES\n{}", formatBalancesTbls(bobClient.getBalances()));

2
apitest/src/test/java/bisq/apitest/method/offer/CreateXMROffersTest.java
View file

@ -274,7 +274,7 @@ public class CreateXMROffersTest extends AbstractOfferTest {
@Test
@Order(6)
public void testGetAvailableXMROffers() {
List<OfferInfo> offers = bobClient.getOffersSortedByDate(XMR, false);
List<OfferInfo> offers = bobClient.getOffersSortedByDate(XMR);
log.debug("All of Bob's available XMR offers:\n{}", toOffersTable.apply(offers));
assertEquals(4, offers.size());
log.debug("Bob's balances\n{}", formatBalancesTbls(bobClient.getBalances()));

2
apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java
View file

@ -77,7 +77,7 @@ public class TakeBuyBTCOfferTest extends AbstractTradeTest {
// Wait for Alice's AddToOfferBook task.
// Wait times vary; my logs show >= 2-second delay.
var timeout = System.currentTimeMillis() + 3000;
while (bobClient.getOffersSortedByDate(USD, true).size() < 1) {
while (bobClient.getOffersSortedByDate(USD).size() < 1) {
sleep(100);
if (System.currentTimeMillis() > timeout)
fail(new TimeoutException("Timed out waiting for Offer to be added to OfferBook"));

2
apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java
View file

@ -86,7 +86,7 @@ public class TakeSellBTCOfferTest extends AbstractTradeTest {
0L,
false);
sleep(2_500); // Allow available offer to be removed from offer book.
var takeableUsdOffers = bobClient.getOffersSortedByDate(SELL.name(), USD, false);
var takeableUsdOffers = bobClient.getOffersSortedByDate(SELL.name(), USD);
assertEquals(0, takeableUsdOffers.size());
trade = bobClient.getTrade(tradeId);

3
cli/src/main/java/bisq/cli/CliMain.java
View file

@ -487,8 +487,7 @@ public class CliMain {
}
var direction = opts.getDirection();
var currencyCode = opts.getCurrencyCode();
var all = opts.getAll();
List<OfferInfo> offers = client.getOffers(direction, currencyCode, all);
List<OfferInfo> offers = client.getOffers(direction, currencyCode);
if (offers.isEmpty())
out.printf("no %s %s offers found%n", direction, currencyCode);
else

12
cli/src/main/java/bisq/cli/GrpcClient.java
View file

@ -301,16 +301,16 @@ public final class GrpcClient {
return offersServiceRequest.getBsqSwapOffers(direction);
}
public List<OfferInfo> getOffers(String direction, String currencyCode, boolean all) {
return offersServiceRequest.getOffers(direction, currencyCode, all);
public List<OfferInfo> getOffers(String direction, String currencyCode) {
return offersServiceRequest.getOffers(direction, currencyCode);
}
public List<OfferInfo> getOffersSortedByDate(String currencyCode, boolean all) {
return offersServiceRequest.getOffersSortedByDate(currencyCode, all);
public List<OfferInfo> getOffersSortedByDate(String currencyCode) {
return offersServiceRequest.getOffersSortedByDate(currencyCode);
}
public List<OfferInfo> getOffersSortedByDate(String direction, String currencyCode, boolean all) {
return offersServiceRequest.getOffersSortedByDate(direction, currencyCode, all);
public List<OfferInfo> getOffersSortedByDate(String direction, String currencyCode) {
return offersServiceRequest.getOffersSortedByDate(direction, currencyCode);
}
public List<OfferInfo> getBsqSwapOffersSortedByDate() {

10
cli/src/main/java/bisq/cli/opts/GetOffersOptionParser.java
View file

@ -20,7 +20,6 @@ package bisq.cli.opts;
import joptsimple.OptionSpec;
import static bisq.cli.opts.OptLabel.OPT_ALL;
import static bisq.cli.opts.OptLabel.OPT_CURRENCY_CODE;
import static bisq.cli.opts.OptLabel.OPT_DIRECTION;
@ -32,11 +31,6 @@ public class GetOffersOptionParser extends AbstractMethodOptionParser implements
final OptionSpec<String> currencyCodeOpt = parser.accepts(OPT_CURRENCY_CODE, "currency code (bsq|xmr|eur|usd|...)")
.withRequiredArg();
final OptionSpec<Boolean> allOpt = parser.accepts(OPT_ALL, "get all offers")
.withOptionalArg()
.ofType(boolean.class)
.defaultsTo(Boolean.FALSE);
public GetOffersOptionParser(String[] args) {
super(args);
}
@ -64,8 +58,4 @@ public class GetOffersOptionParser extends AbstractMethodOptionParser implements
public String getCurrencyCode() {
return options.valueOf(currencyCodeOpt);
}
public boolean getAll() {
return options.valueOf(allOpt);
}
}

1
cli/src/main/java/bisq/cli/opts/OptLabel.java
View file

@ -26,7 +26,6 @@ public class OptLabel {
public final static String OPT_AMOUNT = "amount";
public final static String OPT_CATEGORY = "category";
public final static String OPT_CURRENCY_CODE = "currency-code";
public final static String OPT_ALL = "all";
public final static String OPT_DAYS = "days";
public final static String OPT_DIRECTION = "direction";
public final static String OPT_DISPUTE_AGENT_TYPE = "dispute-agent-type";

17
cli/src/main/java/bisq/cli/request/OffersServiceRequest.java
View file

@ -231,24 +231,23 @@ public class OffersServiceRequest {
return grpcStubs.offersService.getBsqSwapOffers(request).getBsqSwapOffersList();
}
public List<OfferInfo> getOffers(String direction, String currencyCode, boolean all) {
public List<OfferInfo> getOffers(String direction, String currencyCode) {
var request = GetOffersRequest.newBuilder()
.setDirection(direction)
.setCurrencyCode(currencyCode)
.setAll(all)
.build();
return grpcStubs.offersService.getOffers(request).getOffersList();
}
public List<OfferInfo> getOffersSortedByDate(String currencyCode, boolean all) {
public List<OfferInfo> getOffersSortedByDate(String currencyCode) {
ArrayList<OfferInfo> offers = new ArrayList<>();
offers.addAll(getOffers(BUY.name(), currencyCode, all));
offers.addAll(getOffers(SELL.name(), currencyCode, all));
offers.addAll(getOffers(BUY.name(), currencyCode));
offers.addAll(getOffers(SELL.name(), currencyCode));
return offers.isEmpty() ? offers : sortOffersByDate(offers);
}
public List<OfferInfo> getOffersSortedByDate(String direction, String currencyCode, boolean all) {
var offers = getOffers(direction, currencyCode, all);
public List<OfferInfo> getOffersSortedByDate(String direction, String currencyCode) {
var offers = getOffers(direction, currencyCode);
return offers.isEmpty() ? offers : sortOffersByDate(offers);
}
@ -293,8 +292,8 @@ public class OffersServiceRequest {
return sortOffersByDate(offers);
}
public OfferInfo getMostRecentOffer(String direction, String currencyCode, boolean all) {
List<OfferInfo> offers = getOffersSortedByDate(direction, currencyCode, all);
public OfferInfo getMostRecentOffer(String direction, String currencyCode) {
List<OfferInfo> offers = getOffersSortedByDate(direction, currencyCode);
return offers.isEmpty() ? null : offers.get(offers.size() - 1);
}

12
cli/src/test/java/bisq/cli/table/GetOffersCliOutputDiffTest.java
View file

@ -59,12 +59,12 @@ public class GetOffersCliOutputDiffTest extends AbstractCliTest {
}
private void getAvailableBuyUsdOffers() {
var offers = bobClient.getOffers(BUY.name(), "USD", false);
var offers = bobClient.getOffers(BUY.name(), "USD");
printAndCheckDiffs(offers, BUY.name(), "USD");
}
private void getAvailableSellUsdOffers() {
var offers = bobClient.getOffers(SELL.name(), "USD", false);
var offers = bobClient.getOffers(SELL.name(), "USD");
printAndCheckDiffs(offers, SELL.name(), "USD");
}
@ -79,12 +79,12 @@ public class GetOffersCliOutputDiffTest extends AbstractCliTest {
}
private void getAvailableBuyXmrOffers() {
var offers = bobClient.getOffers(BUY.name(), "XMR", false);
var offers = bobClient.getOffers(BUY.name(), "XMR");
printAndCheckDiffs(offers, BUY.name(), "XMR");
}
private void getAvailableSellXmrOffers() {
var offers = bobClient.getOffers(SELL.name(), "XMR", false);
var offers = bobClient.getOffers(SELL.name(), "XMR");
printAndCheckDiffs(offers, SELL.name(), "XMR");
}
@ -99,12 +99,12 @@ public class GetOffersCliOutputDiffTest extends AbstractCliTest {
}
private void getAvailableBuyBsqOffers() {
var offers = bobClient.getOffers(BUY.name(), "BSQ", false);
var offers = bobClient.getOffers(BUY.name(), "BSQ");
printAndCheckDiffs(offers, BUY.name(), "BSQ");
}
private void getAvailableSellBsqOffers() {
var offers = bobClient.getOffers(SELL.name(), "BSQ", false);
var offers = bobClient.getOffers(SELL.name(), "BSQ");
printAndCheckDiffs(offers, SELL.name(), "BSQ");
}

4
core/src/main/java/bisq/core/api/CoreApi.java
View file

@ -166,8 +166,8 @@ public class CoreApi {
return coreOffersService.getBsqSwapOffers(direction);
}
public List<Offer> getOffers(String direction, String currencyCode, boolean all) {
return coreOffersService.getOffers(direction, currencyCode, all);
public List<Offer> getOffers(String direction, String currencyCode) {
return coreOffersService.getOffers(direction, currencyCode);
}
public List<OpenOffer> getMyOffers(String direction, String currencyCode) {

6
core/src/main/java/bisq/core/api/CoreOffersService.java
View file

@ -206,14 +206,14 @@ class CoreOffersService {
.collect(Collectors.toList());
}
List<Offer> getOffers(String direction, String currencyCode, boolean all) {
List<Offer> getOffers(String direction, String currencyCode) {
var upperCaseCurrencyCode = currencyCode.toUpperCase();
var isFiat = isFiatCurrency(upperCaseCurrencyCode);
if (isFiat) {
return offerBookService.getOffers().stream()
.filter(o -> !o.isMyOffer(keyRing))
.filter(o -> offerMatchesDirectionAndCurrency(o, direction, upperCaseCurrencyCode))
.filter(o -> all || offerFilterService.canTakeOffer(o, coreContext.isApiUser()).isValid())
.filter(o -> offerFilterService.canTakeOffer(o, coreContext.isApiUser()).isValid())
.sorted(priceComparator(direction, true))
.collect(Collectors.toList());
} else {
@ -226,7 +226,7 @@ class CoreOffersService {
.filter(o -> !o.isMyOffer(keyRing))
.filter(o -> offerMatchesDirectionAndCurrency(o, direction, "BTC"))
.filter(o -> o.getBaseCurrencyCode().equalsIgnoreCase(upperCaseCurrencyCode))
.filter(o -> all || offerFilterService.canTakeOffer(o, coreContext.isApiUser()).isValid())
.filter(o -> offerFilterService.canTakeOffer(o, coreContext.isApiUser()).isValid())
.sorted(priceComparator(direction, false))
.collect(Collectors.toList());
else

4
core/src/main/resources/help/getoffers-help.txt
View file

@ -9,7 +9,6 @@ SYNOPSIS
getoffers
--direction=<buy|sell>
--currency-code=<eur|usd>
--all=<true|false>
DESCRIPTION
-----------
@ -25,9 +24,6 @@ OPTIONS
--currency-code
The three letter code for the fiat used to buy or sell BTC, e.g., EUR, USD, BRL, ...
--all
Whether return all offers or only these matching my accounts
EXAMPLES
--------
You have one Brazilian Real payment account with a face-to-face payment method type.

2
daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java
View file

@ -195,7 +195,7 @@ class GrpcOffersService extends OffersImplBase {
public void getOffers(GetOffersRequest req,
StreamObserver<GetOffersReply> responseObserver) {
try {
List<OfferInfo> result = coreApi.getOffers(req.getDirection(), req.getCurrencyCode(), req.getAll())
List<OfferInfo> result = coreApi.getOffers(req.getDirection(), req.getCurrencyCode())
.stream()
.map(OfferInfo::toOfferInfo)
.collect(Collectors.toList());

2
proto/src/main/proto/grpc.proto
View file

@ -148,7 +148,7 @@ message GetMyOfferReply {
message GetOffersRequest {
string direction = 1; // The offer's BUY (BTC) or SELL (BTC) direction.
string currency_code = 2; // The offer's fiat or altcoin currency code.
bool all = 3; // Return all or only these matching my account
reserved 3; // This was the "all" field before.
}
message GetOffersReply {