mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-01-19 05:44:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add re-review text to Contributing Doc

Browse Source 
Explicitly state that Pull Requests with changes should ask for a re-review when those changes have been made. This will help the review workflow since they only need to keep track of PRs in the "review required " state.
This commit is contained in:
Julian Knutsen 2019-11-26 07:39:50 -08:00 committed by GitHub
parent 06f0d6b191
commit 3ca02fcec3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CONTRIBUTING.md
View File

@ -21,6 +21,7 @@ All Bisq contributors submit changes via pull requests. The workflow is as follo
- Commit patches
- Squash redundant or unnecessary commits
- Submit a pull request from your topic branch back to the `master` branch of the main repository
- Make changes to the pull request if reviewers request them and __**request a re-review**__
Pull requests should be focused on a single change. Do not mix, for example, refactorings with a bug fix or implementation of a new feature. This practice makes it easier for fellow contributors to review each pull request on its merits and to give a clear ACK/NACK (see below).