Use params for trace logs.

This commit is contained in:
chimp1984 2020-09-29 12:55:23 -05:00
parent a3c69d5be6
commit 3926a36c3a
No known key found for this signature in database
GPG key ID: 9801B4EC591F90E3
10 changed files with 11 additions and 14 deletions

View file

@ -17,8 +17,8 @@
package bisq.common.crypto;
import bisq.common.util.Utilities;
import bisq.common.util.Hex;
import bisq.common.util.Utilities;
import javax.crypto.Cipher;
import javax.crypto.KeyGenerator;
@ -66,7 +66,6 @@ public class Encryption {
KeyPairGenerator keyPairGenerator = KeyPairGenerator.getInstance(ASYM_KEY_ALGO);
keyPairGenerator.initialize(2048);
KeyPair keyPair = keyPairGenerator.genKeyPair();
log.trace("Generate msgEncryptionKeyPair needed {} ms", System.currentTimeMillis() - ts);
return keyPair;
} catch (Throwable e) {
log.error("Could not create key.", e);

View file

@ -17,8 +17,8 @@
package bisq.common.crypto;
import bisq.common.util.Utilities;
import bisq.common.util.Base64;
import bisq.common.util.Utilities;
import com.google.common.base.Charsets;
@ -61,7 +61,6 @@ public class Sig {
KeyPairGenerator keyPairGenerator = KeyPairGenerator.getInstance(KEY_ALGO);
keyPairGenerator.initialize(1024);
KeyPair keyPair = keyPairGenerator.genKeyPair();
log.trace("Generate msgSignatureKeyPair needed {} ms", System.currentTimeMillis() - ts);
return keyPair;
} catch (NoSuchAlgorithmException e) {
log.error("Could not create key.", e);

View file

@ -336,7 +336,6 @@ public class LiteNodeNetworkService implements MessageListener, ConnectionListen
retryCounter++;
if (retryCounter <= MAX_RETRY) {
retryTimer = UserThread.runAfter(() -> {
log.trace("retryTimer called");
stopped = false;
stopRetryTimer();

View file

@ -66,7 +66,7 @@ public abstract class DisputeAgentService<T extends DisputeAgent> {
!Utilities.encodeToHex(disputeAgent.getRegistrationPubKey()).equals(DevEnv.DEV_PRIVILEGE_PUB_KEY)) {
boolean result = p2PService.addProtectedStorageEntry(disputeAgent);
if (result) {
log.trace("Add disputeAgent to network was successful. DisputeAgent.hashCode() = " + disputeAgent.hashCode());
log.trace("Add disputeAgent to network was successful. DisputeAgent.hashCode() = {}", disputeAgent.hashCode());
resultHandler.handleResult();
} else {
errorMessageHandler.handleErrorMessage("Add disputeAgent failed");
@ -82,7 +82,7 @@ public abstract class DisputeAgentService<T extends DisputeAgent> {
ErrorMessageHandler errorMessageHandler) {
log.debug("removeDisputeAgent disputeAgent.hashCode() " + disputeAgent.hashCode());
if (p2PService.removeData(disputeAgent)) {
log.trace("Remove disputeAgent from network was successful. DisputeAgent.hashCode() = " + disputeAgent.hashCode());
log.trace("Remove disputeAgent from network was successful. DisputeAgent.hashCode() = {}", disputeAgent.hashCode());
resultHandler.handleResult();
} else {
errorMessageHandler.handleErrorMessage("Remove disputeAgent failed");

View file

@ -382,7 +382,7 @@ public final class ArbitrationManager extends DisputeManager<ArbitrationDisputeL
private void sendPeerPublishedPayoutTxMessage(Transaction transaction, Dispute dispute, Contract contract) {
PubKeyRing peersPubKeyRing = dispute.isDisputeOpenerIsBuyer() ? contract.getSellerPubKeyRing() : contract.getBuyerPubKeyRing();
NodeAddress peersNodeAddress = dispute.isDisputeOpenerIsBuyer() ? contract.getSellerNodeAddress() : contract.getBuyerNodeAddress();
log.trace("sendPeerPublishedPayoutTxMessage to peerAddress " + peersNodeAddress);
log.trace("sendPeerPublishedPayoutTxMessage to peerAddress {}", peersNodeAddress);
PeerPublishedDisputePayoutTxMessage message = new PeerPublishedDisputePayoutTxMessage(transaction.bitcoinSerialize(),
dispute.getTradeId(),
p2PService.getAddress(),

View file

@ -82,7 +82,7 @@ public class SigTest {
assertTrue(false);
}
}
log.trace("took " + (System.currentTimeMillis() - ts) + " ms.");
log.trace("took {} ms.", System.currentTimeMillis() - ts);
}
}

View file

@ -508,7 +508,7 @@ public class Connection implements HasCapabilities, Runnable, MessageListener {
try {
socket.close();
} catch (SocketException e) {
log.trace("SocketException at shutdown might be expected " + e.getMessage());
log.trace("SocketException at shutdown might be expected {}", e.getMessage());
} catch (IOException e) {
log.error("Exception at shutdown. " + e.getMessage());
e.printStackTrace();

View file

@ -149,7 +149,7 @@ class RequestDataHandler implements MessageListener {
@Override
public void onSuccess(Connection connection) {
if (!stopped) {
log.trace("Send " + getDataRequest + " to " + nodeAddress + " succeeded.");
log.trace("Send {} to {} succeeded.", getDataRequest, nodeAddress);
} else {
log.trace("We have stopped already. We ignore that networkNode.sendMessage.onSuccess call." +
"Might be caused by an previous timeout.");

View file

@ -276,7 +276,7 @@ public class PeerExchangeManager implements MessageListener, ConnectionListener,
peerExchangeHandler.sendGetPeersRequestAfterRandomDelay(nodeAddress);
} else {
log.trace("We have started already a peerExchangeHandler. " +
"We ignore that call. nodeAddress=" + nodeAddress);
"We ignore that call. nodeAddress={}", nodeAddress);
}
} else {
log.trace("We have stopped already. We ignore that requestReportedPeers call.");

View file

@ -865,8 +865,8 @@ public class P2PDataStorage implements MessageListener, ConnectionListener, Pers
if (sequenceNumberMap.containsKey(hashOfData)) {
int storedSequenceNumber = sequenceNumberMap.get(hashOfData).sequenceNr;
if (newSequenceNumber > storedSequenceNumber) {
log.trace("Sequence number has increased (>). sequenceNumber = "
+ newSequenceNumber + " / storedSequenceNumber=" + storedSequenceNumber + " / hashOfData=" + hashOfData.toString());
/*log.trace("Sequence number has increased (>). sequenceNumber = "
+ newSequenceNumber + " / storedSequenceNumber=" + storedSequenceNumber + " / hashOfData=" + hashOfData.toString());*/
return true;
} else if (newSequenceNumber == storedSequenceNumber) {
String msg;