mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2025-02-22 06:41:41 +01:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2669 from ManfredKarrer/close-printwriter-before-rename-temp-file

Browse source 
Close printWriter before renaming temp file
This commit is contained in:
Christoph Atteneder 2019-04-08 10:42:37 +02:00 • committed by GitHub
commit 33a04bba57
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
common/src/main/java/bisq/common/storage/JsonFileManager.java
View file

@ -79,6 +79,13 @@ public class JsonFileManager {
printWriter = new PrintWriter(tempFile);
printWriter.println(json);
// This close call and comment is borrowed from FileManager. Not 100% sure it that is really needed but
// seems that had fixed in the past and we got reported issues on Windows so that fix might be still
// required.
// Close resources before replacing file with temp file because otherwise it causes problems on windows
// when rename temp file
printWriter.close();
FileUtil.renameFile(tempFile, jsonFile);
} catch (Throwable t) {
log.error("storageFile " + jsonFile.toString());