mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-19 09:52:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5788 from jmacxx/fix_refresh_ttl_exception

Browse Source 
Gracefully handle null data in refresh offer message and log error
This commit is contained in:
Christoph Atteneder 2021-11-04 10:06:44 +01:00 committed by GitHub
commit 2d3cf388eb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 38 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java
View File

@ -859,6 +859,7 @@ public class P2PDataStorage implements MessageListener, ConnectionListener, Pers
public boolean refreshTTL(RefreshOfferMessage refreshTTLMessage,
@Nullable NodeAddress sender) {
try {
ByteArray hashOfPayload = new ByteArray(refreshTTLMessage.getHashOfPayload());
ProtectedStorageEntry storedData = map.get(hashOfPayload);
@ -895,6 +896,11 @@ public class P2PDataStorage implements MessageListener, ConnectionListener, Pers
// Always broadcast refreshes
broadcaster.broadcast(refreshTTLMessage, sender);
} catch (IllegalArgumentException e) {
log.error("refreshTTL failed, missing data: {}", e.toString());
e.printStackTrace();
return false;
}
return true;
}