mirrors/bisq
1
0
Fork 0
mirror of https://github.com/bisq-network/bisq.git synced 2024-11-20 10:22:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

Quell help output on option parsing error

Browse Source 
This change suppresses help output when option parsing fails, e.g. due
to an unrecognized option being specified. This is in keeping with *nix
utility idioms; for example, notice what happens when running `git
--bogus` or `ls --bogus`: they output an error message, and in some
cases a usage message, but they do not print complete help text.
This approach is especially important in the case of an application like
Bisq, where there are many options and the help text is longer than a
typical screen, making it easy to miss the error message altogether, as
it is printed at the top of the screen.

This change also prints the error message to stderr vs stdout, which is
again in keeping with *nix utility idoms.
This commit is contained in:
Chris Beams 2018-11-23 09:05:24 +01:00
parent d31fb45ae6
commit 2b883c838a
No known key found for this signature in database
GPG Key ID: 3D214F8F5BC5ED73
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/src/main/java/bisq/core/app/BisqExecutable.java
View File

@ -100,9 +100,7 @@ public abstract class BisqExecutable implements GracefulShutDownHandler {
try {
options = parser.parse(args);
} catch (OptionException ex) {
System.out.println("error: " + ex.getMessage());
System.out.println();
parser.printHelpOn(System.out);
System.err.println("error: " + ex.getMessage());
System.exit(EXIT_FAILURE);
return false;
}
@ -133,9 +131,7 @@ public abstract class BisqExecutable implements GracefulShutDownHandler {
return;
}
} catch (OptionException ex) {
System.out.println("error: " + ex.getMessage());
System.out.println();
parser.printHelpOn(System.out);
System.err.println("error: " + ex.getMessage());
System.exit(EXIT_FAILURE);
return;
}