Make fields final.

Remove setter of key.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
This commit is contained in:
HenrikJannsen 2022-12-11 17:02:30 -05:00
parent 4f34be0a33
commit 21c6c52ec8
No known key found for this signature in database
GPG key ID: 02AA2BAE387C8307
3 changed files with 9 additions and 17 deletions

View file

@ -31,10 +31,9 @@ public enum DoubleValueItem implements ReportingItem {
@Getter @Getter
@Setter @Setter
private String key; private final String key;
@Getter @Getter
@Setter private final String group;
private String group;
@Getter @Getter
@Setter @Setter
private double value; private double value;
@ -54,8 +53,7 @@ public enum DoubleValueItem implements ReportingItem {
try { try {
item = DoubleValueItem.valueOf(key); item = DoubleValueItem.valueOf(key);
} catch (Throwable t) { } catch (Throwable t) {
item = DoubleValueItem.Unspecified; item = Unspecified;
item.setKey(key);
} }
item.setValue(value); item.setValue(value);

View file

@ -52,11 +52,9 @@ public enum LongValueItem implements ReportingItem {
jvmStartTimeInSec("node", "jvmStartTimeInSec"); jvmStartTimeInSec("node", "jvmStartTimeInSec");
@Getter @Getter
@Setter private final String key;
private String key;
@Getter @Getter
@Setter private final String group;
private String group;
@Getter @Getter
@Setter @Setter
private long value; private long value;
@ -76,8 +74,7 @@ public enum LongValueItem implements ReportingItem {
try { try {
item = LongValueItem.valueOf(key); item = LongValueItem.valueOf(key);
} catch (Throwable t) { } catch (Throwable t) {
item = LongValueItem.Unspecified; item = Unspecified;
item.setKey(key);
} }
item.setValue(value); item.setValue(value);

View file

@ -32,11 +32,9 @@ public enum StringValueItem implements ReportingItem {
commitHash("node", "commitHash"); commitHash("node", "commitHash");
@Getter @Getter
@Setter private final String key;
private String key;
@Getter @Getter
@Setter private final String group;
private String group;
@Getter @Getter
@Setter @Setter
private String value; private String value;
@ -56,8 +54,7 @@ public enum StringValueItem implements ReportingItem {
try { try {
item = StringValueItem.valueOf(key); item = StringValueItem.valueOf(key);
} catch (Throwable t) { } catch (Throwable t) {
item = StringValueItem.Unspecified; item = Unspecified;
item.setKey(key);
} }
item.setValue(value); item.setValue(value);