From fd3f0e6d2570c5a5a7461dfc1a204ad77958b4b5 Mon Sep 17 00:00:00 2001
From: Christoph Atteneder <christoph.atteneder@gmail.com>
Date: Mon, 1 Feb 2021 10:52:06 +0100
Subject: [PATCH 1/3] Minor cleanup

---
 .../pendingtrades/PendingTradesView.java          | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java b/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java
index c2dfcea6c6..0e82a2bd1e 100644
--- a/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java
+++ b/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java
@@ -126,16 +126,16 @@ public class PendingTradesView extends ActivatableViewAndModel<VBox, PendingTrad
     private Subscription selectedItemSubscription;
     private Stage chatPopupStage;
     private ListChangeListener<PendingTradesListItem> tradesListChangeListener;
-    private Map<String, Long> newChatMessagesByTradeMap = new HashMap<>();
+    private final Map<String, Long> newChatMessagesByTradeMap = new HashMap<>();
     private String tradeIdOfOpenChat;
     private double chatPopupStageXPosition = -1;
     private double chatPopupStageYPosition = -1;
     private ChangeListener<Number> xPositionListener;
     private ChangeListener<Number> yPositionListener;
 
-    private Map<String, Button> buttonByTrade = new HashMap<>();
-    private Map<String, JFXBadge> badgeByTrade = new HashMap<>();
-    private Map<String, ListChangeListener<ChatMessage>> listenerByTrade = new HashMap<>();
+    private final Map<String, Button> buttonByTrade = new HashMap<>();
+    private final Map<String, JFXBadge> badgeByTrade = new HashMap<>();
+    private final Map<String, ListChangeListener<ChatMessage>> listenerByTrade = new HashMap<>();
     private ChangeListener<Trade.State> tradeStateListener;
     private ChangeListener<Trade.DisputeState> disputeStateListener;
     private ChangeListener<MediationResultState> mediationResultStateListener;
@@ -536,9 +536,7 @@ public class PendingTradesView extends ActivatableViewAndModel<VBox, PendingTrad
         if (selectedItemFromModel != null) {
             // Select and focus selectedItem from model
             int index = tableView.getItems().indexOf(selectedItemFromModel);
-            UserThread.execute(() -> {
-                tableView.getSelectionModel().select(index);
-            });
+            UserThread.execute(() -> tableView.getSelectionModel().select(index));
         }
     }
 
@@ -864,7 +862,7 @@ public class PendingTradesView extends ActivatableViewAndModel<VBox, PendingTrad
         return chatColumn;
     }
 
-    private TableColumn<PendingTradesListItem, PendingTradesListItem> setRemoveTradeColumnCellFactory() {
+    private void setRemoveTradeColumnCellFactory() {
         moveTradeToFailedColumn.setCellValueFactory((trade) -> new ReadOnlyObjectWrapper<>(trade.getValue()));
         moveTradeToFailedColumn.setCellFactory(
                 new Callback<>() {
@@ -937,6 +935,5 @@ public class PendingTradesView extends ActivatableViewAndModel<VBox, PendingTrad
                         };
                     }
                 });
-        return moveTradeToFailedColumn;
     }
 }

From ade1c86c723f2628759e10bbcba005fa0203f90e Mon Sep 17 00:00:00 2001
From: Christoph Atteneder <christoph.atteneder@gmail.com>
Date: Mon, 1 Feb 2021 10:52:21 +0100
Subject: [PATCH 2/3] Reset references to enable GC

---
 .../desktop/main/portfolio/pendingtrades/PendingTradesView.java | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java b/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java
index 0e82a2bd1e..4836406669 100644
--- a/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java
+++ b/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java
@@ -576,6 +576,8 @@ public class PendingTradesView extends ActivatableViewAndModel<VBox, PendingTrad
                                     setGraphic(null);
                                     if (trade != null && listener != null) {
                                         trade.stateProperty().removeListener(listener);
+                                        trade = null;
+                                        listener = null;
                                     }
                                 }
                             }

From dcfcf6c2145aaffe5a855c7c3f785305820a7415 Mon Sep 17 00:00:00 2001
From: Christoph Atteneder <christoph.atteneder@gmail.com>
Date: Mon, 1 Feb 2021 11:24:20 +0100
Subject: [PATCH 3/3] Add sanity check

---
 .../desktop/main/portfolio/pendingtrades/PendingTradesView.java | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java b/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java
index 4836406669..81ef8590f6 100644
--- a/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java
+++ b/desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java
@@ -584,6 +584,8 @@ public class PendingTradesView extends ActivatableViewAndModel<VBox, PendingTrad
 
                             private void update() {
                                 HyperlinkWithIcon field;
+                                if (trade == null) return;
+
                                 if (isMaybeInvalidTrade(trade)) {
                                     field = new HyperlinkWithIcon(trade.getShortId());
                                     field.setIcon(FormBuilder.getMediumSizeIcon(MaterialDesignIcon.ALERT_CIRCLE_OUTLINE));